Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 546974 - dev-lang/ruby-2.1.6: no forced sse2 patch fails to patch
Summary: dev-lang/ruby-2.1.6: no forced sse2 patch fails to patch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: x86 Linux
: Normal blocker (vote)
Assignee: Gentoo Ruby Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-18 07:02 UTC by Geoff Madden
Modified: 2015-04-24 08:16 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge info x86 (emerge.inf,4.64 KB, text/plain)
2015-04-18 07:02 UTC, Geoff Madden
Details
results of attempted patch (012_no_forced_sse2.patch.out,3.48 KB, text/plain)
2015-04-18 07:03 UTC, Geoff Madden
Details
build log x86 (build.log,2.45 KB, text/x-log)
2015-04-18 07:04 UTC, Geoff Madden
Details
environment file (environment,121.14 KB, text/plain)
2015-04-18 07:07 UTC, Geoff Madden
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Geoff Madden 2015-04-18 07:02:27 UTC
Created attachment 401516 [details]
emerge info x86

no_forced-sse2 patch  fails to activate & consequently the configuration fails
Comment 1 Geoff Madden 2015-04-18 07:03:42 UTC
Created attachment 401518 [details]
results of attempted patch
Comment 2 Geoff Madden 2015-04-18 07:04:33 UTC
Created attachment 401520 [details]
build log x86
Comment 3 Geoff Madden 2015-04-18 07:07:35 UTC
Created attachment 401522 [details]
environment file
Comment 4 Hans de Graaff gentoo-dev Security 2015-04-19 17:23:15 UTC
It seems that this patch is no longer needed since the related and broken sse2 code in configure.in is gone. This also happened in ruby 2.2 so I guess this got backported.

Could you confirm if ruby-2.1.6 builds correctly with "CPU_FLAGS_X86=sse2"? I would assume that it does, and in that case we can drop both the patch and the flag altogether for this version.
Comment 5 Geoff Madden 2015-04-20 03:41:43 UTC
(In reply to Hans de Graaff from comment #4)
> It seems that this patch is no longer needed since the related and broken
> sse2 code in configure.in is gone. This also happened in ruby 2.2 so I guess
> this got backported.
> 
> Could you confirm if ruby-2.1.6 builds correctly with "CPU_FLAGS_X86=sse2"?
> I would assume that it does, and in that case we can drop both the patch and
> the flag altogether for this version.

I'll give that a go,but that particular machine doesn't have the sse2 flag for the cpu,it's an amd athlon-xp
Comment 6 Geoff Madden 2015-04-20 04:05:52 UTC
That didn't work so well.I echoed CPU_FLAGS_X86=sse2 to package use but portage in it's wisdom changed it to -sse2 in the configure.
Comment 7 Hans de Graaff gentoo-dev Security 2015-04-20 05:43:50 UTC
(In reply to Geoff Madden from comment #5)

> I'll give that a go,but that particular machine doesn't have the sse2 flag
> for the cpu,it's an amd athlon-xp

I understand, but in this specific case the sse2 flag is just there to avoid the broken patch. What I want to know is whether ruby successfully compiles in this case.
Comment 8 Geoff Madden 2015-04-20 06:08:58 UTC
(In reply to Hans de Graaff from comment #7)
> (In reply to Geoff Madden from comment #5)
> 
> > I'll give that a go,but that particular machine doesn't have the sse2 flag
> > for the cpu,it's an amd athlon-xp
> 
> I understand, but in this specific case the sse2 flag is just there to avoid
> the broken patch. What I want to know is whether ruby successfully compiles
> in this case.

in a word no. on my 64 bit machines which are using ruby22 there is not a hassle,only on the x86
Comment 9 Hans de Graaff gentoo-dev Security 2015-04-24 08:16:36 UTC
The broken sse2 patch has been removed in ruby 2.1.6-r1. I believe this should fix the issue. Please reopen the bug if there are still issues with this version.