Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 546126 - net-analyzer/wireshark should install a pkgconfig file
Summary: net-analyzer/wireshark should install a pkgconfig file
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Netmon project
URL: https://code.wireshark.org/review/#/c...
Whiteboard:
Keywords:
Depends on: 600086
Blocks: 579080
  Show dependency tree
 
Reported: 2015-04-10 08:04 UTC by Matthias Maier
Modified: 2018-05-02 18:38 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
This is how the wireshark.pc file should look like when installed (wireshark.pc,332 bytes, text/plain)
2015-04-18 07:27 UTC, Martin Kletzander
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Maier gentoo-dev 2015-04-10 08:04:45 UTC
Wireshark started to ship a pkgconfig file (wireshark.pc.in in the source directory) that is currently not installed by the ebuilds.

It turns out that app-emulation/libvirt now solely relies on the pkgconfig file being present in order to build their (optional) wireshark-plugin (and consequently fails to do so).

Can you please also install the pkgocnfig file?
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2015-04-11 00:46:52 UTC
Fixed without revision bump.
Comment 2 Matthias Maier gentoo-dev 2015-04-11 08:03:33 UTC
Thanks a lot!

There is one remaining issue, though. The wireshark.pc.in file was apparently written with CMake in mind - autoconf does not automatically populate the following variables:

  prefix=@CMAKE_INSTALL_PREFIX@
  libdir=${prefix}/@CMAKE_INSTALL_LIBDIR@
  plugindir=@PLUGIN_INSTALL_DIR@
  Version: @PROJECT_VERSION@

Some sed-magic in the ebuild, or further adjustment of the (autoconf) build system is necessary.
Comment 3 Martin Kletzander 2015-04-18 07:27:48 UTC
Created attachment 401524 [details]
This is how the wireshark.pc file should look like when installed

Just FYI the people in wireshark are not completely against the approach, but the code is not prepared for that.  I mean they don't install any header files, that's why the ebuild installs them itself.  So in case your patch fails to get in (as mine did) we can still make the pkgconfig file in the ebuild with some sed magic.

I haven't checked yet what the .pc file looks like with your patch, but this attachment shows what it should look like when installed, so please make sure there are not many things missing.
Comment 4 Michal Privoznik 2016-04-05 10:44:00 UTC
There were multiple fixes to this problem in wireshark:

https://code.wireshark.org/review/#/c/13258/
https://code.wireshark.org/review/#/c/13005/

Unfortunately, I have no idea when it's gonna be released.
Comment 5 Jeroen Roovers (RETIRED) gentoo-dev 2016-04-05 10:54:29 UTC
In 2.0.2 it looks like this:

prefix=/usr
exec_prefix=${prefix}
libdir=@ABSOLUTE_CMAKE_INSTALL_LIBDIR@
sharedlibdir=${libdir}
includedir=${prefix}/include/wireshark
plugindir=${libdir}/wireshark/2.0.2/plugins

Name: wireshark
Description: wireshark network packet dissection library
Version: 2.0.2

Requires:
Libs: -L${libdir} -L${sharedlibdir} -lwireshark
Cflags: -I${includedir}

So nearly there, I guess?
Comment 6 Martin Kletzander 2016-04-05 11:08:49 UTC
(In reply to Jeroen Roovers from comment #5)
> In 2.0.2 it looks like this:
> 
> prefix=/usr
> exec_prefix=${prefix}
> libdir=@ABSOLUTE_CMAKE_INSTALL_LIBDIR@
> sharedlibdir=${libdir}
> includedir=${prefix}/include/wireshark
> plugindir=${libdir}/wireshark/2.0.2/plugins
> 
> Name: wireshark
> Description: wireshark network packet dissection library
> Version: 2.0.2
> 
> Requires:
> Libs: -L${libdir} -L${sharedlibdir} -lwireshark
> Cflags: -I${includedir}
> 
> So nearly there, I guess?

Yes, I believe the only thing missing for this to work corretly is the 'Requires' to be filled in properly.  By the way, the stuff that should be there is changing, so we'd rather wait for it to be available from upstream than just adding that there ourselves.
Comment 7 Jeroen Roovers (RETIRED) gentoo-dev 2016-04-13 06:52:02 UTC
*** Bug 579080 has been marked as a duplicate of this bug. ***
Comment 8 Michal Privoznik 2016-12-07 10:25:39 UTC
Just to give you guys heads up - this is resolved with =net-analyzer/wireshark-2.2.2. Which also means the use flag masking can be lifted:

# grep -C3 wireshark /usr/portage/profiles/base/package.use.mask 

# Matthias Maier <tamiko@gentoo.org> (03 May 2015)
# mask use flag until #546126 is resolved
>=app-emulation/libvirt-1.2.14 wireshark-plugins

# James Le Cuirot <chewi@gentoo.org> (05 Apr 2015)
# dev-java/sun-j2me-bin is going away.
Comment 9 Jeroen Roovers (RETIRED) gentoo-dev 2017-01-22 12:20:30 UTC
(In reply to Michal Privoznik from comment #8)
> Just to give you guys heads up - this is resolved with
> =net-analyzer/wireshark-2.2.2.