Bug 545436 – dev-python/thunarx-python-0.3.0-r1: completely broken python-r1 conversion

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Michał Górny 2015-04-03 18:40:22 UTC]

*thunarx-python-0.3.0-r1 (12 Mar 2015)

  12 Mar 2015; Ian Delaney <[e-mail]> +thunarx-python-0.3.0-r1.ebuild:
  revbump; conversion -> distutils-r1 wrt bug #541296


--- thunarx-python-0.3.0.ebuild	2013-04-11 20:08:48.000000000 +0200
+++ thunarx-python-0.3.0-r1.ebuild	2015-03-12 06:13:04.000000000 +0100
@@ -1 +1 @@
-# Copyright 1999-2013 Gentoo Foundation
+# Copyright 1999-2015 Gentoo Foundation
@@ -3 +3 @@
-# $Header: /var/cvsroot/gentoo-x86/dev-python/thunarx-python/thunarx-python-0.3.0.ebuild,v 1.7 2013/04/11 18:08:48 ago Exp $
+# $Header: /var/cvsroot/gentoo-x86/dev-python/thunarx-python/thunarx-python-0.3.0-r1.ebuild,v 1.1 2015/03/12 05:13:04 idella4 Exp $
@@ -6,2 +6,3 @@ EAPI=5
-PYTHON_DEPEND=2
-inherit python xfconf
+PYTHON_COMPAT=( python2_7 )
+
+inherit python-r1 xfconf
@@ -15 +16 @@ SLOT="0"
-KEYWORDS="amd64 x86"
+KEYWORDS="~amd64 ~x86"
@@ -20,2 +21,2 @@ RDEPEND="x11-libs/gtk+:2
-	>=dev-python/pygobject-2.16:2
-	dev-python/pygtk:2
+	>=dev-python/pygobject-2.16:2[${PYTHON_USEDEP}]
+	dev-python/pygtk:2[${PYTHON_USEDEP}]
@@ -33,3 +33,0 @@ pkg_setup() {
-
-	python_set_active_version 2
-	python_pkg_setup


Which means:

1. incorrect eclass used (python-r1 is for multiple builds),

2. no update to build procedure = no eclass function used = no eclass used at all.

The direct result is that whatever active system Python is used, breaking stuff.

[Comment 1 Michał Górny 2015-04-03 18:41:45 UTC]

Oh, and also missing PYTHON_DEPS & PYTHON_REQUIRED_USE...

[Comment 2 Michał Górny 2015-04-03 18:47:24 UTC]

+  03 Apr 2015; Michał Górny <[e-mail]> thunarx-python-0.3.0-r1.ebuild:
+  Fix the ebuild to use python-single-r1, add missing metadata.