Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 544538 - net-libs/libsrtp-1.5.2 has a lot regressions, fails tests when updating from previous version
Summary: net-libs/libsrtp-1.5.2 has a lot regressions, fails tests when updating from ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Tony Vroon (RETIRED)
URL:
Whiteboard:
Keywords: TESTFAILURE
Depends on:
Blocks:
 
Reported: 2015-03-26 12:03 UTC by Nikoli
Modified: 2018-04-03 04:59 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
libsrtp-1.5.2.ebuild (libsrtp-1.5.2.ebuild,2.20 KB, text/plain)
2015-03-26 12:03 UTC, Nikoli
Details
libsrtp-1.5.2.ebuild (libsrtp-1.5.2.ebuild,2.19 KB, text/plain)
2015-03-26 12:19 UTC, Nikoli
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nikoli 2015-03-26 12:03:39 UTC
Created attachment 399804 [details]
libsrtp-1.5.2.ebuild

Fixed these bugs and regressions in attached ebuild:
1) soname was changed upstream, but SLOT in ebuild was not changed
2) tests fail when updating because soname was changed and src_test does not have LD_LIBRARY_PATH="${S}"
3) empty /usr/bin is installed
4) same shared lib is installed twice instead of using symlink
5) EAPI was changed to 5, but obsolete '|| die' were not removed.
6) epatch is used without adding eutils to inherit
7) get_libname was removed, but multilib was not removed from inherit
8) static lib is installed even with USE=-static-lib (bug #485606)

Patches are in https://github.com/cisco/libsrtp/pull/98 , but i can attach them here too if required.
Comment 1 Nikoli 2015-03-26 12:19:43 UTC
Created attachment 399806 [details]
libsrtp-1.5.2.ebuild

Forgot to remove 'use test &&'.
Comment 2 Nikoli 2015-04-02 21:16:38 UTC
Upstream merged my patches, but they added new questionable change:
https://github.com/cisco/libsrtp/commit/4cdf467bc8e400d7eb797d5030b6670104c84f56

Seems it is for tests only now, but it indicates how the development is done.
Comment 3 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2015-04-11 18:14:55 UTC
Thanks, committed:

11 Apr 2015; Pawel Hajdan jr
  +libsrtp-1.5.2-r1.ebuild, +files/libsrtp-1.5.2-bindir.patch,
  +files/libsrtp-1.5.2-fix-make-install.patch:
  Improve the ebuild, bug #544538 and patches by Nikoli.