544478 – dev-java/oracle-jdk-bin-1.8.0.40: does not install javafx-src.zip

Bug 544478 - dev-java/oracle-jdk-bin-1.8.0.40: does not install javafx-src.zip

Summary: dev-java/oracle-jdk-bin-1.8.0.40: does not install javafx-src.zip

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] Java (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Java team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2015-03-25 16:16 UTC by aditsu
Modified:	2015-03-26 16:07 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
oracle-jdk-bin-1.8.patch (oracle-jdk-bin-1.8.patch,902 bytes, patch) 2015-03-25 16:30 UTC, Patrice Clement	Details \| Diff
oracle-jdk-bin-1.8.patch (oracle-jdk-bin-1.8.patch,906 bytes, patch) 2015-03-25 16:31 UTC, Patrice Clement	Details \| Diff
oracle-jdk-bin-1.8.patch (oracle-jdk-bin-1.8.patch,605 bytes, patch) 2015-03-26 15:39 UTC, Patrice Clement	Details \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description aditsu 2015-03-25 16:16:05 UTC

I installed oracle-jdk-bin with USE=source, and it installed src.zip under /opt/oracle-jdk* but didn't install javafx-src.zip which is present alongside src.zip inside the distfile.

Reproducible: Always

Comment 1 Patrice Clement gentoo-dev

2015-03-25 16:30:02 UTC

Created attachment 399750 [details, diff]
oracle-jdk-bin-1.8.patch

Indeed. We should allow for JavaFX sources installation via a USE flag. Here's a possible solution.

@Java: could someone review it?

Comment 2 Patrice Clement gentoo-dev

2015-03-25 16:31:22 UTC

Created attachment 399752 [details, diff]
oracle-jdk-bin-1.8.patch

Comment 3 aditsu 2015-03-25 16:47:50 UTC

I expected the javafx sources to be installed with the source flag, but a separate flag is acceptable too.

Comment 4 James Le Cuirot gentoo-dev

2015-03-25 16:56:54 UTC

I was going to say that unless the file is really huge, don't complicate things by adding another flag when it's not expected.

Comment 5 Patrice Clement gentoo-dev

2015-03-26 15:39:37 UTC

Created attachment 399818 [details, diff]
oracle-jdk-bin-1.8.patch

Comment 6 Patrice Clement gentoo-dev

2015-03-26 15:52:51 UTC

+  26 Mar 2015; Patrice Clement <monsieurp@gentoo.org> metadata.xml,
+  oracle-jdk-bin-1.8.0.40.ebuild:
+  Install JavaFX sources as well as JVM sources. Document source USE flag. Fix
+  bug 544478.

Enjoy.

Comment 7 Patrice Clement gentoo-dev

2015-03-26 16:07:09 UTC

+*oracle-jdk-bin-1.8.0.40-r1 (26 Mar 2015)
+
+  26 Mar 2015; Patrice Clement <monsieurp@gentoo.org>
+  +oracle-jdk-bin-1.8.0.40-r1.ebuild, oracle-jdk-bin-1.8.0.40.ebuild:
+  Revert previous commit and revbump the file instead.
+

Safer. Just in case.