Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 543446 - <app-emulation/wine-1.7.20 requires upstream patch for GCC-4.9
Summary: <app-emulation/wine-1.7.20 requires upstream patch for GCC-4.9
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Wine Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-15 19:33 UTC by Adam Feldman
Modified: 2015-07-11 08:00 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Feldman gentoo-dev 2015-03-15 19:33:03 UTC
Due to aggressive null pointer check optimization, GCC-4.9 breaks wine versions before 1.7.20, including 1.6.2.
upstream bug: https://bugs.winehq.org/show_bug.cgi?id=36139
upstream patch: http://source.winehq.org/git/wine.git/patch/deb274226783ab886bdb44876944e156757efe2b

Reproducible: Always
Comment 1 Alex Xu (Hello71) 2015-03-15 21:42:11 UTC
"add patch to PATCHES on line <x>, <y>, <z> of ebuilds <a>, <b>, <c>"

then add proxy-maint@ for commit.
Comment 2 Adam Feldman gentoo-dev 2015-03-16 03:12:01 UTC
(In reply to Alex Xu (Hello71) from comment #1)
> "add patch to PATCHES on line <x>, <y>, <z> of ebuilds <a>, <b>, <c>"
> 
> then add proxy-maint@ for commit.

I added the bug as a way of tracking an issue for me to tackle.  Generally, I contact my proxy directly when something needs to get into the tree.  But I test everything before that.  This bug is a way to keep track of something that I need to get done.

The idea wasn't "post issue, have a proxy maintainer do the work and close it," it was "post issue to make it known that it is an issue, keep track of work to be done, once it is done update the bug"

For proxy maintainers, bugs are generally assigned to the proxy-maintainer themselves as they are responsible for maintaining the package, so I'd appreciate if you would not reassign my bugs to wine@gentoo.org
Comment 3 Ian Delaney (RETIRED) gentoo-dev 2015-03-16 03:30:13 UTC
Hello, Hello with a 71.

The assigning was correct in the first instance.  It is standard practice to assign a bug to yourself. 

(In reply to Alex Xu (Hello71) from comment #1)
> "add patch to PATCHES on line <x>, <y>, <z> of ebuilds <a>, <b>, <c>"
> 
> then add proxy-maint@ for commit.

Rest assured all this was going to happen anyway because he already knows it.  He just didn't explicitly state it. He is the (newly) designated proxy maintainer and therefore re-assigning to anyone or any herd is a mistake.  I won't bother re-re-assigning it's too messy.

Give him some time
Comment 4 Adam Feldman gentoo-dev 2015-03-23 01:51:39 UTC
To be included in major overhaul when emul-linux gets phased out.
Comment 5 Adam Feldman gentoo-dev 2015-07-11 08:00:39 UTC
Just committed to the Gentoo repo.

"Fixes bugs #548100, #539830, #543446, update to new multilib dependency code, and unify ebuild code/build system"