Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 542336 - >=net-misc/connman-1.28: keyword request
Summary: >=net-misc/connman-1.28: keyword request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Yixun Lan
URL:
Whiteboard:
Keywords: KEYWORDREQ
Depends on: 542378
Blocks: 547806
  Show dependency tree
 
Reported: 2015-03-06 09:07 UTC by Balint SZENTE
Modified: 2015-09-10 19:02 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
connman-1.28.ebuild (connman-1.28.ebuild,2.04 KB, text/plain)
2015-03-06 09:08 UTC, Balint SZENTE
Details
repoman.log (repoman.log,2.70 KB, text/plain)
2015-03-06 15:02 UTC, Patrice Clement
Details
metadata.xml (metadata.xml,1.06 KB, text/xml)
2015-03-06 17:48 UTC, Balint SZENTE
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Balint SZENTE 2015-03-06 09:07:49 UTC
ConnMan 1.28 was released on February 1st, 2015.

Please find attached the ebuild. I made a few improvements to the 1.27 ebuild:

* Fixed the SRC_URI
* added support for PPTP and L2TP
* GnuTLS made optional, it is required only for optional WISPr support.


Reproducible: Always



Expected Results:  
Please add it to the portage tree.
Comment 1 Balint SZENTE 2015-03-06 09:08:54 UTC
Created attachment 398212 [details]
connman-1.28.ebuild
Comment 2 Patrice Clement gentoo-dev 2015-03-06 15:02:55 UTC
Created attachment 398246 [details]
repoman.log

Hi Balint, thank you for taking the time to version bump our ebuilds. Your ebuild contains a couple of errors that do not pass the QA tests. Nothing to worry about :) Just simple mistakes. I've attached the log file containing the errors repoman display. Going forward, you should make sure your ebuild passes them. Always run the command `repoman full' in the directory you're version bumping the ebuild for and check the output. Thank you!
Comment 3 Patrice Clement gentoo-dev 2015-03-06 15:06:17 UTC
@dlan/chainsaw: if you guys know how to fix the ebuild, go ahead. you are the official maintainers ;)
Comment 4 Balint SZENTE 2015-03-06 15:13:41 UTC
Thanks for the advice. I certainly will check my ebuilds from now on.

Also pptpclient and xl2tpd are runtime dependencies. Should be RDEPEND. I will try to fix the ebuild.
Comment 5 Balint SZENTE 2015-03-06 17:48:13 UTC
Created attachment 398252 [details]
metadata.xml

metadata.xml that fixes the IUSE errors.
Comment 6 Balint SZENTE 2015-03-06 17:56:12 UTC
(In reply to Balint SZENTE from comment #4)
> Also pptpclient and xl2tpd are runtime dependencies. Should be RDEPEND. I
> will try to fix the ebuild.

There is nothing to fix :-) They are RDEPEND.

So, regarding the dependency error with ~arm and ~ppc64 keywords... the xl2tpd package does not have these keywords. What should be the policy in this case? Is it possible to disable the use flag based on keyword/architecture? AFAIK this should be handled somehow with profiles, to mask the l2tp use flag for this package for the "~arm" and "~ppc64" architectures.

What is your opinion, what is the best way to fix this?
Comment 7 Yixun Lan archtester gentoo-dev 2015-03-06 20:36:08 UTC
open a keyword request bug for xl2tpd, see bug 542378

I may find time to test on ARCH=arm myself, and if ppc64 team couldn't proceed in time, I'll drop that keyword, of course they can always test and restore the keyword later.
Comment 8 Yixun Lan archtester gentoo-dev 2015-03-07 14:01:16 UTC
+*connman-1.28 (07 Mar 2015)
+
+  07 Mar 2015; Yixun Lan <dlan@gentoo.org> +connman-1.28.ebuild, metadata.xml:
+  version bump, fix bug 542336, new USE="l2tp pptp wispr" introduced; drop
+  ppc/ppc64 keyword, see bug 542378. thanks Balint SZENTE

@ppc team, feel free to restore ppc/ppc64 keywords, it's your call.

btw, @Balint, would you like to be a proxy-maintainter of this package, I could add you to metadata.xml
Comment 9 Balint SZENTE 2015-03-09 10:36:44 UTC
(In reply to Yixun Lan from comment #8)
> btw, @Balint, would you like to be a proxy-maintainter of this package, I
> could add you to metadata.xml

Ok, let's try it. I'll do my best to help. Thanks.
Comment 10 Jeroen Roovers (RETIRED) gentoo-dev 2015-05-05 08:02:33 UTC
Marked ~ppc64.
Comment 11 Michael Palimaka (kensington) gentoo-dev 2015-09-10 19:02:39 UTC
All keywords are since restored.