Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 539276 - net-firewall/shorewall: Please drop STABLE keywords for dynamic Beta/RC versions
Summary: net-firewall/shorewall: Please drop STABLE keywords for dynamic Beta/RC versions
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Keywording and Stabilization (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Proxy Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-07 22:27 UTC by Thomas Deutschmann (RETIRED)
Modified: 2015-02-07 23:00 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Deutschmann (RETIRED) gentoo-dev 2015-02-07 22:27:00 UTC 
Hi,

while stabilizing shorewall (see bug 536796) all the dynamic Beta/RC versions got keyword'ed, too. Please remove these keywords, patch:

--- shorewall-4.6.6.1.old       2015-02-07 23:26:05.000000000 +0100
+++ shorewall-4.6.6.1.ebuild    2015-02-07 23:26:19.000000000 +0100
@@ -57,7 +57,7 @@
 MY_URL_PREFIX=
 MY_URL_SUFFIX=
 if [[ ${MY_PV} = *-Beta* ]] || [[ ${MY_PV} = *-RC* ]]; then
-       KEYWORDS="alpha amd64 hppa ppc ppc64 sparc x86"
+       KEYWORDS=""
        MY_URL_PREFIX='development/'

        _tmp_last_index=$(($(get_last_version_component_index ${MY_PV})+1))


Reproducible: Always
Comment 1 Mike Gilbert gentoo-dev 2015-02-07 22:35:01 UTC 
There are no beta/rc versions in the tree, so reversing this change does nothing.
Comment 2 Thomas Deutschmann (RETIRED) gentoo-dev 2015-02-07 22:40:55 UTC 
Yes, but it is wrong that someone changed this line while stabilizing.
It is a "bug" (while writing the ebuild I set KEYWORDS="" for Beta/RC on purpose) which should get fixed. Not?
Comment 3 Mike Gilbert gentoo-dev 2015-02-07 22:46:06 UTC 
(In reply to Thomas D. from comment #2)
> Yes, but it is wrong that someone changed this line while stabilizing.
> It is a "bug" (while writing the ebuild I set KEYWORDS="" for Beta/RC on
> purpose) which should get fixed. Not?

It's a side-effect of using the ekeyword script (see app-portage/gentoolkit-dev), which updates all instances of KEYWORDS in the ebuild. This is bound to happen again unless you simply drop the second instance of KEYWORDS.
Comment 4 Thomas Deutschmann (RETIRED) gentoo-dev 2015-02-07 22:52:41 UTC 
I understand, so the following ebuild change should fix and avoid this problem in future:


--- shorewall-4.6.6.1.old       2015-02-07 23:26:05.000000000 +0100
+++ shorewall-4.6.6.1.ebuild    2015-02-07 23:51:01.000000000 +0100
@@ -11,7 +11,6 @@
 HOMEPAGE="http://www.shorewall.net/"
 LICENSE="GPL-2"
 SLOT="0"
-KEYWORDS="alpha amd64 hppa ppc ppc64 sparc x86"
 IUSE="doc +init +ipv4 ipv6 lite4 lite6"

 MY_PV=${PV/_rc/-RC}
@@ -57,7 +56,6 @@
 MY_URL_PREFIX=
 MY_URL_SUFFIX=
 if [[ ${MY_PV} = *-Beta* ]] || [[ ${MY_PV} = *-RC* ]]; then
-       KEYWORDS="alpha amd64 hppa ppc ppc64 sparc x86"
        MY_URL_PREFIX='development/'

        _tmp_last_index=$(($(get_last_version_component_index ${MY_PV})+1))
@@ -69,6 +67,8 @@
        # Cleaning up temporary variables
        unset _tmp_last_index
        unset _tmp_suffix
+else
+       KEYWORDS="alpha amd64 hppa ppc ppc64 sparc x86"
 fi

 SRC_URI="
Comment 5 Thomas Deutschmann (RETIRED) gentoo-dev 2015-02-07 22:54:49 UTC 
Assigning to proxy-maint to apply this change or comment, if you disagree. Thanks!
Comment 6 Mike Gilbert gentoo-dev 2015-02-07 23:00:15 UTC 
Looks good to me.

+  07 Feb 2015; Mike Gilbert <floppym@gentoo.org> shorewall-4.6.6.1.ebuild:
+  Adjust KEYWORDS handling, bug 539276 by Thomas D.