Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug
Bug#: 53924
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo Games <games@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Miles Lubin <miles@lubin.us>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
patch here are the steps i took to patch text/plain Miles Lubin 2004-07-28 10:27 0000 3.19 KB Details
tribes2-25034-r1.ebuild tribes2-25034-r1.ebuild text/plain Miles Lubin 2004-07-29 12:27 0000 3.06 KB Details
update-sh.patch update-sh.patch patch Miles Lubin 2004-07-29 12:28 0000 801 bytes Details | Diff
tribes2-25034.ebuild games-fps/tribes2/tribes2-25034.ebuild text/plain Chris Gianelloni (RETIRED) 2004-09-16 18:49 0000 2.49 KB Details
tribes2-25034-r1.ebuild tribes2-25034-r1.ebuild text/plain Miles Lubin 2004-09-17 13:42 0000 2.96 KB Details
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 53924 depends on: Show dependency tree
Bug 53924 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2004-06-14 15:30 0000
I have the loki tribes 2 cd, with which I emerged tribes 2. When I launch
tribes 2, it reports that it is version 21570, yet the version number of the
ebuild is 25034, obviously it was never patched.

Reproducible: Always
Steps to Reproduce:
1.CD_ROOT=(location of tribes 2 mount) emerge tribes2
2.launch tribes 2 with t2launch
3.log in
4.note version number in upper right corner

Actual Results:  
It diaplayed that it was version 21570.

Expected Results:  
It should have been version 25043.

------- Comment #1 From Chris Gianelloni (RETIRED) 2004-06-15 06:10:15 0000 -------
I'll look into this... I guess it's a good thing I didn't sell my Tribes 2
CD... ;]

------- Comment #2 From Miles Lubin 2004-06-17 12:42:14 0000 -------
I think I may have found part of the problem. The patch uses the depreciated
syntax +(line number) with tail. I fixed this to -n (line number), and disabled
the checksum checks, but the patch still didnt work :(
It says that the data of the patch is not in gzip format. I dont know shell
scripting enough to get any deeper than that. Hope this helps.

------- Comment #3 From folken 2004-07-05 07:33:26 0000 -------
There is a work around on the homepage of makeself:

export _POSIX2_VERSION=199209

This will make tail interpret the old syntax again. Patching around the self extracting file, seems futile to me, as the checksums will fail.

Can somebody that has more skill with ebuilds than me, implement the above?

------- Comment #4 From Miles Lubin 2004-07-28 10:25:24 0000 -------
ok, i applied the patch manually using the export posix and help from form
post, to be attached is the log of all the steps i took
note - the copying of the directory wasnt necesary, as seen at the end

------- Comment #5 From Miles Lubin 2004-07-28 10:27:46 0000 -------
Created an attachment (id=36338) [details]
here are the steps i took to patch

I took a look at the ebuild and didnt have a good idea of how to put this into
there, so any help would be appreciated

------- Comment #6 From Miles Lubin 2004-07-29 12:25:23 0000 -------
Problem solved, ebuild and a patch to follow.

------- Comment #7 From Miles Lubin 2004-07-29 12:27:34 0000 -------
Created an attachment (id=36411) [details]
tribes2-25034-r1.ebuild

took a bit of work, but this will patch correctly. Note the changes needed for
sound to work.

------- Comment #8 From Miles Lubin 2004-07-29 12:28:55 0000 -------
Created an attachment (id=36412) [details]
update-sh.patch

A patch for the patch script to make it allow piped input.

------- Comment #9 From Chris Gianelloni (RETIRED) 2004-09-16 18:48:33 0000 -------
I started working on this today and must say that I cannot believe that I
totally forgot to put the loki_patch lines in the ebuild!

Anyway, rather than using your solution, which works quite well, I am instead
working to add the loki_* tools into portage proper.  This way they can be
reused easily on multiple ebuilds.  I already have one other ebuild that I
would like to add to portage but it segfaults on trying to patch.

I am attaching my current version of the ebuild, which doesn't work due to the
patch segfaulting, but it'll give you an idea of where I'm going with it.

------- Comment #10 From Chris Gianelloni (RETIRED) 2004-09-16 18:49:12 0000 -------
Created an attachment (id=39732) [details]
games-fps/tribes2/tribes2-25034.ebuild

------- Comment #11 From Miles Lubin 2004-09-17 13:42:55 0000 -------
Created an attachment (id=39788) [details]
tribes2-25034-r1.ebuild

You need to use the modified loki_patch that I use in the ebuild. 
Fixed your ebuild to use it, put in the warning about the sound, and changed
tribes2 to t2launch, as tribes2 will error out if you dont give it an argument.

------- Comment #12 From Chris Gianelloni (RETIRED) 2004-09-17 14:01:18 0000 -------
I have no intention of using a pre-compiled binary loki_patch, so there's no
need to even go that route.  I am adding the loki_* tools to portage and will
be forcing a DEPEND on them for this package.  Also, the sound stuff can be
done within the ebuild, more than likely.  It makes for a much cleaner
interface to do all the work in the ebuild rather than pushing it onto the
user, who more than likely won't see the message anyway and will then come here
and file a bug about their sound not working... ;]

Like I said, it was a work in progress, I wasn't looking to have someone
correct it... ;]

------- Comment #13 From Dennis Schridde 2004-10-10 17:20:47 0000 -------
Are you still working on this or is it fixed, yet?
I would like to install my t2...

------- Comment #14 From Chris Gianelloni (RETIRED) 2004-10-11 04:05:56 0000 -------
Sorry... it has been in portage, I just didn't update the ebuild revision
(since it used to work) and also forgot to close the bug.

Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug