Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 539172 - x11-drivers/xf86-video-v4l-0.2.0 with x11-base/xorg-server-1.17.0 - v4l.c:359:35: error: 'VIDEO_INVERT_CLIPLIST' undeclared (first use in this function)
Summary: x11-drivers/xf86-video-v4l-0.2.0 with x11-base/xorg-server-1.17.0 - v4l.c:359...
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords: PATCH
: 567594 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-02-07 02:45 UTC by jospezial
Modified: 2017-02-26 04:02 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
xf86-video-v4l-0.2.0-build-fix.patch (xf86-video-v4l-0.2.0-build-fix.patch,468 bytes, patch)
2015-02-23 10:12 UTC, Chí-Thanh Christopher Nguyễn
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jospezial 2015-02-07 02:45:19 UTC
make  all-recursive
make[1]: Entering directory '/var/tmp/portage/x11-drivers/xf86-video-v4l-0.2.0/work/xf86-video-v4l-0.2.0'
Making all in src
make[2]: Entering directory '/var/tmp/portage/x11-drivers/xf86-video-v4l-0.2.0/work/xf86-video-v4l-0.2.0/src'
/bin/sh ../libtool --tag=CC   --mode=compile x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I..    -fvisibility=hidden -I/usr/include/xorg -I/usr/include/pixman-1 -I/usr/include/X11/dri -I/usr/include/libdrm  -march=native -O2 -pipe -MT v4l.lo -MD -MP -MF .deps/v4l.Tpo -c -o v4l.lo v4l.c
mkdir .libs
 x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I.. -fvisibility=hidden -I/usr/include/xorg -I/usr/include/pixman-1 -I/usr/include/X11/dri -I/usr/include/libdrm -march=native -O2 -pipe -MT v4l.lo -MD -MP -MF .deps/v4l.Tpo -c v4l.c  -fPIC -DPIC -o .libs/v4l.o
In file included from v4l.c:21:0:
/usr/include/xorg/xf86PciInfo.h:50:2: warning: #warning "xf86PciInfo.h is deprecated.  For greater compatibility, drivers should include necessary PCI IDs locally rather than relying on this file from xorg-server." [-Wcpp]
 #warning "xf86PciInfo.h is deprecated.  For greater compatibility, drivers should include necessary PCI IDs lo
  ^
v4l.c: In function 'V4lPutVideo':
v4l.c:321:35: warning: assignment makes pointer from integer without a cast
      if (NULL == (pPPriv->surface = xalloc(sizeof(XF86SurfaceRec))))
                                   ^
v4l.c:359:35: error: 'VIDEO_INVERT_CLIPLIST' undeclared (first use in this function)
  if (0 == (pPPriv->myfmt->flags & VIDEO_INVERT_CLIPLIST)) {
                                   ^
v4l.c:359:35: note: each undeclared identifier is reported only once for each function it appears in
v4l.c:440:24: warning: assignment makes pointer from integer without a cast
  pPPriv->rgb_win.clips = xalloc(pPPriv->rgb_win.clipcount*sizeof(struct video_clip));
                        ^
v4l.c: In function 'v4l_add_enc':
v4l.c:718:19: warning: assignment makes pointer from integer without a cast
     enc[i].name   = xalloc(strlen(norm)+strlen(input)+2);
                   ^
v4l.c:725:13: warning: passing argument 1 of 'sprintf' discards 'const' qualifier from pointer target type
     sprintf(enc[i].name,"%s-%s",norm,fixname(input));
             ^
In file included from /usr/include/features.h:366:0,
                 from /usr/include/sys/types.h:25,
                 from v4l.c:10:
/usr/include/bits/stdio2.h:31:1: note: expected 'char * __restrict__' but argument is of type 'const char *'
 __NTH (sprintf (char *__restrict __s, const char *__restrict __fmt, ...))
 ^
v4l.c: In function 'V4LBuildEncodings':
v4l.c:741:12: warning: assignment makes pointer from integer without a cast
     p->enc = xalloc(sizeof(XF86VideoEncodingRec) * entries);
            ^
v4l.c:745:13: warning: assignment makes pointer from integer without a cast
     p->norm = xalloc(sizeof(int) * entries);
             ^
v4l.c:749:14: warning: assignment makes pointer from integer without a cast
     p->input = xalloc(sizeof(int) * entries);
              ^
v4l.c: In function 'v4l_add_attr':
v4l.c:842:11: warning: assignment makes pointer from integer without a cast
     *list = xalloc((*count + 1) * sizeof(XF86AttributeRec));
           ^
v4l.c: In function 'V4LInit':
v4l.c:921:9: warning: assignment makes pointer from integer without a cast
  pPPriv = xalloc(sizeof(PortPrivRec));
         ^
v4l.c:942:6: warning: assignment makes pointer from integer without a cast
  VAR = xrealloc(VAR,sizeof(XF86VideoAdaptorPtr)*(i+1));
      ^
v4l.c:943:9: warning: assignment makes pointer from integer without a cast
  VAR[i] = xalloc(sizeof(XF86VideoAdaptorRec));
         ^
v4l.c:979:10: warning: assignment makes pointer from integer without a cast
  Private = xalloc(sizeof(DevUnion));
          ^
v4l.c:990:18: error: 'VIDEO_INVERT_CLIPLIST' undeclared (first use in this function)
  VAR[i]->flags = VIDEO_INVERT_CLIPLIST;
                  ^
Makefile:320: recipe for target 'v4l.lo' failed
make[2]: *** [v4l.lo] Error 1
make[2]: Leaving directory '/var/tmp/portage/x11-drivers/xf86-video-v4l-0.2.0/work/xf86-video-v4l-0.2.0/src'
Makefile:291: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/var/tmp/portage/x11-drivers/xf86-video-v4l-0.2.0/work/xf86-video-v4l-0.2.0'
Makefile:221: recipe for target 'all' failed
make: *** [all] Error 2
emake failed
 * ERROR: x11-drivers/xf86-video-v4l-0.2.0::gentoo failed (compile phase):
 *   emake failed
 * 
 * Call stack:
 *     ebuild.sh, line   93:  Called src_compile
 *   environment, line 3034:  Called x-modular_src_compile
 *   environment, line 3797:  Called x-modular_src_make
 *   environment, line 3835:  Called die
 * The specific snippet of code:
 *       emake || die "emake failed"
 * 
 * If you need support, post the output of `emerge --info '=x11-drivers/xf86-video-v4l-0.2.0::gentoo'`,
 * the complete build log and the output of `emerge -pqv '=x11-drivers/xf86-video-v4l-0.2.0::gentoo'`.
 * The complete build log is located at '/var/tmp/portage/x11-drivers/xf86-video-v4l-0.2.0/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/x11-drivers/xf86-video-v4l-0.2.0/temp/environment'.
 * Working directory: '/var/tmp/portage/x11-drivers/xf86-video-v4l-0.2.0/work/xf86-video-v4l-0.2.0'
 * S: '/var/tmp/portage/x11-drivers/xf86-video-v4l-0.2.0/work/xf86-video-v4l-0.2.0'
 * 
 * The following package has failed to build or install:
 * 
 *  (x11-drivers/xf86-video-v4l-0.2.0:0/0::gentoo, ebuild scheduled for merge), Log file:
 *   '/var/tmp/portage/x11-drivers/xf86-video-v4l-0.2.0/temp/build.log'
 * 


from
http://cgit.freedesktop.org/xorg/xserver/commit/?id=a6ec7d5278405d69e60cca2964006fb7ce32c556

xv: Remove dead VIDEO_INVERT_CLIPLIST from the xorg and kdrive DDXes.
As far as I can see (looking at trees on my disk, plus googling for the term), nothing has ever used this flag

---------------------------------

so there is at least one package which uses that.

Next thing is the warning from /usr/include/xorg/xf86PciInfo.h:

warning "xf86PciInfo.h is deprecated.  For greater compatibility, drivers should include necessary PCI IDs locally rather than relying on this file from xorg-server."


If I look at
http://cgit.freedesktop.org/xorg/driver/xf86-video-v4l/log/
there is no work since
2011-06-30	Bump version for development.HEAD master
Comment 1 Chí-Thanh Christopher Nguyễn gentoo-dev 2015-02-08 14:42:54 UTC
It is probably best if you report this upstream at https://bugs.freedesktop.org/ (in xorg driver/other component) and CC: the author of the patch that broke things.

Once you have created a bug report, you can add its URL to this bug.
Comment 2 Matt Turner gentoo-dev 2015-02-21 21:19:22 UTC
This was removed upstream by

commit a6ec7d5278405d69e60cca2964006fb7ce32c556
Author: Eric Anholt <eric@anholt.net>
Date:   Fri Dec 27 20:53:00 2013 -0800

    xv: Remove dead VIDEO_INVERT_CLIPLIST from the xorg and kdrive DDXes.
    
    As far as I can see (looking at trees on my disk, plus googling for
    the term), nothing has ever used this flag
    
    Signed-off-by: Eric Anholt <eric@anholt.net>
    Reviewed-by: Keith Packard <keithp@keithp.com>

He was obviously wrong that nothing has ever used the flag.

Looking at the xf86-video-v4l repo, there have been no changes since 2011-06-30. Does anyone actually use this driver? Can we remove it?
Comment 3 Chí-Thanh Christopher Nguyễn gentoo-dev 2015-02-23 10:12:17 UTC
Created attachment 397300 [details, diff]
xf86-video-v4l-0.2.0-build-fix.patch

Patch from Fedora for xorg-server-1.17 compatibility

As Fedora heavily patches their v4l driver, it will not apply cleanly to unmodified code from the 0.2.0 release tarball.
Comment 4 Matt Turner gentoo-dev 2015-02-23 18:44:35 UTC
(In reply to Chí-Thanh Christopher Nguyễn from comment #3)
> Created attachment 397300 [details, diff] [details, diff]
> xf86-video-v4l-0.2.0-build-fix.patch
> 
> Patch from Fedora for xorg-server-1.17 compatibility
> 
> As Fedora heavily patches their v4l driver, it will not apply cleanly to
> unmodified code from the 0.2.0 release tarball.

It's not clear to me that simply adding the define back is sufficient to make it work (not simply compile), since the xserver support was removed.
Comment 5 Tomáš Mózes 2015-12-06 05:22:43 UTC
*** Bug 567594 has been marked as a duplicate of this bug. ***
Comment 6 Matt Turner gentoo-dev 2017-02-26 04:02:20 UTC
Package removed per bug 606132.