Created attachment 395288 [details] audacious-3.6_beta1.ebuild Including early ebuilds for the new audacious and audacious-plugins. I could not get the audacious-plugins to build with qt-only so this ebuild will build just the gtk2 interface. (audacious page claims all the plugins have not been ported to qt yet) I updated dependency from gtk3 to gtk2 as audacious-3.6 has upgraded. Maybe someone else can figure out getting it to build with qt.
Created attachment 395290 [details] audacious-plugins-3.6_beta1.ebuild
Comment on attachment 395288 [details] audacious-3.6_beta1.ebuild --- audacious-3.5.1.ebuild +++ audacious-3.5.1.ebuild @@ -9,8 +9,7 @@ S="${WORKDIR}/${MY_P}" DESCRIPTION="Audacious Player - Your music, your way, no exceptions" HOMEPAGE="http://audacious-media-player.org/" -SRC_URI="http://distfiles.audacious-media-player.org/${MY_P}.tar.bz2 - mirror://gentoo/gentoo_ice-xmms-0.2.tar.bz2" +SRC_URI="http://distfiles.audacious-media-player.org/${MY_P}.tar.bz2" LICENSE="BSD-2" SLOT="0" @@ -23,14 +22,14 @@ dev-libs/libxml2 >=x11-libs/cairo-1.2.6 >=x11-libs/pango-1.8.0 - x11-libs/gtk+:3" + x11-libs/gtk+:2" DEPEND="${RDEPEND} virtual/pkgconfig chardet? ( >=app-i18n/libguess-1.2 ) nls? ( dev-util/intltool )" -PDEPEND="~media-plugins/audacious-plugins-3.5.1" +PDEPEND="~media-plugins/audacious-plugins-3.6_beta1" src_configure() { # D-Bus is a mandatory dependency, remote control, @@ -47,10 +46,4 @@ src_install() { default dodoc AUTHORS - - # Gentoo_ice skin installation; bug #109772 - insinto /usr/share/audacious/Skins/gentoo_ice - doins "${WORKDIR}"/gentoo_ice/* - docinto gentoo_ice - dodoc "${WORKDIR}"/README }
Comment on attachment 395290 [details] audacious-plugins-3.6_beta1.ebuild --- audacious-plugins-3.5.1.ebuild +++ audacious-plugins-3.5.1.ebuild @@ -21,9 +21,9 @@ >=dev-libs/dbus-glib-0.60 dev-libs/libxml2:2 media-libs/libmodplug - ~media-sound/audacious-3.5.1 + ~media-sound/audacious-3.6_beta1 >=net-libs/neon-0.26.4 - x11-libs/gtk+:3 + x11-libs/gtk+:2 ( || ( >=dev-libs/glib-2.32.2[utils] dev-util/gdbus-codegen ) ) aac? ( >=media-libs/faad2-2.7 ) adplug? ( >=dev-cpp/libbinio-1.4 ) @@ -57,8 +57,6 @@ nls? ( dev-util/intltool ) virtual/pkgconfig" -DOCS="AUTHORS" - mp3_warning() { if ! use mp3 ; then ewarn "MP3 support is optional, you may want to enable the mp3 USE-flag"
Just realized looking at diff, you can totally leave in the gentoo ice theme, I took it out of SRC_URI by accident thinking it was gentoo mirror for audacious.
I fail to see the rationale for downgrading from GTK 3 to 2. Based on what you are saying you could have renamed the ebuilds and changed just the interdependencies for core & plugins?
Well the rationale wasn't mine. Upstream realized gtk3 wasn't going to serve their needs so they started work on a new qt5 UI and went back to gtk2 in the meanwhile. Read: http://audacious-media-player.org/news/32-audacious-3-6-beta1-released There's another source package they only recommend GNOME users pick up if the gtk3 interface is still preferred. It's entirely different tarballs. Again, I wasn't able to get it to build with qt5-only, some of the plugins failed.
http://audacious-media-player.org/news/32-audacious-3-6-released 3.6 released.
As Gnome 3 user i against downgrading audacious to GTK+-2. GTK+-3 version works good for me: audacious-3.6.ebuild: --- ../../../../../portage/media-sound/audacious/audacious-3.5.1.ebuild 2014-08-01 01:32:03.000000000 +0400 +++ ./audacious-3.6.ebuild 2015-03-03 21:48:28.667479225 +0300 @@ -5,7 +5,7 @@ EAPI=5 inherit eutils -MY_P="${P/_/-}" +MY_P="${P/_/-}-gtk3" S="${WORKDIR}/${MY_P}" DESCRIPTION="Audacious Player - Your music, your way, no exceptions" HOMEPAGE="http://audacious-media-player.org/" @@ -30,7 +30,7 @@ chardet? ( >=app-i18n/libguess-1.2 ) nls? ( dev-util/intltool )" -PDEPEND="~media-plugins/audacious-plugins-3.5.1" +PDEPEND="~media-plugins/audacious-plugins-3.6" src_configure() { # D-Bus is a mandatory dependency, remote control, audacious-plugins-3.6.ebuild: --- ../../../../../portage/media-plugins/audacious-plugins/audacious-plugins-3.5.1.ebuild 2014-08-01 01:44:25.000000000 +0400 +++ ./audacious-plugins-3.6.ebuild 2015-03-03 21:44:55.783200512 +0300 @@ -5,7 +5,7 @@ EAPI=5 inherit eutils -MY_P="${P/_/-}" +MY_P="${P/_/-}-gtk3" S="${WORKDIR}/${MY_P}" DESCRIPTION="Audacious Player - Your music, your way, no exceptions" HOMEPAGE="http://audacious-media-player.org/" @@ -21,7 +21,7 @@ >=dev-libs/dbus-glib-0.60 dev-libs/libxml2:2 media-libs/libmodplug - ~media-sound/audacious-3.5.1 + ~media-sound/audacious-3.6 >=net-libs/neon-0.26.4 x11-libs/gtk+:3 ( || ( >=dev-libs/glib-2.32.2[utils] dev-util/gdbus-codegen ) ) @@ -57,8 +57,6 @@ nls? ( dev-util/intltool ) virtual/pkgconfig" -DOCS="AUTHORS" - mp3_warning() { if ! use mp3 ; then ewarn "MP3 support is optional, you may want to enable the mp3 USE-flag"
Status icon plugin now disabled by default because audacious can now be built without gui. While we always build gui i think this plugin must be enabled: --- ../../../../../portage/media-plugins/audacious-plugins/audacious-plugins-3.5.1.ebuild 2014-08-01 01:44:25.000000000 +0400 +++ ./audacious-plugins-3.6.ebuild 2015-03-04 21:05:02.401291465 +0300 @@ -5,7 +5,7 @@ EAPI=5 inherit eutils -MY_P="${P/_/-}" +MY_P="${P/_/-}-gtk3" S="${WORKDIR}/${MY_P}" DESCRIPTION="Audacious Player - Your music, your way, no exceptions" HOMEPAGE="http://audacious-media-player.org/" @@ -21,7 +21,7 @@ >=dev-libs/dbus-glib-0.60 dev-libs/libxml2:2 media-libs/libmodplug - ~media-sound/audacious-3.5.1 + ~media-sound/audacious-3.6 >=net-libs/neon-0.26.4 x11-libs/gtk+:3 ( || ( >=dev-libs/glib-2.32.2[utils] dev-util/gdbus-codegen ) ) @@ -57,8 +57,6 @@ nls? ( dev-util/intltool ) virtual/pkgconfig" -DOCS="AUTHORS" - mp3_warning() { if ! use mp3 ; then ewarn "MP3 support is optional, you may want to enable the mp3 USE-flag" @@ -92,6 +90,7 @@ --enable-modplug \ --disable-soxr \ --enable-neon \ + --enable-statusicon \ $(use_enable adplug) \ $(use_enable aac) \ $(use_enable alsa) \
I think, it would be good idea to let user choose with USE flags which interface he wants to build - gtk2, gtk3 or qt5.
(In reply to nE0sIghT from comment #8) > As Gnome 3 user i against downgrading audacious to GTK+-2. > GTK+-3 version works good for me: Then copy it to an "audacious-gnome" ebuild in your local overlay and keep the maintenance burden where it belongs.
(In reply to Anthony Parsons from comment #11) > Then copy it to an "audacious-gnome" ebuild in your local overlay and keep > the maintenance burden where it belongs. Please read Gentoo's Code of conduct (https://wiki.gentoo.org/wiki/Project:Council/Code_of_conduct) and don't say to me what i should do. Thanks. GTK+-3 enabled ebuilds already available in my vortex overlay. It's maintainer's privilege - decide how to support this package. Not mine or yours.
(In reply to nE0sIghT from comment #12) > > Please read Gentoo's Code of conduct > (https://wiki.gentoo.org/wiki/Project:Council/Code_of_conduct) and don't say > to me what i should do. Thanks. > > GTK+-3 enabled ebuilds already available in my vortex overlay. > > It's maintainer's privilege - decide how to support this package. Not mine > or yours. And it's Gentoo policy to not screw users by deviating needlessly from upstream. That's why we don't install libav when a user asks for ffmpeg, and why I suggested naming the package to follow the existing precedent set by xchat-gnome. But okay, you win. If you're immediately going to take offence to straightforward technical criticism, you can take comfort that you'll never receive any again.
(In reply to Anthony Parsons from comment #13) > And it's Gentoo policy to not screw users by deviating needlessly from > upstream. And in that case upstream provides 2 tarballs - GTK+-2 and GTK+-3, both - supported. From http://audacious-media-player.org/news/32-audacious-3-6-released: "Audacious can still be built with GTK3 if desired, but we recommend the GTK2 variant (!)for any desktop environment other than GNOME 3(!)." I'm a gnome 3 user and i posted my opinion and patch. Nothing more. (In reply to Anthony Parsons from comment #13) > If you're immediately going to take offence to > straightforward technical criticism, you can take comfort that you'll never > receive any again. I do not see any _technical_ criticism from you. Just "if you do not like GTK+2 - go away". That is not productive - you just quote my _opinion_ and started to flame.
(Eternal Sorrow says) > I think, it would be good idea to let user choose with USE flags which interface he wants to build - gtk2, gtk3 or qt5. This is a good solution for me. Users have the right to determine to use whether GTK+:2 or GTK+:3. Since GTK+:2 and GTK+:3 are slotted, some users are using both. I think that argues like "Which is better" have no sense here. Ebuild system may select SRC_URI by USE conditional writing. So it can be technically solved. Anyway, users should not be confused. In fact, users (we) can't install >=audacious-3.6 from gentoo repository (Portage tree) now. thx
(In reply to Mika Kobayashi from comment #15) Even Mika Kobayashi herself says that I'm right :)
This is a matter to be decided by the maintainer (not me). But anyway, it should be decided. I think Audacious's ebuilds should be updated, because ver 3.6 and later are included many bug fixes and Qt5 support as well as other new features. for reference, I have written ebuild files (in my repository (overlay) for my personal use. https://bitbucket.org/wjn/wjn-overlay/src/ ). But I'm using development version. So these 3.6 and 3.6.1 ebuilds aren't fully tested. These are only examples for showing USE conditional writing. thanks
Does audacious have a package maintainer? This request is nearing a half year in age.
Yes. But my time is limited. And passive aggressive remarks do not help matters.
Who's the one being passive aggressive? You were being uncooperative regarding GTK3 deprecation and then chose to ignore the package for half a year. I hardly think it's unreasonable to give this a poke and question whether a new maintainer needs to be assigned (two more stable releases and a beta release later). Regarding the GTK2/3 situation, should there be an audacious-gnome package or should this be handled through USE deps? I'll make up new ebuilds but I want to do it the correct way in this instance.
(In reply to Tony Vroon from comment #19) > Yes. But my time is limited. And passive aggressive remarks do not help > matters. How can we help to get this in tree? To prepare a proper ebuild we must know how to construct it. So which policy must used for this package - gtk3, gtk2, qt or mixed use-flag? Or maybe separate ebuilds?
Created attachment 407564 [details, diff] patch to fix audacious dependency issues (for wjn-overlay) Mika's ebuilds work pretty well. This can be applied to her overlay to fix the dependency issue I hit. As an aside, I realized I hit the qt building issues because I was missing qtmultimedia. I don't have that problem anymore.
(In reply to nE0sIghT from comment #21) > How can we help to get this in tree? First we break the GTK+ 2 vs 3 stalemate by supporting both in a single ebuild. Then we have a discussion about whether QT is ready enough to support a non-GTK build. I am leaning towards no (force GTK2 or GTK3 based on USE-flags, and build QT in addition if requested). Example ebuild to follow.
Created attachment 407842 [details] audacious-3.6.2.ebuild
+*audacious-3.6.2 (04 Aug 2015) + + 04 Aug 2015; Tony Vroon <chainsaw@gentoo.org> +audacious-3.6.2.ebuild: + Version bump, as requested by Joe Kappus in bug #538414. Depend on a basic + icon theme as suggested by turtle in bug #539160.
+*audacious-plugins-3.6.2 (04 Aug 2015) + + 04 Aug 2015; Tony Vroon <chainsaw@gentoo.org> + +audacious-plugins-3.6.2.ebuild: + Version bump, as requested by Joe Kappus in bug #538414. Implement + REQUIRED_USE restrictions as pointed out by Diego Elio Pettenò in bug + #526182. Drop compatibility USE-flag midi triggering fluidsynth due to errors + as flagged up by Teodor Petrov in bug #518938. Make neon dependency optional + as requested by Harvey Mittens in bug #525056.
