Bug 538186 – media-video/mplayer-1.2pre20141011 with >=dev-libs/libcdio-0.90 - configure fails to find libcdio headers(?)

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description ilddnpfsw 2015-01-29 18:41:04 UTC]

Created attachment 395162 [details, diff]
patch

With the current ebuild the cdio flag doesn't make any difference
because the source doesn't support the new header locations and src_configure doesnt enable cdio,
also the ebuild doesn't pull in libcdio-cdparanoia (containing the mentioned headers: cdda.h and paranoia.h)

In the attachment there is a patch tested to work with the
mplayer-1.2_pre20130729.ebuild
mplayer-1.2_pre20141011.ebuild
and the current svn version

and against libcdio-0.92 and libcdio-0.83

[Comment 1 ilddnpfsw 2015-01-29 18:55:45 UTC]

Created attachment 395164 [details]
fixed mplayer-1.2_pre20141011.ebuild

[Comment 2 Jeroen Roovers (RETIRED) 2015-01-30 09:49:51 UTC]

Comment on attachment 395164 [details]
fixed mplayer-1.2_pre20141011.ebuild

Please run dos2unix on your ebuild attachments.

--- a/mplayer-1.2_pre20141011.ebuild
+++ b/mplayer-1.2_pre20141011.ebuild
@@ -67,7 +67,7 @@
        bidi? ( dev-libs/fribidi )
        bluray? ( >=media-libs/libbluray-0.2.1 )
        bs2b? ( media-libs/libbs2b )
-       cdio? ( dev-libs/libcdio )
+       cdio? ( dev-libs/libcdio dev-libs/libcdio-paranoia )
        cdparanoia? ( !cdio? ( media-sound/cdparanoia ) )
        dga? ( x11-libs/libXxf86dga )
        directfb? ( dev-libs/DirectFB )
@@ -262,6 +262,10 @@
        sed -i -e '/default_dvd_device/s:/dev/dvd:/dev/cdrom:' configure || die
 }
 
+PATCHES=(
+        "${FILESDIR}/cdio-paranoia.patch"
+)
+
 src_configure() {
        local myconf=""
        local uses i

[Comment 3 ilddnpfsw 2015-01-30 17:02:35 UTC]

Sorry if the lines got messed up on the way, but the "browse" button doesn't work for me so I had to copy the contents from the console and paste them into the textarea "as attachment":-s

(In reply to Jeroen Roovers from comment #2)
> Comment on attachment 395164 [details]
> fixed mplayer-1.2_pre20141011.ebuild
> 
> Please run dos2unix on your ebuild attachments.
>

[Comment 4 Alexis Ballier 2015-02-12 08:59:41 UTC]

thanks for your patch, it looks good, but could you please submit it upstream ?
(i prefer to apply patches that have been reviewed upstream, since this usually ensures better quality)

it's just about subscribing and sending the patch with explanations to mplayer-dev-eng: http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng

[Comment 5 ilddnpfsw 2015-02-15 07:46:40 UTC]

(In reply to Alexis Ballier from comment #4)
> thanks for your patch, it looks good, but could you please submit it
> upstream ?
> (i prefer to apply patches that have been reviewed upstream, since this
> usually ensures better quality)
> 
> it's just about subscribing and sending the patch with explanations to
> mplayer-dev-eng: http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng

https://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2015-February/072851.html

Sent it,
/cheers

[Comment 6 Alexis Ballier 2015-07-30 14:54:28 UTC]

this should be fixed in mplayer-1.2_pre20150730 thanks!