Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 537476 - media-gfx/pstoedit-3.62 should purge extraneous libtool files or install libpstoedit.la
Summary: media-gfx/pstoedit-3.62 should purge extraneous libtool files or install libp...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: TeX project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-23 19:08 UTC by cmuelle8
Modified: 2015-04-29 15:22 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to `media-gfx/pstoedit/pstoedit-3.62.ebuild`: calling `prune_libtool_files` with parameter `--modules` (file_537476.txt,347 bytes, patch)
2015-01-28 16:33 UTC, Christian Burger
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description cmuelle8 2015-01-23 19:08:17 UTC
SYMPTOM
* media-gfx/pstoedit-3.62::installed
    /usr/lib64/pstoedit/libp2edrvlplot.la (requires /usr/lib64/libpstoedit.la)
    /usr/lib64/pstoedit/libp2edrvmagick++.la (requires /usr/lib64/libpstoedit.la)
    /usr/lib64/pstoedit/libp2edrvpptx.la (requires /usr/lib64/libpstoedit.la)
    /usr/lib64/pstoedit/libp2edrvstd.la (requires /usr/lib64/libpstoedit.la)
    /usr/lib64/pstoedit/libp2edrvwmf.la (requires /usr/lib64/libpstoedit.la)

FLAGS IN USE
    media-gfx/pstoedit-3.62:0::installed
    Installed using           paludis-2.2.0
    Use flags                 (emf) (-flash) (imagemagick) (plotutils) (pptx) (-static-libs) build_options: -trace 


I wonder if there is a tracker bug for this type of bug?  There are quite some packages repeatedly being rebuilt when revdep-rebuild / cave fix-linkage are called.  This happens for all ebuilds leaving broken extraneous libtool files in their install images.

Reproducible: Always
Comment 1 Christian Burger 2015-01-28 16:31:17 UTC
I can confirm having this problem, when executing `cave fix-linkage`. In my case the ebuild in question has originally two .la files and uses `prune_libtool_files()` from `eutils.eclass` trying to get rid of unneeded .la files:

 * checking /var/tmp/paludis/media-gfx-pstoedit-3.62/image/usr/lib64/pstoedit/libp2edrvstd.la for removal
 * checking /var/tmp/paludis/media-gfx-pstoedit-3.62/image/usr/lib64/libpstoedit.la for removal
 * Removing unnecessary /usr/lib64/libpstoedit.la (no static archive)

The "broken" .la file depends on the .la file being removed. And the reason it is not removed is stated in this comment in `eutils.eclass`, line 1594:

> The .la file may be used by a module loader, so avoid removing it
> unless explicitly requested.

So how I understand it, the file is actually not meant to be a library to be shared, but a module to be loaded at runtime. Since it is broken, when removing libpstoedit.la, I see two choices (as previously stated by the bug reporter):

1) keep libpstoedit.la, too, or
2) remove the broken libs

The solution to 2) is probably to call
`prune_libtool_files --modules`
the `--modules` parameter removes the other files, too. 

But, I don't know the inner workings of `media-gfx/pstoedit`, if it turns out that 1) is correct and the file has to be kept, maybe the heuristic applied in `prune_libtool_files()` is incomplete in that regard? On the other hand, it could be wrong to call `prune_libtool_files()` in the first place.

I will attach a patch for solution 2), in case it is correct.
Comment 2 Christian Burger 2015-01-28 16:33:48 UTC
Created attachment 395064 [details, diff]
patch to `media-gfx/pstoedit/pstoedit-3.62.ebuild`: calling `prune_libtool_files` with parameter `--modules`
Comment 3 Alexis Ballier gentoo-dev 2015-04-29 15:22:46 UTC
 
+*pstoedit-3.70 (29 Apr 2015)
+
+  29 Apr 2015; Alexis Ballier <aballier@gentoo.org> +pstoedit-3.70.ebuild:
+  version bump, bug #541384; properly remove all .la files, bug #537476
+