Bug 53693 – gimageview fails to compile with gcc 3.4

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Bret Towe 2004-06-11 22:51:09 UTC]

when trying to compile it goes thru a fair amount and fails on

gimv_thumb_win.c:1218:2: warning: #warning should be implemented as customizable launcher.
gimv_thumb_win.c:2439: error: conflicting types for 'cb_move_tab'
gimv_thumb_win.c:206: error: previous declaration of 'cb_move_tab' was here
gimv_thumb_win.c:2439: error: conflicting types for 'cb_move_tab'
gimv_thumb_win.c:206: error: previous declaration of 'cb_move_tab' was here
gimv_thumb_win.c:206: warning: 'cb_move_tab' used but never defined
gimv_thumb_win.c:2439: warning: 'cb_move_tab' defined but not used
make[3]: *** [gimv_thumb_win.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: Leaving directory `/var/tmp/portage/gimageview-0.2.25/work/gimageview-0.2.25/src'

patch will be attached simple fix for it
a conditional check for gcc 3.4 i dont think will be needed
looks like a simple bug thats been there (gcc 3.3 ignores it seems)
but gcc 3.4 not stops on it the error

[Comment 1 Bret Towe 2004-06-11 22:51:48 UTC]

Created attachment 33117 [details, diff]
gimv-gcc34.patch

patch to allow compile with gcc 3.4

[Comment 2 Disenchanted (RETIRED) 2004-06-29 06:08:23 UTC]

Patch added, give it some time, then sync and emerge gimageview.

Thanks for the patch.