Bug 533830 – app-admin/logrotate-3.8.8 with sys-devel/clang-3.5.0 - logrotate.c:1105:9: error: the value of the size argument in 'strncat' is too large, might lead to a buffer overflow [-Werror,-Wstrncat-size]

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description kjyn 2014-12-28 16:51:01 UTC]

Logrotate-3.8.8 cannot compile with clang but the previous version succeeded.  Clang reports a possible buffer overflow with strncat.

Reproducible: Always

Steps to Reproduce:
1. Set clang as compiler
2. emerge -1 logrotate
Actual Results:  
Compile failure
logrotate.c:1105:9: error: the value of the size argument in 'strncat' is too large, might lead to a buffer overflow [-Werror,-Wstrncat-size]


Expected Results:  
Compile success

emerge --info
Portage 2.2.14 (python 3.3.5-final-0, default/linux/amd64/13.0/desktop/kde, gcc-4.8.3, glibc-2.19-r1, 3.18.0-gentoo x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-3.18.0-gentoo-x86_64-Intel-R-_Core-TM-_i5-3570K_CPU_@_3.40GHz-with-gentoo-2.2
KiB Mem:    16297920 total,  12260368 free
KiB Swap:    4194300 total,   4194300 free
Timestamp of tree: Sun, 28 Dec 2014 05:00:01 +0000
ld GNU gold (Gentoo 2.24 p1.4 2.24) 1.11
ccache version 3.1.9 [disabled]
app-shells/bash:          4.2_p53
dev-java/java-config:     2.2.0
dev-lang/perl:            5.18.2-r2
dev-lang/python:          2.7.9, 3.3.5-r1, 3.4.1
dev-util/ccache:          3.1.9-r4
dev-util/cmake:           2.8.12.2-r1
dev-util/pkgconfig:       0.28-r1
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.12.4
sys-apps/sandbox:         2.6-r1
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.11.6-r1, 1.13.4
sys-devel/binutils:       2.24-r3
sys-devel/gcc:            4.8.3
sys-devel/gcc-config:     1.7.3
sys-devel/libtool:        2.4.2-r1
sys-devel/make:           4.0-r1
sys-kernel/linux-headers: 3.16 (virtual/os-headers)
sys-libs/glibc:           2.19-r1
Repositories: gentoo x-portage
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=native -ftree-vectorize -flto=5 -floop-interchange -floop-strip-mine -floop-block"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt /usr/share/themes/oxygen-gtk/gtk-2.0"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.5/ext-active/ /etc/php/cgi-php5.5/ext-active/ /etc/php/cli-php5.5/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="rsync://gentoo.cs.uni.edu/gentoo-distfile srsync://mirrors.rit.edu/gentoo/ rsync://mirror.mcs.anl.gov/gentoo/ rsync://mirrors.tera-byte.com/gentoo rsync://gentoo.gossamerhost.com/gentoo-distfiles/"
LDFLAGS="-O2 -pipe -march=native -ftree-vectorize -flto=5 -floop-interchange -floop-strip-mine -floop-block -fuse-linker-plugin"
MAKEOPTS="-j5"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
USE="X a52 aac acl acpi alsa amd64 bash-completion berkdb bindist bluetooth branding bzip2 cairo cdda cddb cdr cli consolekit corefonts cracklib crypt cups cxx dbus declarative dri dts dvd dvdr emboss encode exif fam ffmpeg fftw firefox flac fontconfig fortran gdbm gif gimp git glamor gnuplot gphoto2 gpm graphite graphviz gtk hddtemp iconv imagemagick imlib ios ipod ipv6 java jit jpeg kde kipi lcms ldap libnotify lm_sensors lto lzma lzo mad minizip mmx mng modules mp3 mp4 mpeg mpi multilib ncurses nls nptl ogg opengl openmp pam pango pcre pdf perl phonon plasma png policykit posix ppds python qt3support qt4 readline samba sdl session spell sqlite sqlite3 sse sse2 sse3 sse4_1 sse4_2 ssl ssse3 startup-notification subversion svg svn tcpd threads tiff tools truetype udev udisks unicode upnp upnp-av upower usb vim-syntax vorbis win32codecs winbind wxwidgets x264 xcb xcomposite xine xinerama xml xpm xscreensaver xv xvid zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_3" RUBY_TARGETS="ruby19 ruby20" USERLAND="GNU" VIDEO_CARDS="radeon intel" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
USE_PYTHON="2.7 3.3"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, SYNC

=================================================================
                        Package Settings
=================================================================

app-admin/logrotate-3.8.7 was built with the following:
USE="acl (-selinux)" ABI_X86="64"
CFLAGS="-O3 -flto -fslp-vectorize-aggressive -march=native -pipe"
CXXFLAGS="-O3 -flto -fslp-vectorize-aggressive -march=native -pipe"
LDFLAGS="-O3 -flto -fslp-vectorize-aggressive -march=native -pipe"

[Comment 1 kjyn 2014-12-28 16:52:13 UTC]

Created attachment 392580 [details]
build environment

[Comment 2 kjyn 2014-12-28 16:53:21 UTC]

Created attachment 392582 [details]
build log

[Comment 3 Jeroen Roovers (RETIRED) 2014-12-29 07:19:04 UTC]

Off-by-one in

   strncat(..., sizeof(dext_pattern) - strlen(dext_pattern))

by the looks. But it shouldn't set -Werror either.

[Comment 4 Jeroen Roovers (RETIRED) 2014-12-29 17:27:55 UTC]

Fixed without revision bump.