Created attachment 391104 [details] tcllib-1.16.ebuild I attach ebuild for tcllib-1.16. I need this version of tcllib for SCRAM-SHA-1 authentification in Tkabber jabber client, and it works. Detailed changes from tcllib-1.15-r1.ebuild: 1. Remove 'manpage-rename' and 'test' patches applying (was applied from distfiles through $WORKDIR), because related bugs [1], [2] fixed in 1.16. 2. Remove 'tcl8.6-test' patch applying (was applied from $FILESDIR), which looks like [3], [4], [5] composition (I don’t strongly check this, though), because these commits come to 1.16 release. 3. Tune 'SRC_URI' and add 'src_unpack', because release packages for 1.16 tcllib version distributed as Tcllib-${PV} (with capital letter 'T') archives with same named directory inside. I check [1],[2]-related commits and [3],[4],[5] commits for coming in 1.16 release via [6] link, they come in. [1] http://core.tcl.tk/tcllib/tktview?name=3606621fff [2] http://core.tcl.tk/tcllib/tktview?name=3606619fff [3] http://core.tcl.tk/tcllib/info/d0eec3f8aa123b6b2c9461497d6cbc1a5d10a078 [4] http://core.tcl.tk/tcllib/vinfo/4084633c64d2e731c19cc0fcc7f613c0e6afd19c [5] http://core.tcl.tk/tcllib/info/367195678d118962a1b4e8b4bf50f244402f71b9 [6] http://core.tcl.tk/tcllib/timeline?n=250&unhide&p=2847321e3094afedb6f31269a46d8a20ba93dbf9
By the way, 'tcllib-1.14-test.patch' isn’t use anywhere as I see. I propose delete it in order to sanitize files/ directory.
Comment on attachment 391104 [details] tcllib-1.16.ebuild --- tcllib-1.15-r1.ebuild +++ tcllib-1.15-r1.ebuild @@ -8,10 +8,7 @@ DESCRIPTION="Tcl Standard Library" HOMEPAGE="http://www.tcl.tk/software/tcllib/" -SRC_URI=" - http://dev.gentoo.org/~jlec/distfiles/${P}-manpage-rename.patch.xz - http://dev.gentoo.org/~jlec/distfiles/${P}-test.patch.xz - mirror://sourceforge/tcllib/${P}.tar.bz2" +SRC_URI="mirror://sourceforge/tcllib/Tcllib-${PV}.tar.bz2 -> ${P}.tar.bz2" LICENSE="BSD" SLOT="0" @@ -23,11 +20,9 @@ DOCS=( DESCRIPTION.txt STATUS ) -src_prepare() { - epatch \ - "${FILESDIR}"/${P}-tcl8.6-test.patch \ - "${WORKDIR}"/${P}-test.patch \ - "${WORKDIR}"/${P}-manpage-rename.patch +src_unpack() { + unpack ${A} + mv Tcllib-${PV} ${P} } src_test() {
Excuse me for offtopic: What reason for marking ebuild obsolete and add patch as comment? Must I add new ebuild as patch wrapped into comment rather then as attachment? What reason for clearing URL? Is there guidelines about that things?
(In reply to Alexander Turenko from comment #3) > Excuse me for offtopic: What reason for marking ebuild obsolete and add > patch as comment? Must I add new ebuild as patch wrapped into comment rather > then as attachment? What reason for clearing URL? Is there guidelines about > that things? It is easier for the maintainer to see the diff. I need to diff it anyways to see what you did. Are the two patches obsolete now?
(In reply to Justin Lecher from comment #4) > ... > Are the two patches obsolete now? Patches in files/ directory? 'tcllib-1.14-test.patch' completely obsoleted as 1.14 version no more in portage, 'tcllib-1.15-tcl8.6-test.patch' still need for tcllib-1.15 when it installed with tcl-8.6. Patches from distfiles still need for 1.15, but not needed for 1.16.
+*tcllib-1.15-r2 (03 Mar 2015) + + 03 Mar 2015; Justin Lecher <jlec@gentoo.org> + +files/tcllib-1.15-XSS-vuln.patch, +files/tcllib-1.15-test.patch, + +files/tcllib-1.16-XSS-vuln.patch, +files/tcllib-1.16-test.patch, + +tcllib-1.15-r2.ebuild, +tcllib-1.16.ebuild: + Version Bump, #531864; fix testfailure, #478216; backport security fix, + #541912 +
