Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 531336 - [gnome overlay] net-misc/vinagre-3.14.2 USE=rdp - plugins/rdp/vinagre-rdp-tab.c:30:33: fatal error: freerdp/utils/event.h: No such file or directory
Summary: [gnome overlay] net-misc/vinagre-3.14.2 USE=rdp - plugins/rdp/vinagre-rdp-tab...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: gnome-3.14
  Show dependency tree
 
Reported: 2014-12-01 13:33 UTC by Kobboi
Modified: 2015-01-05 14:01 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,142.28 KB, text/plain)
2014-12-01 13:33 UTC, Kobboi
Details
build.log (build.log,151.53 KB, text/x-log)
2015-01-01 11:44 UTC, Dennis Schridde
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kobboi 2014-12-01 13:33:05 UTC
vinagre-3.12.2 is still building fine with USE=rdp.



x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H   -I. -I./vinagre -I. -I./vinagre -I./vinagre/view -DBINDIR=\"/usr/bin\" -DDATADIR=\"/usr/share\" -DPREFIX=\""/usr"\" -DSYSCONFDIR=\""/etc"\" -DLIBDIR=\""/usr/lib64"\" -DVINAGRE_DATADIR=\""/usr/share/vinagre"\" -DPACKAGE_LOCALE_DIR=\""/usr/share/locale"\" -DSSH_PROGRAM=\"/usr/bin/ssh\" -pthread -I/usr/include/libsecret-1 -I/usr/include/telepathy-1.0 -I/usr/include/dbus-1.0 -I/usr/include/vte-2.91 -I/usr/include/gtk-3.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/gtk-3.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libdrm -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/gio-unix-2.0/ -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libxml2  -pthread -I/usr/include/gtk-vnc-2.0 -I/usr/include/gvnc-1.0 -I/usr/include/gtk-3.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/gtk-3.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libdrm -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libxml2  -Wall   -include config.h    -O2 -march=native -pipe -fomit-frame-pointer -c -o plugins/ssh/vinagre_vinagre-vinagre-ssh-tab.o `test -f 'plugins/ssh/vinagre-ssh-tab.c' || echo './'`plugins/ssh/vinagre-ssh-tab.c
plugins/rdp/vinagre-rdp-tab.c:30:33: fatal error: freerdp/utils/event.h: No such file or directory
 #include <freerdp/utils/event.h>
                                 ^
compilation terminated.
make[2]: *** [plugins/rdp/vinagre_vinagre-vinagre-rdp-tab.o] Error 1
make[2]: *** Waiting for unfinished jobs....


Reproducible: Always
Comment 1 Kobboi 2014-12-01 13:33:29 UTC
Created attachment 390716 [details]
build.log
Comment 2 Alexander Tsoy 2014-12-02 14:07:12 UTC
vinagre fails to build only with freerdp-1.2.0_beta1_pre20141115

freerdp-1.1.0_beta1_p20130710-r1:
$ qlist freerdp | fgrep event.h
/usr/include/freerdp/utils/event.h
/usr/include/freerdp/event.h

freerdp-1.2.0_beta1_pre20141115:
$ qlist freerdp | fgrep event.h
/usr/include/freerdp/event.h
Comment 3 Kamil Kamiński 2014-12-27 08:50:49 UTC
Same here
Comment 4 David Klann 2014-12-27 18:35:00 UTC
Not using gnome overlay (3.14 has hit ~) and hitting the same error. I added a symlink of <freerdp/event.h> to <freerdp/utils/event.h> and that enabled emerge of net-misc/vinagre to get further in the compile. Now I'm seeing this error:

plugins/rdp/vinagre-rdp-tab.c: In function ‘frdp_post_connect’:
plugins/rdp/vinagre-rdp-tab.c:371:23: error: ‘CLRBUF_24BPP’ undeclared (first use in this function)
   gdi_init (instance, CLRBUF_24BPP, NULL);
                       ^
plugins/rdp/vinagre-rdp-tab.c:371:23: note: each undeclared identifier is reported only once for each function it appears in
Makefile:1660: recipe for target 'plugins/rdp/vinagre_vinagre-vinagre-rdp-tab.o' failed

This is not a parallel make issue: I re-ran the emerge with MAKEOPTS=-j1 and it failed in the same way.

freerdp version installed: 1.2.0_beta1_pre20141115
Comment 5 Greg Turner 2014-12-28 10:56:53 UTC
I guess most people aren't getting this due to vlc blocking newest freerdp*.

Patching the #include in plugins/rdp/vinagre-rdp-tab.c in the obvious way seems to do the trick -- a naive patch like this would break it for the majority with gx86 vlc, so that's not a sufficient solution.

Appears to be an upstream problem, we should take it to them.

* I'd already backported an upstream vlc patch for this, and didn't feel like downgrading, by the time the block went into gentoo.
Comment 6 Greg Turner 2014-12-28 19:43:45 UTC
(In reply to David Klann from comment #4)
> Not using gnome overlay (3.14 has hit ~) and hitting the same error. I added
> a symlink of <freerdp/event.h> to <freerdp/utils/event.h> and that enabled
> emerge of net-misc/vinagre to get further in the compile. Now I'm seeing
> this error:
> 
> plugins/rdp/vinagre-rdp-tab.c: In function ‘frdp_post_connect’:
> plugins/rdp/vinagre-rdp-tab.c:371:23: error: ‘CLRBUF_24BPP’ undeclared
> (first use in this function)
>    gdi_init (instance, CLRBUF_24BPP, NULL);
>                        ^
> plugins/rdp/vinagre-rdp-tab.c:371:23: note: each undeclared identifier is
> reported only once for each function it appears in
> Makefile:1660: recipe for target
> 'plugins/rdp/vinagre_vinagre-vinagre-rdp-tab.o' failed
> 
> This is not a parallel make issue: I re-ran the emerge with MAKEOPTS=-j1 and
> it failed in the same way.
> 
> freerdp version installed: 1.2.0_beta1_pre20141115

sorry, correction: patching gets me on to the same page as David, not to a full resolution.
Comment 7 Greg Turner 2014-12-28 19:50:36 UTC
OTOH, applying 

https://github.com/GNOME/vinagre/commit/2fd545b77c3a2c5f0bc1b0fc5f851857127cc2f3.patch

gets me all the way there.
Comment 8 Peter Asplund 2014-12-30 14:38:53 UTC
Patch worked for me as well.
Comment 9 Dennis Schridde 2015-01-01 11:44:07 UTC
Created attachment 392844 [details]
build.log

Similar to comment #4: Also not using gnome-overlay but ~amd64, but running into the same issue, while trying to compile net-misc/vinagre-3.14.3. Using net-misc/freerdp-1.2.0_beta1_pre20141115.
Comment 10 Justin Lecher (RETIRED) gentoo-dev 2015-01-04 13:14:30 UTC
Still see this with the latest ebuild in the tree
Comment 11 Justin Lecher (RETIRED) gentoo-dev 2015-01-04 13:17:44 UTC
+  04 Jan 2015; Justin Lecher <jlec@gentoo.org> vinagre-3.14.3.ebuild,
+  +files/vinagre-3.14.3-freerdp.patch, metadata.xml:
+  Backport patch to work with freerdp-1.2.0_beta, #531336
+
Comment 12 Gilles Dartiguelongue (RETIRED) gentoo-dev 2015-01-04 22:56:43 UTC
I wonder how PATCHES is working since it does not seem to be supported by any inherited eclass.
Comment 13 Justin Lecher (RETIRED) gentoo-dev 2015-01-05 08:10:36 UTC
(In reply to Gilles Dartiguelongue from comment #12)
> I wonder how PATCHES is working since it does not seem to be supported by
> any inherited eclass.

I add in src_prepare()

epatch "${PATCHES[@]}"
Comment 14 Gilles Dartiguelongue (RETIRED) gentoo-dev 2015-01-05 14:01:55 UTC
Oh right, I was too tired to see it.