../../doltlibtool --tag=CC --mode=compile x86_64-pc-linux-gnu-gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../.. -DMODULE_NAME=$(p="liblibbluray_plugin_la-bluray.lo"; p="${p##*/}"; p="${p#lib}"; echo "${p%_plugin*}") -DMODULE_NAME_IS_$(p="liblibbluray_plugin_la-bluray.lo"; p="${p##*/}"; p="${p#lib}"; echo "${p%_plugin*}") -DMODULE_STRING=\"$(p="liblibbluray_plugin_la-bluray.lo"; p="${p##*/}"; p="${p#lib}"; echo "${p%_plugin*}")\" -D__PLUGIN__ -I../../include -I../../include -march=corei7 -O2 -pipe -Wall -Wextra -Wsign-compare -Wundef -Wpointer-arith -Wbad-function-cast -Wwrite-strings -Wmissing-prototypes -Wvolatile-register-var -Werror-implicit-function-declaration -pipe -fvisibility=hidden -c -o liblibbluray_plugin_la-bluray.lo `test -f 'bluray.c' || echo './'`bluray.c ../../doltlibtool --tag=CC --mode=compile x86_64-pc-linux-gnu-gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../.. -DMODULE_NAME=$(p="liblibvnc_plugin_la-vnc.lo"; p="${p##*/}"; p="${p#lib}"; echo "${p%_plugin*}") -DMODULE_NAME_IS_$(p="liblibvnc_plugin_la-vnc.lo"; p="${p##*/}"; p="${p#lib}"; echo "${p%_plugin*}") -DMODULE_STRING=\"$(p="liblibvnc_plugin_la-vnc.lo"; p="${p##*/}"; p="${p#lib}"; echo "${p%_plugin*}")\" -D__PLUGIN__ -I../../include -I../../include -march=corei7 -O2 -pipe -Wall -Wextra -Wsign-compare -Wundef -Wpointer-arith -Wbad-function-cast -Wwrite-strings -Wmissing-prototypes -Wvolatile-register-var -Werror-implicit-function-declaration -pipe -fvisibility=hidden -c -o liblibvnc_plugin_la-vnc.lo `test -f 'vnc.c' || echo './'`vnc.c ../../doltlibtool --tag=CC --mode=compile x86_64-pc-linux-gnu-gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../.. -DMODULE_NAME=$(p="librdp_plugin_la-rdp.lo"; p="${p##*/}"; p="${p#lib}"; echo "${p%_plugin*}") -DMODULE_NAME_IS_$(p="librdp_plugin_la-rdp.lo"; p="${p##*/}"; p="${p#lib}"; echo "${p%_plugin*}") -DMODULE_STRING=\"$(p="librdp_plugin_la-rdp.lo"; p="${p##*/}"; p="${p#lib}"; echo "${p%_plugin*}")\" -D__PLUGIN__ -I../../include -I../../include -march=corei7 -O2 -pipe -Wall -Wextra -Wsign-compare -Wundef -Wpointer-arith -Wbad-function-cast -Wwrite-strings -Wmissing-prototypes -Wvolatile-register-var -Werror-implicit-function-declaration -pipe -fvisibility=hidden -c -o librdp_plugin_la-rdp.lo `test -f 'rdp.c' || echo './'`rdp.c ../../doltlibtool --tag=CC --mode=compile x86_64-pc-linux-gnu-gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../.. -DMODULE_NAME=$(p="libvcd_plugin_la-vcd.lo"; p="${p##*/}"; p="${p#lib}"; echo "${p%_plugin*}") -DMODULE_NAME_IS_$(p="libvcd_plugin_la-vcd.lo"; p="${p##*/}"; p="${p#lib}"; echo "${p%_plugin*}") -DMODULE_STRING=\"$(p="libvcd_plugin_la-vcd.lo"; p="${p##*/}"; p="${p#lib}"; echo "${p%_plugin*}")\" -D__PLUGIN__ -I../../include -I../../include -march=corei7 -O2 -pipe -Wall -Wextra -Wsign-compare -Wundef -Wpointer-arith -Wbad-function-cast -Wwrite-strings -Wmissing-prototypes -Wvolatile-register-var -Werror-implicit-function-declaration -pipe -fvisibility=hidden -c -o libvcd_plugin_la-vcd.lo `test -f 'vcd/vcd.c' || echo './'`vcd/vcd.c ../../doltlibtool --tag=CC --mode=compile x86_64-pc-linux-gnu-gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../.. -DMODULE_NAME=$(p="libvcd_plugin_la-cdrom.lo"; p="${p##*/}"; p="${p#lib}"; echo "${p%_plugin*}") -DMODULE_NAME_IS_$(p="libvcd_plugin_la-cdrom.lo"; p="${p##*/}"; p="${p#lib}"; echo "${p%_plugin*}") -DMODULE_STRING=\"$(p="libvcd_plugin_la-cdrom.lo"; p="${p##*/}"; p="${p#lib}"; echo "${p%_plugin*}")\" -D__PLUGIN__ -I../../include -I../../include -march=corei7 -O2 -pipe -Wall -Wextra -Wsign-compare -Wundef -Wpointer-arith -Wbad-function-cast -Wwrite-strings -Wmissing-prototypes -Wvolatile-register-var -Werror-implicit-function-declaration -pipe -fvisibility=hidden -c -o libvcd_plugin_la-cdrom.lo `test -f 'vcd/cdrom.c' || echo './'`vcd/cdrom.c ../../doltlibtool --tag=CC --mode=compile x86_64-pc-linux-gnu-gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../.. -DMODULE_NAME=$(p="libvcdx_plugin_la-access.lo"; p="${p##*/}"; p="${p#lib}"; echo "${p%_plugin*}") -DMODULE_NAME_IS_$(p="libvcdx_plugin_la-access.lo"; p="${p##*/}"; p="${p#lib}"; echo "${p%_plugin*}") -DMODULE_STRING=\"$(p="libvcdx_plugin_la-access.lo"; p="${p##*/}"; p="${p#lib}"; echo "${p%_plugin*}")\" -D__PLUGIN__ -I../../include -I../../include -march=corei7 -O2 -pipe -Wall -Wextra -Wsign-compare -Wundef -Wpointer-arith -Wbad-function-cast -Wwrite-strings -Wmissing-prototypes -Wvolatile-register-var -Werror-implicit-function-declaration -pipe -fvisibility=hidden -c -o libvcdx_plugin_la-access.lo `test -f 'vcdx/access.c' || echo './'`vcdx/access.c In file included from ../../include/vlc_common.h:416:0, from dc1394.c:35: In function ‘Demux.part.0’, inlined from ‘Demux’: ../../include/vlc_threads.h:313:25: warning: call to ‘harmful_delay.constprop.2’ declared with attribute warning: use proper event handling instead of short delay [enabled by default] #define msleep(d) msleep(check_delay(d)) ^ dc1394.c:481:9: note: in expansion of macro ‘msleep’ msleep( 10000 ); ^ ../../doltlibtool --tag=CC --mode=compile x86_64-pc-linux-gnu-gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../.. -DMODULE_NAME=$(p="libvcdx_plugin_la-vcd.lo"; p="${p##*/}"; p="${p#lib}"; echo "${p%_plugin*}") -DMODULE_NAME_IS_$(p="libvcdx_plugin_la-vcd.lo"; p="${p##*/}"; p="${p#lib}"; echo "${p%_plugin*}") -DMODULE_STRING=\"$(p="libvcdx_plugin_la-vcd.lo"; p="${p##*/}"; p="${p#lib}"; echo "${p%_plugin*}")\" -D__PLUGIN__ -I../../include -I../../include -march=corei7 -O2 -pipe -Wall -Wextra -Wsign-compare -Wundef -Wpointer-arith -Wbad-function-cast -Wwrite-strings -Wmissing-prototypes -Wvolatile-register-var -Werror-implicit-function-declaration -pipe -fvisibility=hidden -c -o libvcdx_plugin_la-vcd.lo `test -f 'vcdx/vcd.c' || echo './'`vcdx/vcd.c rdp.c: In function ‘postConnectHandler’: rdp.c:228:42: error: ‘CLRBUF_24BPP’ undeclared (first use in this function) gdi_init( p_instance, CLRBUF_16BPP | CLRBUF_24BPP | CLRBUF_32BPP, NULL ); ^ rdp.c:228:42: note: each undeclared identifier is reported only once for each function it appears in rdp.c: In function ‘Open’: rdp.c:402:5: error: implicit declaration of function ‘freerdp_channels_global_init’ [-Werror=implicit-function-declaration] freerdp_channels_global_init(); ^ rdp.c:413:35: warning: assignment from incompatible pointer type [enabled by default] p_sys->p_instance->PreConnect = preConnectHandler; ^ rdp.c:414:36: warning: assignment from incompatible pointer type [enabled by default] p_sys->p_instance->PostConnect = postConnectHandler; ^ rdp.c:415:37: warning: assignment from incompatible pointer type [enabled by default] p_sys->p_instance->Authenticate = authenticateHandler; ^ rdp.c: In function ‘Close’: rdp.c:478:5: error: implicit declaration of function ‘freerdp_channels_global_uninit’ [-Werror=implicit-function-declaration] freerdp_channels_global_uninit(); ^ cc1: some warnings being treated as errors Makefile:3236: recipe for target 'librdp_plugin_la-rdp.lo' failed make[5]: *** [librdp_plugin_la-rdp.lo] Error 1 make[5]: *** Waiting for unfinished jobs.... vcdx/access.c: In function ‘VCDSeek’: vcdx/access.c:296:23: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if( i_pos < t->seekpoint[i_seekpoint + 1]->i_byte_offset ) break; ^ vcdx/access.c: In function ‘VCDLIDs’: vcdx/access.c:480:27: warning: variable ‘i_title’ set but not used [-Wunused-but-set-variable] unsigned int i_lid, i_title; ^ vcdx/access.c: In function ‘VCDControl’: vcdx/access.c:1139:19: warning: variable ‘lsn’ set but not used [-Wunused-but-set-variable] lsn_t lsn; ^ In file included from ../../include/vlc_common.h:416:0, from dvdnav.c:49: dvdnav.c: In function ‘Demux’: ../../include/vlc_threads.h:313:25: warning: call to ‘harmful_delay.constprop.12’ declared with attribute warning: use proper event handling instead of short delay [enabled by default] #define msleep(d) msleep(check_delay(d)) ^ dvdnav.c:715:9: note: in expansion of macro ‘msleep’ msleep( 40000 ); ^ In file included from ../../include/vlc_common.h:416:0, from vcdx/access.c:36: vcdx/access.c: In function ‘VCDReadBlock’: ../../include/vlc_threads.h:295:12: warning: call to ‘harmful_delay’ declared with attribute warning: use proper event handling instead of short delay [enabled by default] : d)) ^ ../../include/vlc_threads.h:313:26: note: in expansion of macro ‘check_delay’ #define msleep(d) msleep(check_delay(d)) ^ vcdx/access.c:196:13: note: in expansion of macro ‘msleep’ msleep( INT64_C(1000) * *p_buf ); ^ make[5]: Leaving directory '/var/tmp/portage/media-video/vlc-2.1.5/work/vlc-2.1.5/modules/access' Makefile:3531: recipe for target 'all-recursive' failed make[4]: *** [all-recursive] Error 1 make[4]: Leaving directory '/var/tmp/portage/media-video/vlc-2.1.5/work/vlc-2.1.5/modules/access' Makefile:2465: recipe for target 'all' failed make[3]: *** [all] Error 2 make[3]: Leaving directory '/var/tmp/portage/media-video/vlc-2.1.5/work/vlc-2.1.5/modules/access' Makefile:1084: recipe for target 'all-recursive' failed make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory '/var/tmp/portage/media-video/vlc-2.1.5/work/vlc-2.1.5/modules' Makefile:1952: recipe for target 'all-recursive' failed make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory '/var/tmp/portage/media-video/vlc-2.1.5/work/vlc-2.1.5' Reproducible: Always Portage 2.2.14 (python 3.4.2-final-0, default/linux/amd64/13.0/desktop, gcc-4.8.3, glibc-2.20, 3.17.3-gentoo x86_64) ================================================================= System uname: Linux-3.17.3-gentoo-x86_64-Intel-R-_Core-TM-_i7-3740QM_CPU_@_2.70GHz-with-gentoo-2.2 KiB Mem: 24626992 total, 22111912 free KiB Swap: 25461756 total, 25461756 free Timestamp of tree: Tue, 18 Nov 2014 01:00:02 +0000 ld GNU ld (Gentoo 2.24 p1.4) 2.24 app-shells/bash: 4.3_p30-r1 dev-java/java-config: 2.2.0 dev-lang/perl: 5.20.1-r2 dev-lang/python: 2.7.8, 3.3.5-r1, 3.4.2 dev-util/cmake: 3.0.2 dev-util/pkgconfig: 0.28-r2 sys-apps/baselayout: 2.2 sys-apps/openrc: 0.13.4 sys-apps/sandbox: 2.6-r1 sys-devel/autoconf: 2.13, 2.69 sys-devel/automake: 1.11.6-r1, 1.14.1 sys-devel/binutils: 2.24-r3 sys-devel/gcc: 4.8.3 sys-devel/gcc-config: 1.8 sys-devel/libtool: 2.4.3-r2 sys-devel/make: 4.1-r1 sys-kernel/linux-headers: 3.17-r1 (virtual/os-headers) sys-libs/glibc: 2.20 Repositories: gentoo bitcoin steam-overlay bumblebee printer-drivers lokal ACCEPT_KEYWORDS="amd64 ~amd64" ACCEPT_LICENSE="*" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-march=corei7 -O2 -pipe" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt /var/lib/hsqldb" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.6/ext-active/ /etc/php/cgi-php5.6/ext-active/ /etc/php/cli-php5.6/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c" CXXFLAGS="-march=corei7 -O2 -pipe" DISTDIR="/mnt/portage/distfiles" FCFLAGS="-O2 -pipe" FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync" FFLAGS="-O2 -pipe" GENTOO_MIRRORS="http://distfiles.gentoo.org" LANG="de_DE.UTF-8" LC_ALL="" LDFLAGS="-Wl,-O1 -Wl,--as-needed" MAKEOPTS="-j9" PKGDIR="/mnt/portage/packages" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/mnt/portage"
Created attachment 389596 [details] build.log
notes are harmless
*** Bug 529647 has been marked as a duplicate of this bug. ***
*** Bug 529698 has been marked as a duplicate of this bug. ***
Same problem here
Building vlc-2.1.5 with freerdp-1.1.0_beta1_p20130710-r2 works. I saw a new patch upstream in vlc that seems related (https://patches.videolan.org/patch/6254/), but applying it didn't fix the problem for me.
(In reply to Nick Andrade from comment #6) > Building vlc-2.1.5 with freerdp-1.1.0_beta1_p20130710-r2 works. I saw a new > patch upstream in vlc that seems related > (https://patches.videolan.org/patch/6254/), but applying it didn't fix the > problem for me. Yeah, I submitted this patch upstream to fix live ebuilds. Nevertheless it should fix the original problem "error: ‘CLRBUF_24BPP’ undeclared". What is the output when you apply this patch?
Same problem here.
Thanks Pawel, I see the following with the patch: <<<<< ../../doltlibtool --tag=CC --mode=link x86_64-pc-linux-gnu-gcc -std=gnu99 -O2 -march=native -pipe -Wall -Wextra -Wsign-compare -Wundef -Wpointer-arith -Wbad-function-cast -Wwrite-strings -Wmissing-prototypes -Wvolatile-register-var -Werror-implicit-function-declaration -pipe -fvisibility=hidden -rpath '/usr/lib64/vlc/plugins/access' -avoid-version -module -export-symbols-regex ^vlc_entry -shrext .so -no-undefined ../../compat/libcompat.la ../../src/libvlccore.la -Wl,-O1 -Wl,--as-needed -L/usr/lib64/sidplay/builders/ -o libdvdnav_plugin.la libdvdnav_plugin_la-dvdnav.lo -lpthread -ldvdnav -lpthread libtool: link: /usr/bin/x86_64-pc-linux-gnu-nm -B .libs/libdvdnav_plugin_la-dvdnav.o | sed -n -e 's/^.*[ ]\([ABCDGIRSTW][ABCDGIRSTW]*\)[ ][ ]*\([_A-Za-z][_A-Za-z0-9]*\)$/\1 \2 \2/p' | sed '/ __gnu_lto/d' | /bin/sed 's/.* //' | sort | uniq > .libs/libdvdnav_plugin.exp libtool: link: /bin/grep -E -e "^vlc_entry" ".libs/libdvdnav_plugin.exp" > ".libs/libdvdnav_plugin.expT" libtool: link: mv -f ".libs/libdvdnav_plugin.expT" ".libs/libdvdnav_plugin.exp" libtool: link: echo "{ global:" > .libs/libdvdnav_plugin.ver libtool: link: cat .libs/libdvdnav_plugin.exp | sed -e "s/\(.*\)/\1;/" >> .libs/libdvdnav_plugin.ver libtool: link: echo "local: *; };" >> .libs/libdvdnav_plugin.ver libtool: link: x86_64-pc-linux-gnu-gcc -std=gnu99 -shared -fPIC -DPIC .libs/libdvdnav_plugin_la-dvdnav.o -Wl,-rpath -Wl,/var/tmp/portage/media-video/vlc-2.1.5/work/vlc-2.1.5/src/.libs ../../compat/.libs/libcompat.a -L/usr/lib64/sidplay/builders/ ../../src/.libs/libvlccore.so -lrt -lidn -ldl -lm -ldbus-1 -ldvdnav -lpthread -O2 -march=native -Wl,-O1 -Wl,--as-needed -Wl,-soname -Wl,libdvdnav_plugin.so -Wl,-version-script -Wl,.libs/libdvdnav_plugin.ver -o .libs/libdvdnav_plugin.so libtool: link: ( cd ".libs" && rm -f "libdvdnav_plugin.la" && ln -s "../libdvdnav_plugin.la" "libdvdnav_plugin.la" ) ../../doltlibtool --tag=CC --mode=compile x86_64-pc-linux-gnu-gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../.. -DMODULE_NAME=$(p="libdvdread_plugin_la-dvdread.lo"; p="${p##*/}"; p="${p#lib}"; echo "${p%_plugin*}") -DMODULE_NAME_IS_$(p="libdvdread_plugin_la-dvdread.lo"; p="${p##*/}"; p="${p#lib}"; echo "${p%_plugin*}") -DMODULE_STRING=\"$(p="libdvdread_plugin_la-dvdread.lo"; p="${p##*/}"; p="${p#lib}"; echo "${p%_plugin*}")\" -D__PLUGIN__ -I../../include -I../../include -O2 -march=native -pipe -Wall -Wextra -Wsign-compare -Wundef -Wpointer-arith -Wbad-function-cast -Wwrite-strings -Wmissing-prototypes -Wvolatile-register-var -Werror-implicit-function-declaration -pipe -fvisibility=hidden -c -o libdvdread_plugin_la-dvdread.lo `test -f 'dvdread.c' || echo './'`dvdread.c ../../doltlibtool --tag=CC --mode=link x86_64-pc-linux-gnu-gcc -std=gnu99 -O2 -march=native -pipe -Wall -Wextra -Wsign-compare -Wundef -Wpointer-arith -Wbad-function-cast -Wwrite-strings -Wmissing-prototypes -Wvolatile-register-var -Werror-implicit-function-declaration -pipe -fvisibility=hidden -rpath '/usr/lib64/vlc/plugins/access' -avoid-version -module -export-symbols-regex ^vlc_entry -shrext .so -no-undefined ../../compat/libcompat.la ../../src/libvlccore.la -Wl,-O1 -Wl,--as-needed -L/usr/lib64/sidplay/builders/ -o libdvdread_plugin.la libdvdread_plugin_la-dvdread.lo -lpthread -ldvdread libtool: link: /usr/bin/x86_64-pc-linux-gnu-nm -B .libs/libdvdread_plugin_la-dvdread.o | sed -n -e 's/^.*[ ]\([ABCDGIRSTW][ABCDGIRSTW]*\)[ ][ ]*\([_A-Za-z][_A-Za-z0-9]*\)$/\1 \2 \2/p' | sed '/ __gnu_lto/d' | /bin/sed 's/.* //' | sort | uniq > .libs/libdvdread_plugin.exp libtool: link: /bin/grep -E -e "^vlc_entry" ".libs/libdvdread_plugin.exp" > ".libs/libdvdread_plugin.expT" libtool: link: mv -f ".libs/libdvdread_plugin.expT" ".libs/libdvdread_plugin.exp" libtool: link: echo "{ global:" > .libs/libdvdread_plugin.ver libtool: link: cat .libs/libdvdread_plugin.exp | sed -e "s/\(.*\)/\1;/" >> .libs/libdvdread_plugin.ver libtool: link: echo "local: *; };" >> .libs/libdvdread_plugin.ver libtool: link: x86_64-pc-linux-gnu-gcc -std=gnu99 -shared -fPIC -DPIC .libs/libdvdread_plugin_la-dvdread.o -Wl,-rpath -Wl,/var/tmp/portage/media-video/vlc-2.1.5/work/vlc-2.1.5/src/.libs ../../compat/.libs/libcompat.a -L/usr/lib64/sidplay/builders/ ../../src/.libs/libvlccore.so -lrt -lidn -ldl -lm -ldbus-1 -lpthread -ldvdread -O2 -march=native -Wl,-O1 -Wl,--as-needed -Wl,-soname -Wl,libdvdread_plugin.so -Wl,-version-script -Wl,.libs/libdvdread_plugin.ver -o .libs/libdvdread_plugin.so libtool: link: ( cd ".libs" && rm -f "libdvdread_plugin.la" && ln -s "../libdvdread_plugin.la" "libdvdread_plugin.la" ) ../../doltlibtool --tag=CC --mode=compile x86_64-pc-linux-gnu-gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../.. -DMODULE_NAME=$(p="librdp_plugin_la-rdp.lo"; p="${p##*/}"; p="${p#lib}"; echo "${p%_plugin*}") -DMODULE_NAME_IS_$(p="librdp_plugin_la-rdp.lo"; p="${p##*/}"; p="${p#lib}"; echo "${p%_plugin*}") -DMODULE_STRING=\"$(p="librdp_plugin_la-rdp.lo"; p="${p##*/}"; p="${p#lib}"; echo "${p%_plugin*}")\" -D__PLUGIN__ -I../../include -I../../include -O2 -march=native -pipe -Wall -Wextra -Wsign-compare -Wundef -Wpointer-arith -Wbad-function-cast -Wwrite-strings -Wmissing-prototypes -Wvolatile-register-var -Werror-implicit-function-declaration -pipe -fvisibility=hidden -c -o librdp_plugin_la-rdp.lo `test -f 'rdp.c' || echo './'`rdp.c rdp.c: In function 'Open': rdp.c:408:5: error: implicit declaration of function 'freerdp_channels_global_init' [-Werror=implicit-function-declaration] freerdp_channels_global_init(); ^ rdp.c:419:35: warning: assignment from incompatible pointer type [enabled by default] p_sys->p_instance->PreConnect = preConnectHandler; ^ rdp.c:420:36: warning: assignment from incompatible pointer type [enabled by default] p_sys->p_instance->PostConnect = postConnectHandler; ^ rdp.c:421:37: warning: assignment from incompatible pointer type [enabled by default] p_sys->p_instance->Authenticate = authenticateHandler; ^ rdp.c: In function 'Close': rdp.c:484:5: error: implicit declaration of function 'freerdp_channels_global_uninit' [-Werror=implicit-function-declaration] freerdp_channels_global_uninit(); ^ cc1: some warnings being treated as errors Makefile:3236: recipe for target 'librdp_plugin_la-rdp.lo' failed make[5]: *** [librdp_plugin_la-rdp.lo] Error 1 make[5]: Leaving directory '/var/tmp/portage/media-video/vlc-2.1.5/work/vlc-2.1.5/modules/access' Makefile:3531: recipe for target 'all-recursive' failed make[4]: *** [all-recursive] Error 1 make[4]: Leaving directory '/var/tmp/portage/media-video/vlc-2.1.5/work/vlc-2.1.5/modules/access' Makefile:2465: recipe for target 'all' failed make[3]: *** [all] Error 2 make[3]: Leaving directory '/var/tmp/portage/media-video/vlc-2.1.5/work/vlc-2.1.5/modules/access' Makefile:1084: recipe for target 'all-recursive' failed make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory '/var/tmp/portage/media-video/vlc-2.1.5/work/vlc-2.1.5/modules' Makefile:1952: recipe for target 'all-recursive' failed make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory '/var/tmp/portage/media-video/vlc-2.1.5/work/vlc-2.1.5' Makefile:1836: recipe for target 'all' failed make: *** [all] Error 2 >>>>>
I confirm that masking: =net-misc/freerdp-1.2.0_beta1_pre20141115 it compiles well with net-misc/freerdp-1.1.0_beta1_p20130710-r2
(In reply to Nick Andrade from comment #9) > Thanks Pawel, I see the following with the patch: > [...] > rdp.c: In function 'Close': > rdp.c:484:5: error: implicit declaration of function > 'freerdp_channels_global_uninit' [-Werror=implicit-function-declaration] > freerdp_channels_global_uninit(); > ^ > [...] Sorry, omitted that. Both this function and init counterpart are not needed, because they were doing nothing [1]. I've sent a correction to previous patch to vlc developers. Unfortunately there is a problem with FREERDP_*_VERSION macros - they are not defined on freerdp < 1.2.0. Currently vlc-9999 ebuild won't build against freerdp-1.1.*. As a quick fix, you may use patch I've sent upstream [2] - but currently this patch won't work against freerdp 1.1. [1] https://github.com/FreeRDP/FreeRDP/commit/2a82684521dc8b23ae92e284e866227e5194a7bb [2] https://mailman.videolan.org/pipermail/vlc-devel/2014-November/100441.html
Created attachment 390044 [details, diff] Patch based on Pawel's upstream submissions Pawel, so based on the two patches you've submitted upstream, I'm attaching a patch for the vlc-2.1.5 that's currently in Portage. It assumes vlc-2.1.0-newer-rdp.patch is already applied (as it is in the current ebuild for vlc-2.1.5). I just tested it with freerdp-1.2.0 from portage and it builds fine: <<<<< $ emerge -p vlc freerdp These are the packages that would be merged, in order: Calculating dependencies... done! [ebuild R ] net-misc/freerdp-1.2.0_beta1_pre20141115 [ebuild R ] media-video/vlc-2.1.5 >>>>>
Problem with this patch is that version.h file is not available on freerdp-1.1 and because of that version macros are not available. Your patch would cause "...global_(un)init" functions to be omitted on freerdp-1.1 and earlier because version macros are not defined. I think that the easiest solution would be to block freerdp-1.1 in <vlc-2.1.* and require at least freerdp-1.2 in >=vlc-2.2.*. As there is vlc-2.2 RC2 tag in vlc-2.2 git, I will prepare new ebuild to be used against freerdp-1.2. @Mike:
Problem with this patch is that version.h file is not available on freerdp-1.1 and because of that version macros are not available. Your patch would cause "...global_(un)init" functions to be omitted on freerdp-1.1 and earlier because version macros are not defined. I think that the easiest solution would be to block freerdp-1.1 in <vlc-2.1.* and require at least freerdp-1.2 in >=vlc-2.2.*. As there is vlc-2.2 RC2 tag in vlc-2.2 git, I will prepare new ebuild to be used against freerdp-1.2. @Mike Gilbert: could you block <media-video/vlc-2.2*[rdp] in >=net-misc/freerdp-1.2* ebuilds?
(In reply to Paweł Stankowski from comment #14) > @Mike Gilbert: could you block <media-video/vlc-2.2*[rdp] in > >=net-misc/freerdp-1.2* ebuilds? I'm not sure why a blocker is appropriate. Why not set a maximum freerdp version in the relevant vlc ebuilds?
(In reply to Nick Andrade from comment #12) > Created attachment 390044 [details, diff] [details, diff] > Patch based on Pawel's upstream submissions > > Pawel, so based on the two patches you've submitted upstream, I'm attaching > a patch for the vlc-2.1.5 that's currently in Portage. It assumes > vlc-2.1.0-newer-rdp.patch is already applied (as it is in the current ebuild > for vlc-2.1.5). I just tested it with freerdp-1.2.0 from portage and it > builds fine: > <<<<< > $ emerge -p vlc freerdp > > These are the packages that would be merged, in order: > > Calculating dependencies... done! > [ebuild R ] net-misc/freerdp-1.2.0_beta1_pre20141115 > [ebuild R ] media-video/vlc-2.1.5 > >>>>> I was receiving the same compile errors in vlc 2.1.5 and your patch has fixed the problem.
(In reply to Mike Gilbert from comment #15) > (In reply to Paweł Stankowski from comment #14) > > @Mike Gilbert: could you block <media-video/vlc-2.2*[rdp] in > > >=net-misc/freerdp-1.2* ebuilds? > > I'm not sure why a blocker is appropriate. Why not set a maximum freerdp > version in the relevant vlc ebuilds? I think that blocker is more appropiate, because: - This error affects all previous vlc versions with RDP use flag, and many of them are no longer in tree. Even if I fixed all current ebuilds, users upgrading from previous versions may have some problems when freerdp is upgraded before VLC - This is abnormal situation when API is broken in minor upgrade. According to Linux standards, version freerdp-1.2 should be backward compatible with any previous 1.x version. I think that VLC developers thinks the same as they are very angry at freerdp developers who still break their API. Another way to solve that issue would be to set SLOT to "1" and SUBSLOT to "2" in 1.2 ebuilds. VLC was set to be dependent on SLOT "0" of freerdp.
(In reply to Paweł Stankowski from comment #17) Neither of those is a very good reason for a blocker in net-misc/freerdp. Please adjust your deps.
+ 15 Dec 2014; Yixun Lan <dlan@gentoo.org> vlc-2.1.2.ebuild, vlc-2.1.4.ebuild, + vlc-2.1.5.ebuild, vlc-2.1.9999.ebuild, vlc-2.2.9999.ebuild, vlc-9999.ebuild: + 1) drop keywords=amd64-fbsd from live ebuilds 2) vlc-2.1.*: Restricted + <net-misc/freerdp-1.2, bug 529640 3) Fixed qt* use flags when qtchooser and + both qt4 and qt5 are installed
