Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 52951 - (PATCH)Provide support for SHIFT-Up/Down line scrolling in vte/Gnome-terminal.
Summary: (PATCH)Provide support for SHIFT-Up/Down line scrolling in vte/Gnome-terminal.
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All All
: High enhancement (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-04 00:18 UTC by devsk
Modified: 2006-03-21 08:57 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for line scrolling in vte/g-t (vte-line-scroll.patch,2.18 KB, patch)
2004-06-04 00:19 UTC, devsk
Details | Diff
Patch against latest vte for gnome-2.14.0 (vte-line-scroll-cvs.patch,1.96 KB, patch)
2006-03-20 17:30 UTC, devsk
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description devsk 2004-06-04 00:18:44 UTC
Please include this patch in next release of vte ebuild. This patch provides one of the basic functions ignored by vte/g-t people (for sake of HIG, I guess) and i.e. I should be able to scroll line by line, by holding SHIFT key and pressing Up/Down arrows.

Reproducible: Always
Steps to Reproduce:
1.Try shift-up in vte or gnome-terminal
2.
3.

Actual Results:  
It doesn't scroll.

Expected Results:  
It should scroll...:)
Comment 1 devsk 2004-06-04 00:19:54 UTC
Created attachment 32624 [details, diff]
Patch for line scrolling in vte/g-t
Comment 2 devsk 2004-06-04 00:21:17 UTC
Forgot to mention: the patch is against vte-0.11.10.
Comment 3 Joe McCann (RETIRED) gentoo-dev 2004-06-04 10:57:23 UTC
what is wrong with the current key combo (Shift+PgUP/Down)?
Comment 4 devsk 2004-06-04 12:25:06 UTC
those are for page up/down. sometimes its irritating to find that you can't see 5 interesting lines at a time because 2 of those lines are in one page and 3 are on the other...this patch make it possible to scroll by a line at a time using just keyboard. this feature is provided by all other terminals but g-t...And if some people don't like new line-scrolling they don't suffer any side effects because of this patch...its a clean independent patch.
Comment 5 Joe McCann (RETIRED) gentoo-dev 2004-06-04 13:20:57 UTC
ah, ok. I like that behavior better. Have you submitted this patch upstream? Usually patches won't go into the gentoo tree unless they are going to be committed upstream. If it has been posted upstream, post a link to the bug report. 
Comment 6 devsk 2004-06-04 15:25:47 UTC
I haven't posted this upstream deliberately. No point in filing bugs when they are not interested in fixing them. I find both vte and gnome-terminal folks very unreceptive of changes, they never look at their bugs.
Comment 7 devsk 2004-06-08 20:57:29 UTC
so, are you going to take this patch?
Comment 8 devsk 2004-07-17 00:04:06 UTC
http://bugs.gnome.org/show_bug.cgi?id=147757

just filed that bug...now watch it sit there forever...
Comment 9 foser (RETIRED) gentoo-dev 2004-07-20 03:59:11 UTC
Why would this patch be incompatible with HIG I wonder ?
Comment 10 devsk 2004-07-20 20:26:47 UTC
Can you please include this patch in the ebuild, its painful to create overlay on every system that I own and apply the patch manually. And then change it everytime the ebuild changes. I don't have much hope from vte devs!

thanks.
Comment 11 Mike Gardiner (RETIRED) gentoo-dev 2004-11-06 02:18:44 UTC
Added, to a new revision vte-0.11.11-r2.

Thanks for your patch, Sunil.
Comment 12 devsk 2006-03-20 13:06:35 UTC
it seems that the patch is broken in vte-0.12.0 and upstream refuses to apply the working patch because the new maintainer of vte thinks that shift+up line scorlling breaks VIM because he is used to doing page up with shift+up in VIM, so he doesn't like binding shift+up to line scroll up. He doesn't like to do page-up to scroll the page up. Its all about who maintains the package and what he likes.

follow the thread here: http://bugzilla.gnome.org/show_bug.cgi?id=118967

Please help put some sense into him by commenting on the bug. If you think I am wrong, please feel free to say so there as well.

Meanwhile, I will post a patch which works with vte-0.12.0 for the portage, when I am home.
Comment 13 devsk 2006-03-20 17:30:54 UTC
Created attachment 82727 [details, diff]
Patch against latest vte for gnome-2.14.0
Comment 14 Joe McCann (RETIRED) gentoo-dev 2006-03-20 18:37:08 UTC
To be honest, I think upstream is being reasonable. I think you have a negative attitude on that bug which makes me not want to add a patch of yours that upstream won't accept and worry about updating the patch every release. This is an issue that you need to work out upstream. I think the feature is useful, and the alt keybinding suggestion from upstream seems all right. 
Comment 15 devsk 2006-03-20 19:17:12 UTC
Why do you say that I have negative attitude in the bug? The developer upstream has put his personal preference ahead of what is a standard behaviour in other terminals. I tried to argue with him. But he never listened. shift+up in a terminal is known to scroll line by line in all terminals, and I am expecting the same in g-t from a usability and consistency point of view.

Some of my comments were harsh probably, but he frustrated me with his VIM logic. This is when VIM feature doesn't work in xterm, mrxvt, and konsole. he is hell bent on having it working in g-t when he is missing out on other usable request.
Comment 16 devsk 2006-03-20 19:27:20 UTC
Please let the patch go in portage. I will maintain it.
Comment 17 Joe McCann (RETIRED) gentoo-dev 2006-03-20 19:57:14 UTC
I say you have a negative attitude because the vte maintainer said he would accept the feature under a different key binding, and you called him annoying, unadaptive and unreasonable. Right there shows me reason not to work with you. Attitude will go a long way when doing volunteer work in your free time.

We don't often apply patches that upstream won't apply, and this situation doesn't warrant us doing that. Now that vte has an active maintainer, its really up to them what patches go in. I don't want to make it seem like I don't care about the feature...but it is really an issue that needs to be worked out upstream in vte.
Comment 18 devsk 2006-03-20 20:11:23 UTC
I updated the patch here even after two years doesn't guarrantee that you will be able work with me in the future, then what does? I request for re-consideration.
Comment 19 foser (RETIRED) gentoo-dev 2006-03-21 07:06:26 UTC
we are as unreasonable as upstream i guess.
Comment 20 devsk 2006-03-21 08:11:59 UTC
you guys are quoting me out of context. VIM has two keybindings for the same thing: pg-up/down for page navigation and shift+up/down for page navigation, while g-t does not the desired line scrolling like other terminals. And to use that as logic for not supporting the patch is unreasonable by upstream. That's all I said. If it is not unreasonable, please close this bug one last time without any comments. I hope asking for closing it one last time is not too much to ask for having contributed patches to both gnome and gentoo over the past 3 years?

PS: I promise I will never open it again, so please don't flame me.
Comment 21 foser (RETIRED) gentoo-dev 2006-03-21 08:57:24 UTC
I'm not quoting anything, we just won't take it if upstream does not. Is it really that hard to comprehend ? Now stop bothering us and being a nuisance about it.