Bugzilla Bug 52857

when i try to emerge app-emacs/bbdb, it fails with an error message during the
byte compilation of files in bbdb/bits/*.el.

Reproducible: Always
Steps to Reproduce:
1. emerge app-emacs/bbdb
2.
3.

Actual Results:  

 In toplevel form:
 bits/bbdb-anniv.el:66:1:Error: Cannot open load file: bbdb

 In toplevel form:
 bits/bbdb-edit.el:32:1:Error: Cannot open load file: bbdb
 Wrote /var/tmp/portage/bbdb-2.34-r1/work/bbdb-2.34/bits/bbdb-mail-folders.elc

 In toplevel form:
 bits/bbdb-pgp.el:94:1:Error: Cannot open load file: bbdb

 In end of data:
 bits/bbdb-signature.el:193:1:Warning: the following functions are not known to
     be defined: bbdb-search-simple, bbdb-record-getprop
 Wrote /var/tmp/portage/bbdb-2.34-r1/work/bbdb-2.34/bits/bbdb-signature.elc

 In bbdb/calendar-mark-entries:
 bits/bbdb-sort-mailrc.el:74:18:Warning: reference to free variable
     displayed-month
 bits/bbdb-sort-mailrc.el:75:17:Warning: reference to free variable
     displayed-year

 In bbdb/calendar-mark-month:
 bits/bbdb-sort-mailrc.el:83:4:Warning: `message' called with 2 args to fill 0
     format field(s)

 In bbdb/calendar-list-entries:
 bits/bbdb-sort-mailrc.el:92:4:Warning: `message' called with 2 args to fill 0
     format field(s)
 bits/bbdb-sort-mailrc.el:94:56:Warning: reference to free variable
     original-date
 bits/bbdb-sort-mailrc.el:95:23:Warning: reference to free variable number

 In bbdb-record-mail-aliases:
 bits/bbdb-sort-mailrc.el:188:42:Warning: reference to free variable
    bbdb-define-all-aliases-field

 In bbdb-check-mail-alias:
 bits/bbdb-sort-mailrc.el:207:37:Warning: reference to free variable
     bbdb-define-all-aliases-field

 In my-define-mail-abbrev:
 bits/bbdb-sort-mailrc.el:228:15:Warning: local-write-file-hooks is an obsolete
     variable since 21.4; use write-file-functions instead.
 bits/bbdb-sort-mailrc.el:228:10:Warning: local-write-file-hooks is an obsolete
     variable since 21.4; use write-file-functions instead.

 In end of data:
 bits/bbdb-sort-mailrc.el:307:1:Warning: the following functions are not known
     to be defined: add-to-diary-list, bbdb-records, bbdb-record-getprop,
     bbdb-split, bbdb-record-name, parse-string-end, bbdb-current-record,
     bbdb-redisplay-one-record, bbdb-record-net, bbdb-record-putprop,
     bbdb-dwim-net-address, bbdb-define-all-aliases, bbdb-cache-sortkey,
     bbdb-record-cache, bbdb-cache-set-sortkey, bbdb-record-lastname,
     bbdb-record-firstname, bbdb-record-company
 Wrote /var/tmp/portage/bbdb-2.34-r1/work/bbdb-2.34/bits/bbdb-sort-mailrc.elc

 In toplevel form:
 bits/bbdb-to-outlook.el:35:1:Error: Cannot open load file: bbdb

 In date-insert-today:
 bits/dates.el:94:4:Warning: insert-string is an obsolete function since 21.4;
     use insert instead.

In end of data:
bits/dates.el:214:1:Warning: the following functions are not known to be
    defined: f, f/
Wrote /var/tmp/portage/bbdb-2.34-r1/work/bbdb-2.34/bits/dates.elc
Wrote /var/tmp/portage/bbdb-2.34-r1/work/bbdb-2.34/bits/point-at.elc

!!! ERROR: app-emacs/bbdb-2.34-r1 failed.
!!! Function src_compile, Line 49, Exitcode 1
!!! (no error message)



Expected Results:  
emerge should have completed successfully and app-emacs/bbdb installed.

reason for the problem:

the error messages are generated during the byte compilation of the
bbdb/bits/*.el files. the problem is due to the fact that lisp files in
bbdb/lisp/*.el (which are referenced from bbdb/bits/*.el) are not in the
load path.

solution:

simply adding bbdb/lisp/ to the load-path does the trick.
 That's it! Thanks very much. You'll be notified by email about any progress
that is made on fixing your bug.
the diffs:

i am not sure how the patches are submitted for ebuild problems. so i
am submitting a normal diff. if the required format is different please
let me know, and i will do the needful. thanks !


--- /usr/portage/app-emacs/bbdb/bbdb-2.34-r1.ebuild     2004-04-25
22:40:13.000000000 +0530
+++ /root/anupam-bbdb-2.34-r1.ebuild    2004-06-02 12:27:44.010057056 +0530
 @@ -44,7 +44,7 @@

         econf --with-emacs=emacs || die "econf failed"
         make || die
 -       echo "(add-to-list 'load-path \"${S}/bits\")" > ${T}/lp.el
 +       echo "(setq load-path (append '(\"${S}/lisp\" \"${S}/bits\")
load-path))" > ${T}/lp.el
         emacs -batch -q --no-site-file --no-init-file \
                 -l ${T}/lp.el -f batch-byte-compile bits/*.el || die
  }

I backported fix to that problem from bbdb-2.35_pre20040323.ebuild
(the problem was fixed in that ebuild but I was too lazy to apply
the patch against 2.34-r1). Thanks for the bug report.