Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 528332 - sci-visualization/gnuplot-4.6.5: USE plotutils and thin-splines are obsolete
Summary: sci-visualization/gnuplot-4.6.5: USE plotutils and thin-splines are obsolete
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Ulrich Müller
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-05 17:02 UTC by Nikoli
Modified: 2015-04-26 19:31 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nikoli 2014-11-05 17:02:41 UTC
gnuplot-4.6.5 $ grep -Ri thin.splines * -a9
...
ChangeLog-2013-12-21  Ethan A Merritt  <merritt@u.washington.edu>
ChangeLog-
ChangeLog-      * src/Makefile.am: automake 1.14 wants an option subdir-objects
ChangeLog-
ChangeLog-      * configure.in src/show.c:
ChangeLog:      The option --enable-thin-splines no longer does anything; remove it.
Comment 1 Nikoli 2014-11-05 17:12:49 UTC
Also --with-plot was removed several years ago, ChangeLog:

2011-05-31  Ethan A Merritt  <merritt@u.washington.edu>
...
        Remove obsolete terminal drivers gnugraph and unixplot. The underlying
        gnu plotutils library is itself more than 10 years out of date (last
        release July 2000) and the terminal drivers haven't been upgraded for
        longer than that. In any event, current gnuplot has better native
        terminal drivers for the devices supported by unixplot/gnugraph.

http://gnuplot.cvs.sourceforge.net/viewvc/gnuplot/gnuplot/configure.in?r1=1.282&r2=1.283
Comment 2 Christoph Junghans (RETIRED) gentoo-dev 2014-11-08 20:38:37 UTC
+*gnuplot-4.6.6 (08 Nov 2014)
+
+  08 Nov 2014; Christoph Junghans <ottxor@gentoo.org> +gnuplot-4.6.6.ebuild:
+  version bump and remove obsolete USE flags (bug #528332)
+
Comment 3 Ari Entlich 2015-04-26 03:19:54 UTC
Please fix this issue for all ebuilds that it applies to, i.e. all of them.

Additional information:

While the --enable-thin-splines option exists in 4.6.3 and 4.6.4, it has not actually done anything appreciable since 2008[1]. The commit which removes it[2] also removed one last trivial use of this option - deciding when to put +THIN_SPLINES in the output of the "show version" command, presumably to show that gnuplot supports it. Due to this one trivial use, it may make sense to unconditionally enable --enable-thin-splines in versions 4.6.4 and earlier, but it does not make sense to expose it as a USE flag. Alternatively, [2] could be prepared as a patch and applied for versions <= 4.6.4.

To this day, the gnuplot source tree still contains references to THIN_PLATE_SPLINES_GRID. It seems that nobody ever bothered to simply grep through the source code and remove all instances of it at once.

I hate computers.

[1] https://github.com/Reen/gnuplot/commit/c8d74cf02894186556699ec7512e21ed884dea4a
[2] https://github.com/Reen/gnuplot/commit/07149649e6bb103abc24eb22206c1173ef102f6b

Note: https://github.com/Reen/gnuplot is simply a semi up-to-date conversion of the gnuplot CVS repository to git that I found with Google. It served as a convenient way for me to refer to commits in the gnuplot repo.

Thanks.
Comment 4 Ulrich Müller gentoo-dev 2015-04-26 07:55:27 UTC
IMHO, cleanup of a non-functional USE flag is not a good enough reason for retroactively changing the stable ebuild, which would trigger a rebuild for users with --newuse.

@ottxor: Can we stabilise gnuplot-4.6.6? It's in the tree since 6 months.
Comment 5 Ari Entlich 2015-04-26 08:10:00 UTC
Stabilizing 4.6.6 and removing the older ebuilds would also be an acceptable solution to me.
Comment 6 Christoph Junghans (RETIRED) gentoo-dev 2015-04-26 19:31:13 UTC
(In reply to Ulrich Müller from comment #4)
> IMHO, cleanup of a non-functional USE flag is not a good enough reason for
> retroactively changing the stable ebuild, which would trigger a rebuild for
> users with --newuse.
I agree, no touching of stable ebuilds.

> 
> @ottxor: Can we stabilise gnuplot-4.6.6? It's in the tree since 6 months.
Let's try to stabilize gnuplot-5 instead.