Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 527962 - dev-java/icedtea-web-1.5.1 needs dev-java/tagsoup as a build dependency
Summary: dev-java/icedtea-web-1.5.1 needs dev-java/tagsoup as a build dependency
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Java team
URL:
Whiteboard:
Keywords:
: 528008 528328 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-11-02 05:34 UTC by Joe Kappus
Modified: 2015-02-07 11:41 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joe Kappus 2014-11-02 05:34:21 UTC
Gonna need to add in dev-java/tagsoup as a build dependency.  

No soup for you:

>>> Configuring source in /var/tmp/portage/dev-java/icedtea-web-1.5.1/work/icedtea-web-1.5.1 ...
!!! ERROR: Package tagsoup was not found!
 * ERROR: dev-java/icedtea-web-1.5.1::gentoo failed (configure phase):

With tagsoup it builds just fine.
Comment 1 Patrick Lauer gentoo-dev 2014-11-02 09:10:50 UTC
+  02 Nov 2014; Patrick Lauer <patrick@gentoo.org> +icedtea-web-1.5.1-r1.ebuild:                                                                                                                                                                                               
+  Add ebuild for 1.5.1 that unconditionally depends on tagsoup #527962                                                                                                                                                                                                        
+  

That's maybe not the best fix, but it does 'hide' the issue
Comment 2 Andreas Sturmlechner gentoo-dev 2014-11-02 09:30:34 UTC
It's an error in the ebuild. This fixes build without tagsoup for me:

--- a/icedtea-web-1.5.1.ebuild	2014-11-01 23:47:10.000000000 +0100
+++ b/icedtea-web-1.5.1.ebuild	2014-11-02 10:22:27.586582835 +0100
@@ -66,8 +66,9 @@
 		$(use_enable doc docs)
 		$(use_enable nsplugin plugin)
 		$(use_with javascript rhino)
-		$(use_with tagsoup tagsoup $(java-pkg_getjars tagsoup))
+		$(use_with tagsoup tagsoup)
 	)
+	use tagsoup && $config += $(java-pkg_getjars tagsoup)
 
 	unset JAVA_HOME JDK_HOME CLASSPATH JAVAC JAVACFLAGS
 	econf "${config[@]}"
Comment 3 Vlastimil Babka (Caster) (RETIRED) gentoo-dev 2014-11-02 11:11:42 UTC
> It's an error in the ebuild. This fixes build without tagsoup for me:
> 
> --- a/icedtea-web-1.5.1.ebuild	2014-11-01 23:47:10.000000000 +0100
> +++ b/icedtea-web-1.5.1.ebuild	2014-11-02 10:22:27.586582835 +0100
> @@ -66,8 +66,9 @@
>  		$(use_enable doc docs)
>  		$(use_enable nsplugin plugin)
>  		$(use_with javascript rhino)
> -		$(use_with tagsoup tagsoup $(java-pkg_getjars tagsoup))
> +		$(use_with tagsoup tagsoup)
>  	)
> +	use tagsoup && $config += $(java-pkg_getjars tagsoup)

This wouldn't result in --with-tagsoup=/path/to/tagsoup.jar but --with-tagsoup /path/to/tagsoup.jar

Also it's prone to someone adding another use_with or use_enable after use_with tagsoup.

Fixed like this instead:

        local tagsoup_jar
        local config

        # bug #527962
        use tagsoup && tagsoup_jar="$(java-pkg_getjars tagsoup)"

        config=(
                # javaws is managed by eselect java-vm and symlinked to by icedtea so
                # move it out of the way and symlink itweb-settings back to bin
                --bindir="${EPREFIX}"/usr/libexec/${PN}
                --with-jdk-home="${JAVA_HOME}"
                $(use_enable doc docs)
                $(use_enable nsplugin plugin)
                $(use_with javascript rhino)
                $(use_with tagsoup tagsoup ${tagsoup_jar})
        )

Thanks.
Comment 4 Vlastimil Babka (Caster) (RETIRED) gentoo-dev 2014-11-02 22:58:14 UTC
*** Bug 528008 has been marked as a duplicate of this bug. ***
Comment 5 Jeroen Roovers (RETIRED) gentoo-dev 2014-11-05 16:52:55 UTC
*** Bug 528328 has been marked as a duplicate of this bug. ***
Comment 6 Justin Lecher (RETIRED) gentoo-dev 2015-02-07 11:41:30 UTC
*** Bug 528008 has been marked as a duplicate of this bug. ***