Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 527700 - net-misc/freerdp-1.1.0_beta1_p20130710-r2: CMakeLists.txt should not include "include(CMakeDetermineSystem)"
Summary: net-misc/freerdp-1.1.0_beta1_p20130710-r2: CMakeLists.txt should not include ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mike Gilbert
URL: https://github.com/FreeRDP/FreeRDP/is...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-01 08:07 UTC by Maxim Britov
Modified: 2014-11-12 08:35 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maxim Britov 2014-11-01 08:07:51 UTC 
With cmake-utils.eclass revision=1.112 I can't build net-misc/freerdp-9999.1:0

Build fail with:
CMake Error at winpr/CMakeLists.txt:20 (project):
  The CMAKE_C_COMPILER:

    x86_64-pc-linux-gnu-gcc

  is not a full path and was not found in the PATH.


Some info about: https://bugs.gentoo.org/show_bug.cgi?id=503216#c27

dev-util/cmake-3.0.2


Reproducible: Always
Comment 1 James Le Cuirot gentoo-dev 2014-11-01 08:19:59 UTC 
Despite what the error says, I have seen more than one comment stating that CMake 3 now requires an absolute path. That might have something to do with why the "type -P" stuff was there. I'm not sure why this error doesn't appear on every package though. Alexis, over to you.
Comment 2 Alexis Ballier gentoo-dev 2014-11-02 06:57:28 UTC 
freerdp calls: include(CMakeDetermineSystem) in its CMakeLists.txt; according to what I've read this is not for usage outside of cmake and removing this line makes freerdp work with latest cmake-utils.eclass
Comment 3 Maxim Britov 2014-11-02 11:10:54 UTC 
(In reply to Alexis Ballier from comment #2)

upstream
https://github.com/FreeRDP/FreeRDP/issues/2181
Comment 4 Maxim Britov 2014-11-07 17:17:45 UTC 
(In reply to Alexis Ballier from comment #2)
> freerdp calls: include(CMakeDetermineSystem) in its CMakeLists.txt;
> according to what I've read this is not for usage outside of cmake and
> removing this line makes freerdp work with latest cmake-utils.eclass

Thanks. With this change I can build freerdp.

diff -Naur freerdp-9999.1/CMakeLists.txt freerdp-9999.2/CMakeLists.txt
--- freerdp-9999.1/CMakeLists.txt	2014-11-07 20:09:28.506125117 +0300
+++ freerdp-9999.2/CMakeLists.txt	2014-11-07 20:11:33.648124922 +0300
@@ -44,7 +44,6 @@
 include(CheckIncludeFiles)
 include(CheckLibraryExists)
 include(CheckStructHasMember)
-include(CMakeDetermineSystem)
 include(FindPkgConfig)
 include(TestBigEndian)
Comment 6 Yixun Lan archtester gentoo-dev 2014-11-11 20:41:58 UTC 
same probem als in version 1.1.0_beta1_p20130710-r2
Comment 8 Justin Lecher (RETIRED) gentoo-dev 2014-11-12 08:35:45 UTC 
+  12 Nov 2014; Justin Lecher <jlec@gentoo.org>
+  freerdp-1.1.0_beta1_p20130710-r2.ebuild,
+  +files/freerdp-1.1.0_beta1_p20130710-cmake.patch, metadata.xml:
+  Fix usage of internal cmake modules, #527700
+