Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 526538 - sys-apps/pv - --remote requires CONFIG_SYSVIPC
Summary: sys-apps/pv - --remote requires CONFIG_SYSVIPC
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jeroen Roovers (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-23 02:17 UTC by Andrew Miller
Modified: 2015-04-14 05:12 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild with config check (pv-1.5.7.ebuild,1.43 KB, text/plain)
2014-10-23 02:18 UTC, Andrew Miller
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Miller 2014-10-23 02:17:08 UTC
sys-apps/pv needs CONFIG_SYSVIPC=y for the --remote option.

Currently the two ebuilds (pv-1.5.3.ebuild and pv-1.5.7.ebuild) do not check for it, there are no dependencies that check for it, and there are no packages in @system that check for it.

If you compile pv with FEATURES="test" or you try to use the --remote option with a kernel that doesn't support it, you get an error message, but in both cases you aren't told what kernel config option is missing.

I think the ebuild should check the kernel config and warn if CONFIG_SYSVIPC=n.

Reproducible: Always
Comment 1 Andrew Miller 2014-10-23 02:18:13 UTC
Created attachment 387250 [details]
ebuild with config check
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2014-10-23 09:01:05 UTC
Comment on attachment 387250 [details]
ebuild with config check

--- pv-1.5.7.ebuild
+++ pv-1.5.7.ebuild
@@ -1,9 +1,9 @@
 # Copyright 1999-2014 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/sys-apps/pv/pv-1.5.7.ebuild,v 1.2 2014/10/20 09:47:43 jer Exp $
+# $Header: /var/cvsroot/gentoo-x86/sys-apps/pv/pv-1.5.7.ebuild,v 1.1 2014/08/27 08:44:26 jer Exp $

 EAPI=5
-inherit toolchain-funcs
+inherit linux-info toolchain-funcs

 DESCRIPTION="Pipe Viewer: a tool for monitoring the progress of data through a pipe"
 HOMEPAGE="http://www.ivarch.com/programs/pv.shtml"
@@ -11,7 +11,7 @@

 LICENSE="Artistic-2"
 SLOT="0"
-KEYWORDS="~alpha ~amd64 ~arm hppa ~mips ~ppc ~ppc64 ~sparc ~x86 ~amd64-linux ~x86-linux ~ppc-macos ~x86-macos ~sparc64-solaris ~x86-solaris"
+KEYWORDS="~alpha ~amd64 ~arm ~hppa ~mips ~ppc ~ppc64 ~sparc ~x86 ~amd64-linux ~x86-linux ~ppc-macos ~x86-macos ~sparc64-solaris ~x86-solaris"
 IUSE="debug nls"

 PV_LINGUAS=( de fr pl pt )
@@ -19,6 +19,14 @@

 DOCS=( README doc/NEWS doc/TODO )

+pkg_setup() {
+       if use kernel_linux; then
+               CONFIG_CHECK="~SYSVIPC"
+               ERROR_SYSVIPC="You need CONFIG_SYSVIPC=y to use the --remote option."
+               linux-info_pkg_setup
+       fi
+}
+
 src_prepare() {
        sed -i configure -e 's|CFLAGS="-g -Wall"|:|g' || die
        # These should produce the same end result (working `pv`).
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2015-04-14 05:12:09 UTC
Added in 1.6.0-r1.