Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 526118 - media-video/cinelerra-20140710 - Makefile:745: recipe for target 'picon_png.h' failed
Summary: media-video/cinelerra-20140710 - Makefile:745: recipe for target 'picon_png.h...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-20 16:39 UTC by Helmut Jarausch
Modified: 2015-02-08 16:22 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
cinelerra-20140710.build (cinelerra-20140710.build,521.26 KB, text/plain)
2014-10-20 16:39 UTC, Helmut Jarausch
Details
Make pngtoh return 0 on success (cinelerra_pngtoh_return0.patch,224 bytes, patch)
2015-01-29 13:47 UTC, Bernd Feige
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Helmut Jarausch 2014-10-20 16:39:11 UTC
Created attachment 387072 [details]
cinelerra-20140710.build

media-video/cinelerra-20140710 fails to build :

make[3]: Entering directory '/var/tmp/portage/media-video/cinelerra-20140710/work/cinelerra-20140710/plugins/1080to540'
../../guicast/pngtoh picon.png || { rm -f picon_png.h; exit 1; }
Makefile:745: recipe for target 'picon_png.h' failed

emerge --info media-video/cinelerra
Portage 2.2.14_rc1 (python 3.4.2-final-0, default/linux/amd64/13.0/desktop, gcc-4.9.1, glibc-2.19-r1, 3.17.1-gentoo-r1 x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-3.17.1-gentoo-r1-x86_64-AMD_Phenom-tm-_II_X4_940_Processor-with-gentoo-2.2
KiB Mem:     7906596 total,   4810620 free
KiB Swap:    2097148 total,   2097148 free
Timestamp of tree: Mon, 20 Oct 2014 13:45:01 +0000
ld GNU ld (Gentoo 2.24 p1.4) 2.24
ccache version 3.1.9 [disabled]
app-shells/bash:          4.3_p30
dev-java/java-config:     2.2.0
dev-lang/perl:            5.20.1-r1
dev-lang/python:          2.7.8, 3.3.5-r1, 3.4.2
dev-util/ccache:          3.1.9-r3
dev-util/cmake:           3.0.2
dev-util/pkgconfig:       0.28-r2
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.13.1
sys-apps/sandbox:         2.6-r1
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.8.5-r4, 1.9.6-r3, 1.10.3, 1.11.6, 1.12.6, 1.13.4, 1.14.1
sys-devel/binutils:       2.24-r3
sys-devel/gcc:            4.8.3, 4.9.1
sys-devel/gcc-config:     1.8
sys-devel/libtool:        2.4.2-r1
sys-devel/make:           4.1
sys-kernel/linux-headers: 3.17 (virtual/os-headers)
sys-libs/glibc:           2.19-r1
Repositories: gentoo local sunrise
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-mtune=native -O2 -msse3 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt /var/lib/hsqldb /var/lib/neatx/home"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.4/ext-active/ /etc/php/apache2-php5.5/ext-active/ /etc/php/apache2-php5.6/ext-active/ /etc/php/cgi-php5.4/ext-active/ /etc/php/cgi-php5.5/ext-active/ /etc/php/cgi-php5.6/ext-active/ /etc/php/cli-php5.4/ext-active/ /etc/php/cli-php5.5/ext-active/ /etc/php/cli-php5.6/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-mtune=native -O2 -msse3 -pipe"
DISTDIR="/usr/portage/distfiles"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs buildpkg config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms splitdebug strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="ftp://sunsite.informatik.rwth-aachen.de/pub/Linux/gentoo "
LANG="en_US.iso88591"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j4"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage /usr/local/portage/layman/sunrise"
SYNC="rsync://rsync.informatik.RWTH-Aachen.de/gentoo-portage"
USE="3dnow 3dnowext 3dnowprefetch X a52 aac acl acpi alsa amd64 avahi berkdb branding bzip2 cairo cdda cdr cli consolekit cracklib crypt cups cxx dbus dri dts dvd dvdr emboss encode exif fam ffmpeg fftw firefox flac fortran fuse gdbm gfortran gif gimp glamor gpm gtk gtk3 iconv ipv6 jpeg lapack lcms libnotify mad mmx mmxext mng modules mp3 mp4 mpeg multilib ncurses nls nptl nptlonly ogg opengl openmp pam pango pcre pdf png policykit ppds python qt qt3support qt4 readline sdl session smp spell sqlite sqlite3 sse sse2 sse3 sse4a ssl startup-notification svg systemd tcl tcpd threads tiff tk truetype udev udisks unicode upower usb vorbis wxwidgets x264 xcb xml xulrunner xv xvid zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="pc multiboot" INPUT_DEVICES="keyboard mouse evdev wacom" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="en de" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_4" RUBY_TARGETS="ruby21" USERLAND="GNU" VIDEO_CARDS="ati radeon fglrx" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON

=================================================================
                        Package Settings
=================================================================

media-video/cinelerra-20120707 was built with the following:
USE="3dnow alsa mmx opengl (-altivec) -css -ieee1394 -oss" ABI_X86="64"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,-z,noexecstack"
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2014-10-20 18:07:21 UTC
tried with MAKEOPTS="-j1" yet?
Comment 2 Helmut Jarausch 2014-10-21 08:50:27 UTC
(In reply to Samuli Suominen from comment #1)
> tried with MAKEOPTS="-j1" yet?

Yes, I did.
Comment 3 Bernd Feige 2015-01-29 13:47:00 UTC
Created attachment 395114 [details, diff]
Make pngtoh return 0 on success

Heya,
Stumbled upon this here today. The reason is that pngtoh.c lacks a return statement on success, rendering the return value undefined on our configuration. Adding it it works.
Best regards,
Bernd
Comment 4 Ivan Iraci 2015-01-30 12:16:49 UTC
Worked for me too.
Comment 5 Bernd Feige 2015-01-30 16:31:29 UTC
I've just reported this upstream:
http://bugs.cinelerra-cv.org/ticket/1005
Comment 6 Juergen Rose 2015-01-31 09:53:48 UTC
(In reply to Bernd Feige from comment #3)
> Created attachment 395114 [details, diff] [details, diff]
> Make pngtoh return 0 on success
> 
> Heya,
> Stumbled upon this here today. The reason is that pngtoh.c lacks a return
> statement on success, rendering the return value undefined on our
> configuration. Adding it it works.
> Best regards,
> Bernd

Thanks for the patch.
Comment 7 Preston Crow 2015-02-02 21:41:30 UTC
I just found that this failed to build.  I switched from gcc-4.9.2 to gcc-4.8.4 and it installed just fine.  I didn't look at the errors to see if it's the same as this report.  I don't know if the change in gcc is exposing a legitimate bug in the program, or if it's a bug in gcc.

Anyway, I hope this helps in understanding what's going on.
Comment 8 Bernd Feige 2015-02-03 09:02:07 UTC
(In reply to Preston Crow from comment #7)
> I just found that this failed to build.  I switched from gcc-4.9.2 to
> gcc-4.8.4 and it installed just fine.  I didn't look at the errors to see if
> it's the same as this report.  I don't know if the change in gcc is exposing
> a legitimate bug in the program, or if it's a bug in gcc.
> 
> Anyway, I hope this helps in understanding what's going on.

It surely does. Here the error also occurred with gcc-4.9.2. I was unsure whether the C library or compiler are to blame for the changed behavior.

See http://stackoverflow.com/questions/204476/what-should-main-return-in-c-and-c for an extensive discussion of return values - Under some conditions it appears that a return value of 0 is implicit. So it may be that gcc-4.9.2 changed this behavior (should be in the User Visible Changes then) or it's a regression. Anyway, not returning a value from a function declared to return int is at least bad programming style. IMHO, one should not bet upon obscure fringe behavior.
BTW: Did you try the patch? It should work with either compiler.
Comment 9 Guy 2015-02-05 23:25:50 UTC
(In reply to Bernd Feige from comment #8)

> .. Anyway, not returning a value from a function declared to return
> int is at least bad programming style. IMHO, one should not bet upon obscure
> fringe behavior.
> BTW: Did you try the patch? It should work with either compiler.

The patch worked for me using gcc-4.9.2.
Comment 10 Alexis Ballier gentoo-dev 2015-02-08 16:22:02 UTC
(In reply to Bernd Feige from comment #3)
> Created attachment 395114 [details, diff] [details, diff]
> Make pngtoh return 0 on success
> 
> Heya,
> Stumbled upon this here today. The reason is that pngtoh.c lacks a return
> statement on success, rendering the return value undefined on our
> configuration. Adding it it works.
> Best regards,
> Bernd

applied that patch, thanks

+  08 Feb 2015; Alexis Ballier <aballier@gentoo.org> cinelerra-20140710.ebuild,
+  +files/cinelerra-pngtoh.patch:
+  Fix build with gcc 4.9, patch by Bernd Feige in bug #526118
+