Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 526096 - =dev-vcs/git-cola-2.0.7 - README.gentoo file has literal elog messages
Summary: =dev-vcs/git-cola-2.0.7 - README.gentoo file has literal elog messages
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Tiziano Müller (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-20 15:04 UTC by Coacher
Modified: 2014-10-21 07:09 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info git-cola (info,5.62 KB, text/plain)
2014-10-20 15:04 UTC, Coacher
Details
README.gentoo.bz2 (README.gentoo.bz2,366 bytes, application/x-bzip)
2014-10-20 15:06 UTC, Coacher
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Coacher 2014-10-20 15:04:21 UTC
Hello.

The following message is printed upon installation:
 * PYTHONPATH="${S}:${S}/build/lib:${PYTHONPATH}" LC_ALL="C" nosetests \
 * --verbose --with-doctest --with-id --exclude=jsonpickle --exclude=json \
 * || die "running nosetests failed"
 * }
 *
 * pkg_postinst() {
 * elog "Please make sure you have either a SSH key management installed and activated or"
 * elog "installed a SSH askpass app like net-misc/x11-ssh-askpass."
 * elog "Otherwise git-cole may hang when pushing/pulling from remote git repositories via SSH. "
 * }
 *
 * (Note: Above message is only printed the first time package is
 * installed. Please look at /usr/share/doc/git-cola-2.0.7/README.gentoo*
 * for future reference)
>>> dev-vcs/git-cola-2.0.7 merged.

Several things look buggy.
1. Does that PYTHONPATH line really should be there?. It is weird and useless.
2. pkg_postinst really should not print its own name
3. "Otherwise git-cole..." from last elog line shoud be "Otherwise git-cola...". Maybe using ${PN} there is even better.

I cannot provide you the build.log as mentioned lines are not printed upon subsequent rebuilds.
However, these lines are shown right before merge stage is completed.

Reproducible: Always
Comment 1 Coacher 2014-10-20 15:04:44 UTC
Created attachment 387066 [details]
emerge --info git-cola
Comment 2 Coacher 2014-10-20 15:06:39 UTC
Created attachment 387068 [details]
README.gentoo.bz2

bzipped README.gentoo file mentioned in emerge output.
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2014-10-20 15:12:47 UTC
Comment on attachment 387068 [details]
README.gentoo.bz2

oops
Comment 4 Pacho Ramos gentoo-dev 2014-10-20 15:57:11 UTC
Errr, Why "${FILESDIR}"/README.gentoo has this content?
        PYTHONPATH="${S}:${S}/build/lib:${PYTHONPATH}" LC_ALL="C" nosetests \
                --verbose --with-doctest --with-id --exclude=jsonpickle --exclude=json \
                || die "running nosetests failed"
}

pkg_postinst() {
        elog "Please make sure you have either a SSH key management installed and activated or"
        elog "installed a SSH askpass app like net-misc/x11-ssh-askpass."
        elog "Otherwise git-cole may hang when pushing/pulling from remote git repositories via SSH. "
}

The eclass is elogging and saving that content (as expected) :/
Comment 5 Justin Lecher (RETIRED) gentoo-dev 2014-10-20 17:20:37 UTC
(In reply to Pacho Ramos from comment #4)
> The eclass is elogging and saving that content (as expected) :/

Shame on me, I will fix that
Comment 6 Justin Lecher (RETIRED) gentoo-dev 2014-10-20 17:21:45 UTC
+  20 Oct 2014; Justin Lecher <jlec@gentoo.org> files/README.gentoo:
+  Fix borked README, #526096
+
Comment 7 Coacher 2014-10-20 17:49:38 UTC
(In reply to Justin Lecher from comment #6)
> +  20 Oct 2014; Justin Lecher <jlec@gentoo.org> files/README.gentoo:
> +  Fix borked README, #526096
> +

Thanks!

Can you please also fix this:
> 3. "Otherwise git-cole..." from last elog line shoud be "Otherwise git-cola...". 

Don't want to reopen and bother people with such a minor issue.
Comment 8 Coacher 2014-10-20 22:00:23 UTC
(In reply to Coacher from comment #7)
> Can you please also fix this:
> > 3. "Otherwise git-cole..." from last elog line shoud be "Otherwise git-cola...". 
> 
> Don't want to reopen and bother people with such a minor issue.

Hmm, it looks like I have to reopen this one in order to have it looked at.

Please fix typo.
Comment 9 Justin Lecher (RETIRED) gentoo-dev 2014-10-21 06:57:34 UTC
(In reply to Coacher from comment #8)
> (In reply to Coacher from comment #7)
> > Can you please also fix this:
> > > 3. "Otherwise git-cole..." from last elog line shoud be "Otherwise git-cola...". 
> > 
> > Don't want to reopen and bother people with such a minor issue.
> 
> Hmm, it looks like I have to reopen this one in order to have it looked at.

Sometimes even we might be offline ;)

+  21 Oct 2014; Justin Lecher <jlec@gentoo.org> files/README.gentoo:
+  Fix typo, #526096; thanks Coacher spotting this
+
Comment 10 Coacher 2014-10-21 07:09:38 UTC
(In reply to Justin Lecher from comment #9)
> (In reply to Coacher from comment #8)
> > (In reply to Coacher from comment #7)
> > > Can you please also fix this:
> > > > 3. "Otherwise git-cole..." from last elog line shoud be "Otherwise git-cola...". 
> > > 
> > > Don't want to reopen and bother people with such a minor issue.
> > 
> > Hmm, it looks like I have to reopen this one in order to have it looked at.
> 
> Sometimes even we might be offline ;)

Oh, I see. Sorry for being so impatient.

> +  21 Oct 2014; Justin Lecher <jlec@gentoo.org> files/README.gentoo:
> +  Fix typo, #526096; thanks Coacher spotting this
> +

Thanks!