Bugzilla Bug 52551

Latest fcitx, a chinese input application

Created an attachment (id=32378) [edit]
fcitx-2.0.2-r1.ebuild

Created an attachment (id=32379) [edit]
fcitx-2.1.0rc patch

update patch for fcitx-2.0.2 to fcitx-2.1.0rc

new version fixed input problem in mozilla and opera with new user interface

Created an attachment (id=32387) [edit]
fcitx-2.0.2-r1.ebuild

change make install part

I will take a look at this in a few. Perhaps LiquidX can do the same, since my
Chinese is rudimentary. :)

Issues with fcitx-2.0.2-r1.ebuild:

1.

src_unpack() {
	unpack ${A}
	epatch ${FILESDIR}/fcitx-2.1.0rc.diff
}

Why are you applying a diff to 2.1.0rc? An ebuild with a version number of 2.0.2 should install fcitx version 2.0.2.

2.

src_compile() {
	./configure --prefix=/usr || die "configure failed"
	make || die "emake failed"
}

Use econf instead:

src_compile() {
	econf || die "configure failed"
	make || die "make failed"
}

econf handles setting all of the Gentoo-specific install locations (prefix, host, mandir, infodir, datadir, sysconfdir, localstatedir). See this doc:

http://www.gentoo.org/doc/en/gentoo-howto.xml

Josh Glover,
2.0.2 has a serious bug, can not input in mozilla and opera.
fcitx just release a 2.1.0 rc version, so i think maybe just use -r1

can you delete my ebuild, i will upload a new one. It seems that you can not overwrite the old ebuild.

If it is versioned as 2.1.0rc by upstream, we should probablly name
the ebuild fcix-2.1.0_rc1 (or fcix-2.1.0_rc). It is our convention to
use _rc suffix for release candidate. For more detail about
versioning, see "Naming Policy" in Gentoo Linux Development Policy
http://www.gentoo.org/doc/en/policy.xml

Okay, I've just changed its name to fcitx-2.1.0_rc.ebuild and
committed. Thanks for the contribution.

P.S. What about fcitx-3.0.0test2.tar.bz2? Is it worth including
into Portage tree? If you make an ebuild for it, it should be
named either fcitx-3.0.0_alpha2, fcitx-3.0.0_beta2, fcitx-3.0.0_pre2
or fcitx-3.0.0_rc2. See Gentoo Policy for detail.

As far as i known, we just started to test this new version, but it seems that
is very unstable now. After tried a little bit, lots of people switched back to
2.0.2-r1. Another reason is the new version change X11 xinput script, which i
think it is a very bad idea, but i think i can patch it for gentoo if you guys
want it.

btw, is there anyway can put my email address in cjk@gentoo.org, so i will be
able to catch up other fellow's work, thx lots!

I didn't put fcitx-2.0.2.ebuild since you said it has serious bug
regarding to opera and mozilla. If you would make a patch for the
bug to 2.0.2 I'm very happy adding it to CVS.

Also, I added you to cjk alias. (You can use "prefs" at the bottom
of the bugzilla to track others' bugs yourself, but this time I just
added your mail address to the alias)

Created an attachment (id=34049) [edit]
fcitx 3.0.0test2 ebuild

5 mins work, for testing only.
I am not sure if it is stable or not.
It fixed lots of 2.0.2 bugs.
Opera and mozilla bugs fixed

Created an attachment (id=34125) [edit]
fcitx-3.0.0test3.tar.bz2

1. fix wubi speed problem
2. fix lumaqq can not input problem
3. some other fix

Created an attachment (id=34126) [edit]
fcitx-3.0.0_beta3.ebuild

A dump version

Hi, Jackey. Here is comments on your fcitx-3.0.0_beta3.ebuild.

* Versioning is fine. Great ;)
* You mustn't change ${P}. Use ${MY_P} or whatever instead.
  Read Ebuild HOWTO http://www.gentoo.org/doc/en/gentoo-howto.xml
  It would be better to set "MY_P=${P/_beta/test}"
* If you don't change ${S} from default, you shouldn't write it.
* src_unpack() defaults to unpack ${A}, so you can safely remove 
  the function from you ebuild.
* Don't you need to pass --enable-xft to econf if USE=truetype is set?
* "make DESTDIR=${D} install || die" is preferred than "einstall || die"
  if "make DESTDIR=${D} install" works. Read useful comments in
  /usr/portage/skel.ebuild.

Regarding to ${MY_P}, you better not hardcode version number.
If you hardcode version number to ${MY_P}, it will need some work to
upgrade the ebuild (renaming the ebuild does not always work if you
embed version number), hence you must be familiar with pre-defined
variables in Portage (described in Ebuild HOWTO). Thanks to bash we 
usually don't need to use sed or perl to transform ${P} into ${MY_P}.
Read "man bash" for parameter expansion feature.