In VLC-3.0 available in git there is new configure check added: 3763 PKG_CHECK_MODULES([QTX11], [Qt5X11Extras], [ 3764 VLC_ADD_LIBS([qt4],[${QTX11_LIBS}]) 3765 VLC_ADD_CXXFLAGS([qt4],[${QTX11_CFLAGS} -DQT5_HAS_X11]) 3766 ],[ 3767 AC_MSG_WARN([Not building Qt Interface with X11 helpers.]) 3768 ]) This is optional requirement for Qt5, but these features were always enabled in Qt4 (check commit 96d10f50, when Qt5X11Extras are detected, Q_WS_X11 is being defined - it was always defined in QtGui4). The most important (only?) feature that is enabled when Qt5X11Extras are installed is playing video in the main screen (w/o it new window is displayed when playing video). I think it was made as optional requirement mainly because Qt5X11Extras module is not available on some platforms (e.g. Android) and on Gentoo Linux we should add this requirement to qt5 USE flag (and not create new USE flag).
As VLC also runs fine with Qt5 and Wayland, we should not depend on Qt5X11Extras just for the qt USE. Probably it would be better to require Qt5X11Extras if both qt and X USE are selected.
Sounds good, Uwe. Qt5X11Extras are properly detected in trunk and 2.2 branch. I think it would be possible to backport some changes from trunk to 2.1 branch to fix qt5+X USE flags combo in VLC 2.1 as well. I'll try and come back with a patch.
Qt5 should not be used with vlc 2.1, it is not really considered usable by upstream. If you want Qt5, use either 2.2-git or 3.0-git.
However there is qt5 use flag in current 2.1 VLC ebuilds, and at least basic functonslities work after applying patch from bug 489508.
Created attachment 388722 [details, diff] Add missing qtx11extras dependency for Qt5
Dependency added unconditionally as X is currently required when qt5 is selected. We will have to fix that later - currently upstream devs don't consider wayland support as ready.
