Bug 524454 – net-wireless/bluez with sys-libs/musl - fails to build because of glibc-specific getpt() and non-POSIX use of headers

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Anthony Basile 2014-10-04 13:21:04 UTC]

Several versions of bluez fail to build on musl because of not conforming to POSIX.  Since bluez is important for embedded systems and since musl is the new sexy libc for embedded and since the fixes are simple, we should probably put these in.

I'm ready to send the patches upstream, but I can't seem to find how to submit upstream?  If you know, it may save me some time searching.

Reproducible: Always

[Comment 1 Anthony Basile 2014-10-04 13:44:55 UTC]

Created attachment 386038 [details, diff]
This fixes the header files to be POSIX compliant.

This patch is already upstream at

http://git.kernel.org/cgit/bluetooth/bluez.git/commit/?id=51ec4fd847369bc77e72850fe93d727ae9c656b9

Can we backport it to 5.23 please?

[Comment 2 Anthony Basile 2014-10-04 13:46:43 UTC]

Created attachment 386040 [details, diff]
Use posix_openpt() instead of the glibc-specific getpt().

This patch has yet to go upstream.  It applies cleanly to 5.23.  `man 3 getpt` for further information about the equivalency.

[Comment 3 Anthony Basile 2014-10-04 14:42:26 UTC]

(In reply to Anthony Basile from comment #2)
> Created attachment 386040 [details, diff] [details, diff]
> Use posix_openpt() instead of the glibc-specific getpt().
> 
> This patch has yet to go upstream.  It applies cleanly to 5.23.  `man 3
> getpt` for further information about the equivalency.

Okay this is submited upstream:

http://marc.info/?l=linux-bluetooth&m=141243367702536&w=2

[Comment 4 Anthony Basile 2014-10-09 02:27:44 UTC]

(In reply to Anthony Basile from comment #3)
> (In reply to Anthony Basile from comment #2)
> > Created attachment 386040 [details, diff] [details, diff] [details, diff]
> > Use posix_openpt() instead of the glibc-specific getpt().
> > 
> > This patch has yet to go upstream.  It applies cleanly to 5.23.  `man 3
> > getpt` for further information about the equivalency.
> 
> Okay this is submited upstream:
> 
> http://marc.info/?l=linux-bluetooth&m=141243367702536&w=2

And it is accepted upstream

http://marc.info/?l=linux-bluetooth&m=141269379106447&w=2

Can we get it backported?

[Comment 5 Pacho Ramos 2014-10-11 11:01:06 UTC]

+*bluez-5.24 (11 Oct 2014)
+
+  11 Oct 2014; Pacho Ramos <[e-mail]> +bluez-5.24.ebuild,
+  +files/bluez-5.24-musl-compat.patch:
+  Version bump, fix compat with musl (#524454 by Anthony Basile), install
+  gatttool (#524640 by Jason Zaman), install hex2hcd (by amak79).
+