Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 523172 - kde-base/smokeqt ebuilds incorrectly set DISABLE_Qwt5 rather than WITH_Qwt5
Summary: kde-base/smokeqt ebuilds incorrectly set DISABLE_Qwt5 rather than WITH_Qwt5
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] KDE (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-19 00:21 UTC by Taahir Ahmed
Modified: 2014-12-09 16:40 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Failing build log (1411081533-install-kde-base_smokeqt-4.12.5:4::gentoo.out,156.64 KB, application/octet-stream)
2014-09-22 14:56 UTC, Taahir Ahmed
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Taahir Ahmed 2014-09-19 00:21:35 UTC
All smokeqt ebuilds in the tree use $(cmake-utils_use_disable qwt Qwt5), but the smokeqt CMakeLists.txt is expecting the form "WITH_Qwt5", not "DISABLE_Qwt5".

This causes a build failure when the qwt use-flag is not set, and qwt is not installed on the system.

Switching the line to use $(cmake-utils_use_with qwt Qwt5) resolves the issue.

Reproducible: Always
Comment 1 Michael Palimaka (kensington) gentoo-dev 2014-09-22 14:34:28 UTC
Could you please attach the build log (I wasn't able to reproduce locally)?
Comment 2 Taahir Ahmed 2014-09-22 14:56:38 UTC
Created attachment 385284 [details]
Failing build log
Comment 3 Michael Palimaka (kensington) gentoo-dev 2014-09-22 15:05:46 UTC
> -----------------------------------------------------------------------------
> -- The following external packages were located on your system.
> -- This installation will have the extra features provided by these packages.
> -----------------------------------------------------------------------------
>    * Qwt5 for Qt4 - Qwt5 libraries for Qt4

Do you have a stray qwt.h somewhere?
Comment 4 Taahir Ahmed 2014-09-22 16:00:55 UTC
I don't seem to.  However, I have run some updates since running into this bug, including installing, including resolving smokeqt with the 'qwt' useflag.

I can't seem to repro this anymore -- removing qwt and unsetting the 'qwt' use flag doesn't cause the build failure, even reverting my change to the ebuild.  smokeqt's CMakeListstxt correctly identifies that the qwt optional feature should not be built.

I'm pretty sure this is an orthogonal issue, though.  As far as I can tell, the package really is expecting WITH_Qwt5.  For example, if I have qwt:5 installed, but '-qwt' set on smokeqt, smokeqt still builds with qwt support.
Comment 5 Michael Palimaka (kensington) gentoo-dev 2014-09-22 16:43:11 UTC
There's two different methods of control - controlling the dependency (WITH_foo) and controlling the binding (DISABLE_bar).

We are currently using DISABLE_Qwt5 which does nothing, and should use WITH_Qwt5 and/or DISABLE_qwt instead.
Comment 6 Michael Palimaka (kensington) gentoo-dev 2014-12-09 16:40:53 UTC
Thanks for your report. This is now fixed in CVS.

+  09 Dec 2014; Michael Palimaka <kensington@gentoo.org>
+  +smokeqt-4.14.3-r1.ebuild, metadata.xml:
+  Solve automagic dependencies wrt bug #523172.