Bug 522300 – media-libs/mesa-10.2.6: doesn't compile w/ llvm-3.5.0

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Michał Górny 2014-09-07 11:30:20 UTC]

Good news, everyone! We don't have any surprises and llvm-3.5 once again changes API and breaks mesa :).

gallivm/lp_bld_debug.cpp:61:32: fatal error: llvm/ADT/OwningPtr.h: No such file or directory
 #include <llvm/ADT/OwningPtr.h>
                                ^
compilation terminated.
distcc[30926] ERROR: compile gallivm/lp_bld_debug.cpp on localhost failed

Long story short, OwningPtr was removed and now std::unique_ptr from C++11 is supposed to be used. Oh, that also means mesa should be built with -std=c++11 :).

[Comment 1 Michał Górny 2014-09-07 12:06:38 UTC]

Better news, everyone, -9999 builds fine.

[Comment 2 Michał Górny 2014-09-07 12:16:58 UTC]

Relevant commits (in random order):

- 564821c917f4a9d5a0de2ee77b90b0cd85e3d3a6
- f23d1160c24e16ced319d838ed3102b731c2ff03
- cad60420d5ea36a4b6fa2e6c91317f71423aa63e
- 93b6b1fa83a2000f7a60ca12df54c2dd808a87a8
+ b9f501bc6bc52c25bef86a24b49fda4e92fcd924
- 9ceee5f4be09702fc881c922b5ad489cd03c76f8
- 54df6a049110464c4ba2ad97b12b69ede927eca4

Those are relevant but may be unnecessary:

- aad669b1e90491f7c3951016456e8a2660d91a85
- bc86690f137a71a6f1cdcc0393a4b3f181df7240
- 6cc5334e42c29e019b3d2a641034bac0983edfdc
- c7b5a5c4a31f855dcbef0000fa307a5b37448f83
- 877bb52dc95c8504935d48fffe93b5c52bfc7e16

So yes, it may be easier to wait for the next release.

[Comment 3 Michael Mair-Keimberger (iamnr3) 2014-09-07 12:47:57 UTC]

Is mesa-10.2.7 recent enough?
It was released 2 days ago, but i'm not sure if it contains said fixes. I just made a version bump request (bug 522306), maybe this bug should depend on it?

[Comment 4 Michał Górny 2014-09-07 13:07:23 UTC]

(In reply to Michael Mair-Keimberger (iamnr3) from comment #3)
> Is mesa-10.2.7 recent enough?
> It was released 2 days ago, but i'm not sure if it contains said fixes. I
> just made a version bump request (bug 522306), maybe this bug should depend
> on it?

It might be. I didn't notice it because it's not listed on the 'news' page [1]

[1]:http://mesa3d.sourceforge.net/

[Comment 5 Michał Górny 2014-09-07 13:59:02 UTC]

Nope, 10.2.7 is not good enough. However, it already has some of the patches in, so it may be feasible as start point for backporting.

[Comment 6 Michał Górny 2014-09-07 15:55:41 UTC]

Commits not included in 10.2.7:

- 564821c917f4a9d5a0de2ee77b90b0cd85e3d3a6
- cad60420d5ea36a4b6fa2e6c91317f71423aa63e

and from those possibly unnecessary:

- 6cc5334e42c29e019b3d2a641034bac0983edfdc
- c7b5a5c4a31f855dcbef0000fa307a5b37448f83
- 877bb52dc95c8504935d48fffe93b5c52bfc7e16

[Comment 7 Michał Górny 2014-09-07 17:15:46 UTC]

+*mesa-10.2.7 (07 Sep 2014)
+
+  07 Sep 2014; Michał Górny <[e-mail]>
+  +files/mesa-10.2.7-llvm-unique_ptr.patch, +mesa-10.2.7.ebuild:
+  Version bump, requested in bug #522306. Update dependencies from ::x11. Fix
+  llvm-3.5.0 support, bug #522300.

I've only applied the one patch regarding OwningPtr. The other doesn't match the function in 10*, so I omitted it. glxgears work, and that's important!

[Comment 8 David Kredba 2014-09-07 17:33:27 UTC]

Is there +1 in Bugzilla? (I do not mean the vote "button").
"glxgears work, and that's important!" really have to have a plus one IMO :-) .