Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 522158 - net-misc/dhcpcd-6.4.3 with sys-libs/uclibc fails to check for arc4random_uniform()
Summary: net-misc/dhcpcd-6.4.3 with sys-libs/uclibc fails to check for arc4random_unif...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: William Hubbs
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2014-09-04 19:41 UTC by David Flogeras
Modified: 2014-09-11 22:20 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
configure fix for arc4random_uniform check (dhcpcd-6.4.3-uclibc-fix.patch,310 bytes, patch)
2014-09-04 19:41 UTC, David Flogeras
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Flogeras 2014-09-04 19:41:14 UTC
When uClibc is build with UCLIBC_HAS_ARC4RANDOM, it provides the arv4random() function, but NOT the arc4random_uniform() function.  dhcpcd's configure script checks only for the former, but uses both causing a link-time failure.

dhcpcd does have an internal fall-back that provides these two functions.  I am attaching a patch for dhcpcd-6.4.3 which will properly check for both functions, and fall back to internal implementation if it does not find both.

Reproducible: Always
Comment 1 David Flogeras 2014-09-04 19:41:43 UTC
Created attachment 384206 [details, diff]
configure fix for arc4random_uniform check
Comment 2 Roy Marples 2014-09-07 17:26:11 UTC
Fixed upstream here:
http://roy.marples.name/projects/dhcpcd/ci/6bd233bd5a9e564d4e2b8e6500bb12a7a8a55420?sbs=0

Instead of using the whole arc4random, I split arc4random_uniform into it's own compat file so we can use the system arc4random function as well so dhcpcd remains small.
Comment 4 William Hubbs gentoo-dev 2014-09-11 21:30:21 UTC
The patch from comment #1 was added, per Roy, so this is fixed.
Thanks for the report.
Comment 5 David Flogeras 2014-09-11 22:20:52 UTC
Thanks much, look forward to the next release