521440 – net-p2p/{bitcoin-qt,bitcoind}-0.9.2.1: suspicious use of einstall

Bug 521440 - net-p2p/{bitcoin-qt,bitcoind}-0.9.2.1: suspicious use of einstall

Summary: net-p2p/{bitcoin-qt,bitcoind}-0.9.2.1: suspicious use of einstall

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal QA (vote)
Assignee:	Luke-Jr

URL:
Whiteboard:	suspicious-einstall
Keywords:

Depends on:
Blocks:	suspicious-einstall
	Show dependency tree

Reported:	2014-08-28 20:45 UTC by Michał Górny
Modified:	2014-08-29 20:27 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michał Górny archtester

2014-08-28 20:45:21 UTC

Please check whether the use of 'einstall' in this ebuild is actually
needed. From a quick glance at the Makefile, it seems to have proper
support for DESTDIR.

Therefore, if possible please replace the call to 'einstall' with proper
'default' or 'emake DESTDIR="${D}" install'. Thanks.

Comment 1 Michał Górny archtester

2014-08-28 20:46:21 UTC

(merging into one since both packages seem to use the same distfile)

Comment 2 Anthony Basile gentoo-dev

2014-08-29 01:04:25 UTC

I switched to `emake DESTDIR="${D}" install`.  There's not reason to use einstall.

@Luke-jr.  We've now made numerous small changes to the bitcoin ebuilds on the tree.  You'll want to back port them to the overlay so the next time I copy over the next bumps, I would have to make sure these changes were lost.