This kernel module fails to build against kernel 3.16 due to the removal of the SET_ETHTOOL_OPS macro in the following commit: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/include/linux/netdevice.h?id=7ad24ea4bf620a32631d7b3069c3e30c078b0c3e. Reproducible: Always
Created attachment 382828 [details, diff] Set dev->ethtool_ops directly instead of relying on deprecated macro This patch applies the substitution described in the commit that removes the macro from the kernel tree. I've only added preprocessor directives to apply this only for kernels >= 3.16, as I'm averse to applying patches where not strictly necessary.
Created attachment 384732 [details, diff] Complete patch @erikjwaxx: I think your patch is incomplete. Please review my attached patch, taken from https://bugs.launchpad.net/ubuntu/+source/r8168-dkms/+bug/1345548 comment 4 & 5
*** Bug 522796 has been marked as a duplicate of this bug. ***
I do get this : CC [M] /var/tmp/portage/net-misc/batman-adv-2014.2.0/work/batman-adv-2014.2.0/bitarray.o CC [M] /var/tmp/portage/net-misc/batman-adv-2014.2.0/work/batman-adv-2014.2.0/debugfs.o CC [M] /var/tmp/portage/net-misc/batman-adv-2014.2.0/work/batman-adv-2014.2.0/fragmentation.o /var/tmp/portage/net-misc/batman-adv-2014.2.0/work/batman-adv-2014.2.0/fragmentation.c: In function ‘batadv_frag_insert_packet’: /var/tmp/portage/net-misc/batman-adv-2014.2.0/work/batman-adv-2014.2.0/fragmentation.c:187:3: error: implicit declaration of function ‘hlist_add_after’ [-Werror=implicit-function-declaration] hlist_add_after(&frag_entry_curr->list, &frag_entry_new->list); ^ cc1: some warnings being treated as errors scripts/Makefile.build:257: recipe for target '/var/tmp/portage/net-misc/batman-adv-2014.2.0/work/batman-adv-2014.2.0/fragmentation.o' failed make[2]: *** [/var/tmp/portage/net-misc/batman-adv-2014.2.0/work/batman-adv-2014.2.0/fragmentation.o] Error 1 Makefile:1373: recipe for target '_module_/var/tmp/portage/net-misc/batman-adv-2014.2.0/work/batman-adv-2014.2.0' failed make[1]: *** [_module_/var/tmp/portage/net-misc/batman-adv-2014.2.0/work/batman-adv-2014.2.0] Error 2 make[1]: Leaving directory '/usr/src/linux-3.17.7-gentoo' Makefile:53: recipe for target 'all' failed make: *** [all] Error 2 * ERROR: net-misc/batman-adv-2014.2.0::gentoo failed (compile phase): * emake failed * * If you need support, post the output of `emerge --info '=net-misc/batman-adv-2014.2.0::gentoo'`, * the complete build log and the output of `emerge -pqv '=net-misc/batman-adv-2014.2.0::gentoo'`. * The complete build log is located at '/var/log/portage/net-misc:batman-adv-2014.2.0:20141223-011345.log'. * For convenience, a symlink to the build log is located at '/var/tmp/portage/net-misc/batman-adv-2014.2.0/temp/build.log'. * The ebuild environment file is located at '/var/tmp/portage/net-misc/batman-adv-2014.2.0/temp/environment'. * Working directory: '/var/tmp/portage/net-misc/batman-adv-2014.2.0/work/batman-adv-2014.2.0' * S: '/var/tmp/portage/net-misc/batman-adv-2014.2.0/work/batman-adv-2014.2.0' * GNU info directory index is up-to-date. * IMPORTANT: config file '/etc/ppp/options' needs updating. * See the CONFIGURATION FILES section of the emerge * man page to learn how to update config files. This chroot image is located at a hardened amd64 system. Portage 2.2.15 (python 2.7.9-final-0, default/linux/amd64/13.0, gcc-4.8.3, glibc-2.20, 3.17.7-hardened x86_64) ================================================================= System uname: Linux-3.17.7-hardened-x86_64-Intel-R-_Core-TM-_i7-3770_CPU_@_3.40GHz-with-gentoo-2.2 KiB Mem: 16166920 total, 2652468 free KiB Swap: 16777212 total, 16769424 free Timestamp of tree: Mon, 22 Dec 2014 12:15:01 +0000 sh bash 4.3_p30-r1 ld GNU ld (Gentoo 2.24 p1.4) 2.24 app-shells/bash: 4.3_p30-r1 dev-lang/perl: 5.20.1-r3 dev-lang/python: 2.7.9, 3.3.5-r1 sys-apps/baselayout: 2.2 sys-apps/openrc: 0.13.6 sys-apps/sandbox: 2.6-r1 sys-devel/autoconf: 2.69 sys-devel/automake: 1.14.1 sys-devel/binutils: 2.24-r3 sys-devel/gcc: 4.8.3 sys-devel/gcc-config: 1.8 sys-devel/libtool: 2.4.4 sys-devel/make: 4.1-r1 sys-kernel/linux-headers: 3.17-r1 (virtual/os-headers) sys-libs/glibc: 2.20 Repositories: gentoo ACCEPT_KEYWORDS="amd64 ~amd64" ACCEPT_LICENSE="*" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-O2 -pipe" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo" CXXFLAGS="-O2 -pipe" DISTDIR="/usr/portage/distfiles" EMERGE_DEFAULT_OPTS="--nospinner --tree --quiet-build --deep --jobs 1" FCFLAGS="-O2 -pipe" FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync" FFLAGS="-O2 -pipe" GENTOO_MIRRORS="http://mirror.leaseweb.com/gentoo/ http://ftp.uni-erlangen.de/pub/mirrors/gentoo http://ftp-stud.hs-esslingen.de/pub/Mirrors/gentoo/ http://gd.tuwien.ac.at/opsys/linux/gentoo/" LANG="en_US.utf8" LDFLAGS="-Wl,-O1 -Wl,--as-needed" MAKEOPTS="-j1" PKGDIR="/usr/portage/packages" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="" SYNC="rsync://rsync.de.gentoo.org/gentoo-portage" USE="acl amd64 berkdb bindist bzip2 cli cracklib crypt cxx dri fortran gdbm iconv ipv6 mbox mmx modules multilib ncurses nls nptl openmp pam pax_kernel pcre readline session sse sse2 ssl tcpd unicode zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_3" RUBY_TARGETS="ruby19 ruby20" USERLAND="GNU" VIDEO_CARDS="fbdev glint intel mach64 mga nouveau nv r128 radeon savage sis tdfx trident vesa via vmware dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: CPPFLAGS, CTARGET, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON
Should no longer be a problem in 8.039.00. Closing.
Created attachment 433670 [details] emerge-info.txt is the following a dupe ? CC [M] /var/tmp/portage/net-misc/batman-adv-2014.2.0/work/batman-adv-2014.2.0/fragmentation.o /var/tmp/portage/net-misc/batman-adv-2014.2.0/work/batman-adv-2014.2.0/fragmentation.c: In function ‘batadv_frag_insert_packet’: /var/tmp/portage/net-misc/batman-adv-2014.2.0/work/batman-adv-2014.2.0/fragmentation.c:187:3: error: implicit declaration of function ‘hlist_add_after’ [-Werror=implicit-function-declaration] hlist_add_after(&frag_entry_curr->list, &frag_entry_new->list); ^ cc1: some warnings being treated as errors
Created attachment 433672 [details] emerge-history.txt
Created attachment 433674 [details] environment
Created attachment 433676 [details] net-misc:batman-adv-2014.2.0:20160508-160639.log
Toralf, deal with your issue in bug #522796. That was initially marked as a duplicate and then changed back but it's an entirely different package. The summary on this one wasn't changed back, creating some confusion.
