Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 519256 - sys-libs/timezone-data-2014[ef]: installed timezone not updated due to thinko in get_TIMEZONE()
Summary: sys-libs/timezone-data-2014[ef]: installed timezone not updated due to thinko...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Dirkjan Ochtman (RETIRED)
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2014-08-06 20:59 UTC by Daniel Kenzelmann
Modified: 2014-08-08 07:23 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Kenzelmann 2014-08-06 20:59:20 UTC
It looks like the ebuild was rewritten using a separate function get_TIMZONE in the ebuild.

However, the function never returns a value, thus disabling any functionality (like the timezone update).

The patch below sets the return value to a non-zero value in case the zero string length test fails and returns the timezone otherwise which in turn makes the other tests (e.g. in pkg_config()) to hopefully work as expected




--- timezone-data-2014e.ebuild	2014-08-06 22:18:36.720000000 +0200
+++ timezone-data-2014e.ebuild	2014-08-06 22:51:08.071000000 +0200
@@ -101,7 +101,8 @@
 	else
 		tz="FOOKABLOIE"
 	fi
-	[[ -z ${tz} ]]
+	[[ -z ${tz} ]] && return 1
+	echo ${tz}
 }
 
 pkg_preinst() {


Reproducible: Always
Comment 1 SpanKY gentoo-dev 2014-08-08 07:23:14 UTC
should be all set now in the tree; thanks for the report!

Commit message: Fix get_TIMEZONE output
http://sources.gentoo.org/sys-libs/timezone-data/timezone-data-2014e.ebuild?r1=1.3&r2=1.4
http://sources.gentoo.org/sys-libs/timezone-data/timezone-data-2014f.ebuild?r1=1.1&r2=1.2