519058 – x11-libs/gtk+:3 please add support for Mac OS 10.6

Bug 519058 - x11-libs/gtk+:3 please add support for Mac OS 10.6

Summary: x11-libs/gtk+:3 please add support for Mac OS 10.6

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] Library (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo Linux Gnome Desktop Team

URL:
Whiteboard:
Keywords:	Inclusion, PATCH

Depends on:
Blocks:

Reported:	2014-08-04 17:38 UTC by Christoph Junghans (RETIRED)
Modified:	2014-09-02 00:26 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
patch from Mac Ports (patch-backingScaleFactor.diff,935 bytes, patch) 2014-08-04 17:38 UTC, Christoph Junghans (RETIRED)	Details \| Diff
patch from Mac Ports (t.p,1.24 KB, patch) 2014-08-29 22:45 UTC, Christoph Junghans (RETIRED)	Details \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Christoph Junghans (RETIRED) gentoo-dev

2014-08-04 17:38:15 UTC

Created attachment 382256 [details, diff]
patch from Mac Ports

src_compile:
gtkapplication-quartz-menu.c:265: error: incompatible type for argument 1 of 'roundf'
make[4]: *** [libgtk_3_la-gtkapplication-quartz-menu.lo] Error 1

Using the attached patch makes it work. Could we please add that to gtk+:3?

More info:
<https://trac.macports.org/ticket/43283>
<https://bugzilla.gnome.org/show_bug.cgi?id=727366>

Comment 1 Pacho Ramos gentoo-dev

2014-08-15 10:21:14 UTC

I would apply it (with a reference to upstream report to let us track it easier in the future)

Comment 2 Christoph Junghans (RETIRED) gentoo-dev

2014-08-29 22:45:03 UTC

Created attachment 383934 [details, diff]
patch from Mac Ports

Updated patch with more meaningful header!

Comment 3 Pacho Ramos gentoo-dev

2014-09-01 12:22:31 UTC

(In reply to Christoph Junghans from comment #2)
> Created attachment 383934 [details, diff] [details, diff]
> patch from Mac Ports
> 
> Updated patch with more meaningful header!

Feel free to commit please

Comment 4 Christoph Junghans (RETIRED) gentoo-dev

2014-09-02 00:26:46 UTC

+  02 Sep 2014; Christoph Junghans <ottxor@gentoo.org>
+  +files/gtk+-3.12.2-darwin10.6.patch, gtk+-3.12.2.ebuild:
+  fix build on Darwin 10.6 (bug #519058)
+