Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 518210 - =sys-apps/rng-tools-5 version bump
Summary: =sys-apps/rng-tools-5 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: InOverlay, PATCH, UPSTREAM
Depends on:
Blocks:
 
Reported: 2014-07-26 15:29 UTC by Manuel Rüger (RETIRED)
Modified: 2014-11-18 19:56 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to port the (rng-tools-5-fix-textrels-on-PIC-x86.patch,2.96 KB, patch)
2014-10-20 02:58 UTC, Francisco Blas Izquierdo Riera
Details | Diff
Patch to port the PIC fixes (rng-tools-5-fix-textrels-on-PIC-x86.patch,2.96 KB, patch)
2014-10-20 02:59 UTC, Francisco Blas Izquierdo Riera
Details | Diff
Patch to port the PIC fixes (rng-tools-5-fix-textrels-on-PIC-x86.patch,2.97 KB, patch)
2014-10-20 03:08 UTC, Francisco Blas Izquierdo Riera
Details | Diff
Patch to port the PIC fixes (rng-tools-5-fix-textrels-on-PIC-x86.patch,2.62 KB, patch)
2014-10-21 14:37 UTC, Francisco Blas Izquierdo Riera
Details | Diff
Patch to port the PIC fixes v4 (rng-tools-5-fix-textrels-on-PIC-x86.patch,2.57 KB, patch)
2014-10-21 15:11 UTC, Francisco Blas Izquierdo Riera
Details | Diff
Patch to port the PIC fixes v5 (rng-tools-5-fix-textrels-on-PIC-x86.patch,2.61 KB, patch)
2014-10-21 19:28 UTC, Francisco Blas Izquierdo Riera
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rüger (RETIRED) gentoo-dev 2014-07-26 15:29:40 UTC
Version 5 (April 1, 2014):
* Support RDRAND capable systems that don't have AES-NI
* Man page spelling fixes
* Add BUGS document
* Don't use fixed AES key for data reduction
* Platform: Support x32. x86-64 micro-optimizations.
* Fix RDRAND data reduction
* Enable RDSEED instruction
Comment 1 Manuel Rüger (RETIRED) gentoo-dev 2014-08-25 19:43:46 UTC
This patch does not apply anymore, but seems to be unfixed in version 5.
fix-textrels-on-PIC-x86.patch
Comment 2 Francisco Blas Izquierdo Riera gentoo-dev 2014-10-20 02:58:31 UTC
Created attachment 387000 [details, diff]
Patch to port the
Comment 3 Francisco Blas Izquierdo Riera gentoo-dev 2014-10-20 02:59:31 UTC
Created attachment 387002 [details, diff]
Patch to port the PIC fixes

Sorry for previous mess up, resending patch
Comment 4 Francisco Blas Izquierdo Riera gentoo-dev 2014-10-20 03:08:25 UTC
Created attachment 387004 [details, diff]
Patch to port the PIC fixes

Okay previous patch had broken code, that's what you get when you code this late.

Blueness, if you can test the patch as you did with the one for version 4 it'd be nice though this should work (only significant change is that I keep the ebx register as recommended by the ELF ABI).
Comment 5 Anthony Basile gentoo-dev 2014-10-20 22:17:33 UTC
(In reply to Francisco Blas Izquierdo Riera from comment #4)
> Created attachment 387004 [details, diff] [details, diff]
> Patch to port the PIC fixes
> 
> Okay previous patch had broken code, that's what you get when you code this
> late.
> 
> Blueness, if you can test the patch as you did with the one for version 4
> it'd be nice though this should work (only significant change is that I keep
> the ebx register as recommended by the ELF ABI).

This patch is no applying cleanly.  I just bumped rng-tools-4-r7.ebuild to -5- removed the old textrel patch and then tried to apply this one.  No good.

Can you provide both patch and ebuild just in case I'm doing this wrong.
Comment 6 Francisco Blas Izquierdo Riera gentoo-dev 2014-10-21 14:37:28 UTC
Created attachment 387140 [details, diff]
Patch to port the PIC fixes

I messed up with the white spaces when creating the new patch, sorry. I have added an ebuild to my overlay including the fixed patch git://git.overlays.gentoo.org/user/klondike.git
Comment 7 SpanKY gentoo-dev 2014-10-21 14:55:17 UTC
(In reply to Francisco Blas Izquierdo Riera from comment #6)

since the section name has changed, you no longer need to '#undef i686'
Comment 8 Francisco Blas Izquierdo Riera gentoo-dev 2014-10-21 15:11:14 UTC
Created attachment 387142 [details, diff]
Patch to port the PIC fixes v4

(In reply to SpanKY from comment #7)
> (In reply to Francisco Blas Izquierdo Riera from comment #6)
> 
> since the section name has changed, you no longer need to '#undef i686'

True, I should also update the PIC fixing guide on the wiki as the method used by newer versions of gcc has changed (it may use %ecx at times too, the reason why this isn't done here is I wanted something cleaner :) since some of their pointer handling is a bit messy). Added new patch and updated the overlay.
Comment 9 Anthony Basile gentoo-dev 2014-10-21 17:12:58 UTC
(In reply to Francisco Blas Izquierdo Riera from comment #8)
> Created attachment 387142 [details, diff] [details, diff]
> Patch to port the PIC fixes v4
> 
> (In reply to SpanKY from comment #7)
> > (In reply to Francisco Blas Izquierdo Riera from comment #6)
> > 
> > since the section name has changed, you no longer need to '#undef i686'
> 
> True, I should also update the PIC fixing guide on the wiki as the method
> used by newer versions of gcc has changed (it may use %ecx at times too, the
> reason why this isn't done here is I wanted something cleaner :) since some
> of their pointer handling is a bit messy). Added new patch and updated the
> overlay.

This works.  I did a run test and used randstat to check that it stays above the water mark.
Comment 10 Francisco Blas Izquierdo Riera gentoo-dev 2014-10-21 19:28:48 UTC
Created attachment 387158 [details, diff]
Patch to port the PIC fixes v5

Thanks blueness, I added it as tested by you :)
Comment 11 Francisco Blas Izquierdo Riera gentoo-dev 2014-10-21 19:41:26 UTC
I have mailed this to Jeff and Henrique in the hope it gets merged, we'll see what they have to say :)
Comment 12 Francisco Blas Izquierdo Riera gentoo-dev 2014-11-10 21:03:01 UTC
Jeff told me he isn't maintaining the package anymore and told me who to forward the patch to instead. I have done so, I'll come back once HPA or Ricardo Neri answer back.
Comment 13 Manuel Rüger (RETIRED) gentoo-dev 2014-11-18 19:56:47 UTC
*rng-tools-5 (18 Nov 2014)

  18 Nov 2014; Manuel Rüger <mrueg@gentoo.org>
  +files/rng-tools-5-fix-textrels-on-PIC-x86.patch, +rng-tools-5.ebuild,
  -files/2/rngd, -files/2/rngd-conf, -files/rngd-confd-3, -files/rngd-confd-4,
  -files/rngd-initd-3, -files/rngd-initd-4, -rng-tools-2-r1.ebuild,
  -rng-tools-3-r1.ebuild, -rng-tools-3.ebuild, -rng-tools-4-r1.ebuild,
  -rng-tools-4-r5.ebuild, -rng-tools-4-r6.ebuild:
  Version bump. Thanks to klondike for updating the textrel patch. Fixes bug
  #518210. Cleanup old.