Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 517488 - net-misc/iperf-3.0.5 injects -pg -g into CFLAGS / does an additional profiled build
Summary: net-misc/iperf-3.0.5 injects -pg -g into CFLAGS / does an additional profiled...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Netmon project
URL:
Whiteboard:
Keywords: EBUILD, PATCH
Depends on:
Blocks:
 
Reported: 2014-07-19 08:57 UTC by Ronny Boesger
Modified: 2014-07-19 16:00 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild with 2 patches for removing -pg and slotted to "3" (iperf-3.0.5.ebuild,823 bytes, text/plain)
2014-07-19 08:57 UTC, Ronny Boesger
Details
1st patch for removing -pg (iperf3.0.5-nopg-1.patch,467 bytes, patch)
2014-07-19 08:57 UTC, Ronny Boesger
Details | Diff
2nd patch for removing -pg (iperf3.0.5-nopg-2.patch,451 bytes, patch)
2014-07-19 08:57 UTC, Ronny Boesger
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ronny Boesger 2014-07-19 08:57:10 UTC
Created attachment 381034 [details]
ebuild with 2 patches for removing -pg and slotted to "3"

Thanks for committing the iperf-3.0.5 to the tree in #466508 

Here i attach the needed patches for removing "-pg" as this conflicts with "-fomit-frame-pointer". 

Also i attached a ebuild, which does iperf3 put in slot3 (as iperf2 and iperf3 are NOT compatible and should be usable concurrent (the get named correctly, iperf-2 is named "iperf" and iperf-3.X is named "iperf3" as binary.

For me this works at x86 arch without any issues now, hopfefully, we can commit this to tree to help spreed the newer iperf3 :)

Ronny
Comment 1 Ronny Boesger 2014-07-19 08:57:35 UTC
Created attachment 381036 [details, diff]
1st patch for removing -pg
Comment 2 Ronny Boesger 2014-07-19 08:57:47 UTC
Created attachment 381038 [details, diff]
2nd patch for removing -pg
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2014-07-19 12:56:56 UTC
What would be the point of having a SLOTted ebuild? Just because you can?
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2014-07-19 13:02:34 UTC
Comment on attachment 381036 [details, diff]
1st patch for removing -pg

That leaves -g in place.
Comment 5 Jeroen Roovers (RETIRED) gentoo-dev 2014-07-19 13:03:26 UTC
Comment on attachment 381038 [details, diff]
2nd patch for removing -pg

If we're going to patch Makefile.am, then it makes more sense to run automake than to patch Makefile.in as well.
Comment 6 Jeroen Roovers (RETIRED) gentoo-dev 2014-07-19 13:48:01 UTC
Fixed without revision bump except for the SLOTting.
Comment 7 Ronny Boesger 2014-07-19 16:00:48 UTC
(In reply to Jeroen Roovers from comment #3)
> What would be the point of having a SLOTted ebuild? Just because you can?

Thanks for cleanup and integrating.

For the slotted thing, iperf3 is NOT compatible to iperf2, so it makes sense to slot the version 3, so we can have iperf v2 and iperf v3 concurrently installed.

For me, i have clients, which are not aware of the iperf3 protocol and with non-slotted ebuilds here, if have the option to install iperf OR iperf3.

It could also be possible to create a new package named net-misc/iperf3 to seperate this. But I thought, the slotted way is the best option.