Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 516972 - >=sys-fs/e2fsprogs-1.42.9 do not need /etc/mtab for tests
Summary: >=sys-fs/e2fsprogs-1.42.9 do not need /etc/mtab for tests
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-12 16:51 UTC by Nikoli
Modified: 2015-02-22 17:18 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nikoli 2014-07-12 16:51:39 UTC
from /usr/share/doc/e2fsprogs-1.42.10/RELEASE-NOTES.bz2:

E2fsprogs 1.42.9 (December 28, 2013)
====================================
...
Programmer's Notes
------------------
...
Allow the regression test to be run in chrooted environments where
/etc/mtab might be missing.



but sys-fs/e2fsprogs/e2fsprogs-1.42.10.ebuild still has:

pkg_setup() {
	if [[ ! -e ${EROOT}/etc/mtab ]] ; then
		# add some crap to deal with missing /etc/mtab #217719
		ewarn "No /etc/mtab file, creating one temporarily"
		echo "${PN} crap for src_test" > "${EROOT}"/etc/mtab
	fi
}
...
pkg_preinst() {
	if [[ -r ${EROOT}/etc/mtab ]] ; then
		if [[ $(<"${EROOT}"/etc/mtab) == "${PN} crap for src_test" ]] ; then
			rm -f "${EROOT}"/etc/mtab
		fi
	fi
}
Comment 1 SpanKY gentoo-dev 2014-08-05 07:47:39 UTC
should be all set now in the tree; thanks for the report!

Commit message: Drop /etc/mtab check as it is no longer needed
http://sources.gentoo.org/sys-fs/e2fsprogs/e2fsprogs-1.42.10.ebuild?r1=1.12&r2=1.13
http://sources.gentoo.org/sys-fs/e2fsprogs/e2fsprogs-1.42.11.ebuild?r1=1.2&r2=1.3
Comment 2 Arfrever Frehtes Taifersar Arahesis 2014-08-05 09:06:32 UTC
It seems that you forgot to delete obsolete code in pkg_preinst().
Comment 3 Nikoli 2015-02-22 14:20:16 UTC
Reopened per comment 2.