Bug 516228 – =net-misc/dhcpcd-6.4.0 fails with CFLAGS=-fopenmp (as a result of -pthread)

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Sergei Trofimovich (RETIRED) 2014-07-03 19:57:29 UTC]

A user reported the following build failure:
    $ CFLAGS=-fopenmp emerge -1 =dhcpcd-6.4.0

    /usr/bin/x86_64-pc-linux-gnu-gcc  -fopenmp -std=c99 -D_BSD_SOURCE -D_XOPEN_SOURCE=700 -DINET -DINET6 -DPLUGIN_DEV -I./crypt -c if-options.c -o if-options.o
    if-options.c: In function ‘parse_option’:
    if-options.c:641:2: error: #error foo
     #error foo
      ^

The relevant source code does not seem to like it:
    #ifdef _REENTRANT                                       
    #error foo                                       
        struct group grpbuf;                         
    #endif

Thanks!

[Comment 1 Samuli Suominen (RETIRED) 2014-07-03 20:22:50 UTC]

Does dhcpcd's build system append -fopenmp to the build? Because it's not an flag that should be in global flags, it's something package should configure for itself if it has openmp specific code
Propably RESOLVED, INVALID

[Comment 2 Sergei Trofimovich (RETIRED) 2014-07-03 21:28:55 UTC]

Build system does not append it, but our own wiki suggests it:

https://wiki.gentoo.org/wiki/CFLAGS#Graphite_.2F_LTO_.2F_OpenMP

[Comment 3 William Hubbs 2014-07-05 20:37:26 UTC]

I would also vote for resolved/invalid. Our wiki does mention this,
but I would go on the conservative side here since we do not consider it safe.

[Comment 4 Roy Marples 2014-07-07 17:46:46 UTC]

http://roy.marples.name/projects/dhcpcd/ci/ac73ae7ac7f212dac47aacee6ccd47822578d475?sbs=0

Sorry for the error :)

[Comment 5 Roy Marples 2014-07-14 12:03:00 UTC]

dhcpcd-6.4.1 released to fix this

[Comment 6 Roy Marples 2014-07-14 14:13:05 UTC]

and 6.4.2 released to fix another compile error!

[Comment 7 William Hubbs 2014-07-14 15:08:02 UTC]

dhcpcd-6.4.2 is now in the tree.
Thanks, Roy. :-)