Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 515986 - app-portage/elogviewer should yet again install a desktop file
Summary: app-portage/elogviewer should yet again install a desktop file
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Tools (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Paul Varner (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-01 12:47 UTC by CaptainBlood
Modified: 2015-02-04 08:21 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
app-portage/elogviewer-2.3.ebuild (elogviewer-2.3.ebuild,1.40 KB, text/plain)
2015-02-04 07:27 UTC, Ben de Groot (RETIRED) 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description CaptainBlood 2014-07-01 12:47:48 UTC 
Previous version had a menu entry that was appearing in LXDE menu
Can't tell if there is an menu entry implemented somewhere, but in any case it doesn't appear.


Reproducible: Always
Comment 1 CaptainBlood 2014-07-01 12:48:53 UTC 
Sorry I'm talking the latest stable package
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2014-07-01 13:20:48 UTC 
What stable package are you talking about?
Comment 3 CaptainBlood 2014-07-02 05:29:37 UTC 
eix -I elogviewer
[I] app-portage/elogviewer
     Available versions:  0.5.2-r2 2.1-r1 {PYTHON_TARGETS="python2_6 python2_7 python3_2 python3_3"}
     Installed versions:  2.1-r1(09:43:23 23/06/2014)(PYTHON_TARGETS="python2_7 python3_3 -python2_6 -python3_2")
     Homepage:            https://sourceforge.net/projects/elogviewer
     Description:         Elog viewer for Gentoo

So previous was stable 0.5.2-r2 which provides menu entry that is available in LXDE.

Latest stable is 2.1-r1

Hardware is amd-x64
Comment 4 Ben de Groot (RETIRED) gentoo-dev 2015-02-04 05:14:59 UTC 
app-portage/elogviewer-2.3 does not install a desktop file

I'll see if I can whip up a patch
Comment 5 Ben de Groot (RETIRED) gentoo-dev 2015-02-04 07:27:32 UTC 
Created attachment 395496 [details]
app-portage/elogviewer-2.3.ebuild

I'm attaching an improved ebuild.

1) Drop installing of LICENSE file (as per Gentoo policy)
2) Add generation of desktop file
3) Implement readme.gentoo.eclass handling of elog message
4) Tighten up formatting

It would be nice to add a custom icon.
Comment 6 Brian Dolbec (RETIRED) gentoo-dev 2015-02-04 07:48:26 UTC 
Sadly I'm a very poor artist.

Mathias, you any good at creating a custom icon for your elogviewer?
Comment 7 Brian Dolbec (RETIRED) gentoo-dev 2015-02-04 07:54:33 UTC 
Ben, feel free to commit your improvements.  We appreciate your help in improving it.  I know myself, I know little about kde/qt pkgs, and don't do a lot of ebuild work.  Paul is still somewhat in recovery mode... don't want to strain his eyes too much yet.
Comment 8 Ben de Groot (RETIRED) gentoo-dev 2015-02-04 08:21:17 UTC 
Done. Thanks!