Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 515982 - net-misc/openvpn: add systemd USE flag
Summary: net-misc/openvpn: add systemd USE flag
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Dirkjan Ochtman (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-01 11:36 UTC by Peter Volkov (RETIRED)
Modified: 2014-07-03 20:32 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
openvpn-2.3.4-r1.ebuild.patch (openvpn-2.3.4-r1.ebuild.patch,1.07 KB, patch)
2014-07-01 11:36 UTC, Peter Volkov (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Volkov (RETIRED) gentoo-dev 2014-07-01 11:36:56 UTC
Created attachment 380034 [details, diff]
openvpn-2.3.4-r1.ebuild.patch

openvpn upstream added following patch:

http://sourceforge.net/p/openvpn/openvpn-testing/ci/9449e6a9eba30c9ed054f57d630a88c9f087080f/

We need to enable this feature for systemd otherwise it is really hacky to allow systemd to ask for certificate password (see for example https://bbs.archlinux.org/viewtopic.php?id=150440). With this patch systemd on start will request for password and starts service after that.

Please review and apply or give me ok and I'll add it to the tree.
Comment 1 Pacho Ramos gentoo-dev 2014-07-01 15:30:34 UTC
Looks ok to me but, are you sure a USE flag is needed? Looks like it will test for systemd to be running to not break if not :/
Comment 2 Mike Gilbert gentoo-dev 2014-07-01 16:45:38 UTC
It won't work with our systemd package; it is invoking /bin/systemd-ask-password, but we install it as /usr/bin/systemd-ask-password.
Comment 3 Peter Volkov (RETIRED) gentoo-dev 2014-07-03 07:33:12 UTC
(In reply to Mike Gilbert from comment #2)
> it is invoking /bin/systemd-ask-password, but we install it as
> /usr/bin/systemd-ask-password.

This is fixed in ebuild patch :) BTW, do you know, are there any reasons why we do this way?


(In reply to Pacho Ramos from comment #1)
> Looks ok to me but, are you sure a USE flag is needed? Looks like it will
> test for systemd to be running to not break if not :/

Yes, I prefer to be able to build system without systemd traces when needed. Since upstream maintains ./configure switch I see no problems here.


That said committed.
Comment 4 Pacho Ramos gentoo-dev 2014-07-03 17:25:13 UTC
(In reply to Peter Volkov from comment #3)
[...] 
> (In reply to Pacho Ramos from comment #1)
> > Looks ok to me but, are you sure a USE flag is needed? Looks like it will
> > test for systemd to be running to not break if not :/
> 
> Yes, I prefer to be able to build system without systemd traces when needed.
> Since upstream maintains ./configure switch I see no problems here.
> 
> 
> That said committed.

The idea of avoiding systemd USE flags when possible is to not force people to rebuild a lot of packages when switching between inits and, also, to let them boot "better" on either system :)
Comment 5 Mike Gilbert gentoo-dev 2014-07-03 18:05:08 UTC
(In reply to Peter Volkov from comment #3)
> This is fixed in ebuild patch :) BTW, do you know, are there any reasons why
> we do this way?

All of systemd was moved to /usr due to some confusion by Gentoo's udev maintainer. Moving it back to / would be somewhat painful at this point.
Comment 6 Mike Gilbert gentoo-dev 2014-07-03 20:32:06 UTC
I sent a patch to detect this path in configure.

http://sourceforge.net/p/openvpn/mailman/message/32561896/