Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 515116 - net-analyzer/wireshark-1.12.x does not install headers
Summary: net-analyzer/wireshark-1.12.x does not install headers
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Netmon project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-25 18:10 UTC by Rick Farina (Zero_Chaos)
Modified: 2014-07-04 18:37 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rick Farina (Zero_Chaos) gentoo-dev 2014-06-25 18:10:42 UTC
not sure why, but all the .h files installed by previous versions of wireshark are not installed with 1.12.x.  Sorry for lack of investigation, I'm onsite working right now so I'm logging it for someone else or for myself later.
Comment 1 Rick Farina (Zero_Chaos) gentoo-dev 2014-06-25 18:26:13 UTC
       # install headers
        local wsheader
        for wsheader in $( echo $(< debian/wireshark-dev.header-files ) ); do
                insinto /usr/include/wireshark/$( dirname ${wsheader} )
                doins ${wsheader}
        done


looks like debian/wireshark-dev.header-files has been removed in this version so we don't know what to install.
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2014-06-25 22:49:36 UTC
It installs /usr/include/wiretap/wtap.h ?!!!

I guess this is a good thing, since upstream might not want people to develop against unstable APIs. But maybe there is a useful switch in configure.
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2014-06-25 23:02:23 UTC
Or maybe they're switching to cmake for real this time. Oh joy.
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2014-06-25 23:27:34 UTC
There is a dumpabi target that might be useful.
Comment 5 Rick Farina (Zero_Chaos) gentoo-dev 2014-06-26 00:51:46 UTC
Stable version:

zero@ozzie ~ % qlist wireshark | grep -c "/usr/include/" 
606


compared to the 1 header installed by 1.12.x

Honestly I'm fine with just recursively installing all the header files (since that pretty much looks like what debian was doing anyway.

Would this be acceptable, Jer?
Comment 6 Jeroen Roovers (RETIRED) gentoo-dev 2014-06-26 02:20:35 UTC
With this change:

RCS file: /var/cvsroot/gentoo-x86/net-analyzer/wireshark/wireshark-1.12.0_rc2.ebuild,v
retrieving revision 1.3
diff -u -B -r1.3 wireshark-1.12.0_rc2.ebuild
--- wireshark-1.12.0_rc2.ebuild 20 Jun 2014 13:51:07 -0000      1.3
+++ wireshark-1.12.0_rc2.ebuild 26 Jun 2014 02:11:47 -0000
@@ -61,6 +61,7 @@
                doc-pdf? ( dev-java/fop )
                www-client/lynx
        )
+       dev-util/abi-compliance-checker
        >=virtual/perl-Pod-Simple-3.170.0
        sys-devel/bison
        sys-devel/flex
@@ -164,10 +165,11 @@
                doc/{randpkt.txt,README*}

        # install headers
-       local wsheader
-       for wsheader in $( echo $(< debian/wireshark-dev.header-files ) ); do
-               insinto /usr/include/wireshark/$( dirname ${wsheader} )
-               doins ${wsheader}
+       emake dumpabi
+       local headerdir
+       for headerdir in filetap wiretap epan wsutil; do
+               insinto /usr/include/wireshark/${headerdir}
+               doins -r ${headerdir}/abi-check-headers/*.h
        done

        #with the above this really shouldn't be needed, but things may be looking in wiretap/ instead of wireshark/wiretap/

Apart from the dubious need for abi-compliance-checker[1] to get a useful list of headers that upstream is interested in, I get:

find ../../image/ | sort | grep '\.h$' | wc -l
118

It's entirely unclear which of those we really need or if that's enough. It is a lot less than Debian apparently liked to have. A good starting point would be to look at packages that build against wireshark's libraries and see what headers those use.


[1] I could replace that dependency and sed out s|abi-compliance-checker|true|g since we shouldn't care about ABI compliance after the release.
Comment 7 Jeroen Roovers (RETIRED) gentoo-dev 2014-06-28 21:48:05 UTC
*wireshark-1.12.0_rc2-r1 (28 Jun 2014)
 
  28 Jun 2014; Jeroen Roovers <jer@gentoo.org> -wireshark-1.12.0_rc2.ebuild,
  +wireshark-1.12.0_rc2-r1.ebuild:
  Install headers as previously read from debian/wireshark-dev.header-files
  (bug #515116).
Comment 8 Rick Farina (Zero_Chaos) gentoo-dev 2014-07-04 18:10:19 UTC
The headers needed for libbtbb are not being installed. This is the same error I had that caused me to open this bug in the first place.  Please bother to comment on the bug next time you close it.
Comment 9 Jeroen Roovers (RETIRED) gentoo-dev 2014-07-04 18:37:55 UTC
Stop jumping to silly conclusions.

This bug is fixed because wireshark-1.12 should now install all or most headers that 1.10 does.

You haven't even established yet that bug #516178 has anything to do with this one, so this bug stays fixed. If it turns out that bug #516178 is caused by yet another missing wireshark header, then we can fix /that/ problem /there/.