Bug 513860 – net-analyzer/wireshark-1.12.0_rc2 on ARM - expert.c:392:2: error: incompatible type for argument 8 of 'expert_set_info_vformat'

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Steev Klimaszewski (RETIRED) 2014-06-19 14:39:14 UTC]

There are 2 uses of va_list in epan/expert.c in 1.12.0_rc2+ of wireshark that are set to NULL, this causes build failures on ARM.

Reproducible: Always




Patch to be attached soon, I'm just double checking that it applies and that wireshark 1.12.0_rc2 compiles with it on ARM here.

[Comment 1 Jeroen Roovers (RETIRED) 2014-06-19 18:09:13 UTC]

1) Please post your `emerge --info' output in a comment.
2) Please attach the entire build log to this bug report.

[Comment 2 Steev Klimaszewski (RETIRED) 2014-06-19 18:33:47 UTC]

Created attachment 379272 [details, diff]
Patch to fix compilation on ARM

Please test this on other architectures, I know it compiles and runs on ARM, but I'm not entirely sure I fixed it correctly.  The function that is called only seems to have those 2 uses being NULL, and there's a third where it's actually used.  If I can figure out how to actually get this uploaded to wireshark's gerrit, I plan to push it upstream, but their docs are so outdated for contributing patches, that it makes almost no sense.  They have a link to essentially the man page for git, and the other link is simply to the code review site.  If anyone happens to know the correct method, please let me know as it's still not fixed in master/1.12 branch in their git.

[Comment 3 Steev Klimaszewski (RETIRED) 2014-06-19 18:39:04 UTC]

Created attachment 379274 [details]
Failure portion of the build log

Sorry Jer, I was in the middle of transit.  Attached is the bit of the build log that shows the error.

[Comment 4 Steev Klimaszewski (RETIRED) 2014-06-19 18:39:38 UTC]

Portage 2.2.8-r1 (default/linux/arm/13.0/desktop, gcc-4.7.4, glibc-2.17, 3.8.11 armv7l)
=================================================================
System uname: Linux-3.8.11-armv7l-with-gentoo-2.2
KiB Mem:     2050148 total,   1211220 free
KiB Swap:          0 total,         0 free
Timestamp of tree: Thu, 19 Jun 2014 01:00:01 +0000
ld GNU ld (GNU Binutils) 2.23.2
app-shells/bash:          4.2_p45
dev-lang/python:          2.7.6, 3.3.3
dev-util/cmake:           2.8.12.2
dev-util/pkgconfig:       0.28
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.12.4
sys-apps/sandbox:         2.6-r1
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.13.4
sys-devel/binutils:       2.23.2
sys-devel/gcc:            4.7.4
sys-devel/gcc-config:     1.7.3
sys-devel/libtool:        2.4.2
sys-devel/make:           3.82-r4
sys-kernel/linux-headers: 3.13 (virtual/os-headers)
sys-libs/glibc:           2.17
Repositories: gentoo arm_support
ACCEPT_KEYWORDS="arm"
ACCEPT_LICENSE="* -@EULA"
CBUILD="armv7a-hardfloat-linux-gnueabi"
CFLAGS="-O2 -march=armv7-a -mtune=cortex-a15 -mfpu=neon -mfloat-abi=hard"
CHOST="armv7a-hardfloat-linux-gnueabi"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -march=armv7-a -mtune=cortex-a15 -mfpu=neon -mfloat-abi=hard"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="-j3 --load-average=8"
FCFLAGS="-O2 -march=armv7-a -mtune=cortex-a15 -mfpu=neon -mfloat-abi=hard"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync"
FFLAGS="-O2 -march=armv7-a -mtune=cortex-a15 -mfpu=neon -mfloat-abi=hard"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j3 -l8"
PKGDIR="/usr/portage/packages"
PORTAGE_BUNZIP2_COMMAND="pbunzip2 --ignore-trailing-garbage=1"
PORTAGE_BZIP2_COMMAND="pbzip2"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_EXTRA_OPTS="-4"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/home/steev/sandbox/github/arm"
SYNC="rsync://xu/gentoo-portage"
USE="X a52 aac acl alsa apng arm bash-completion berkdb bluetooth branding bzip2 cairo cdda cdr cli colord cracklib crypt cups cxx dbus dri dts dvd dvdr egl emboss encode evo exif fam firefox flac fortran gdbm gif gles1 gles2 gnome-keyring gstreamer gtk iconv introspection ipv6 jpeg lame lcms libkms libnotify libsecret mad mng modules mp3 mp4 mpeg ncurses neon nls nptl ogg opengl openmp opus pam pango pcre pdf png policykit ppds pulseaudio readline session spell ssl startup-notification svg systemd tcpd theora tiff truetype udev udisks unicode upower usb vala vorbis wxwidgets xcb xml xv xvid zlib" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="cmt evdev synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_3" RUBY_TARGETS="ruby19 ruby20" USERLAND="GNU" VIDEO_CARDS="armsoc exynos fbdev" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, INSTALL_MASK, LC_ALL, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, USE_PYTHON

[Comment 5 Jeroen Roovers (RETIRED) 2014-06-19 19:03:40 UTC]

Comment on attachment 379272 [details, diff]
Patch to fix compilation on ARM

Looks good to me. Having "unused" nicely sets it apart from all the functions where "va_list ap" is used instead.

Did you send it upstream yet?

[Comment 6 Steev Klimaszewski (RETIRED) 2014-06-19 19:26:23 UTC]

(In reply to Jeroen Roovers from comment #5)
> Comment on attachment 379272 [details, diff] [details, diff]
> Patch to fix compilation on ARM
> 
> Looks good to me. Having "unused" nicely sets it apart from all the
> functions where "va_list ap" is used instead.
> 
> Did you send it upstream yet?

Not yet - I've just gotten home from traveling, and moving some furniture.  And I'm still trying to sort out how to do it exactly..  Their documentation for submitting to Gerrit still points to using SVN but they use git now.  I may try just throwing the patch at their mailing list and seeing if anyone is willing to accept it that way.

[Comment 7 Steev Klimaszewski (RETIRED) 2014-06-19 20:03:41 UTC]

Filed upstream at URL.

[Comment 8 Steev Klimaszewski (RETIRED) 2014-06-19 22:02:15 UTC]

And the patch is in their gerrit, so hopefully I don't need to modify it too much, and will get into 1.12

https://code.wireshark.org/review/#/c/2464/

[Comment 9 Jeroen Roovers (RETIRED) 2014-07-23 09:10:27 UTC]

Fixed in 1.12_rc3.