Bugzilla Bug 51377

hi stu,

just tested webapp-config-1.9 and while installing net-www/phpBB-2.0.8a-r1
i get the following errors:

 *     Installing from /usr/share/webapps/phpBB/2.0.8a-r1/hostroot
/usr/sbin/webapp-config: line 2277: /bin: is a directory
/usr/sbin/webapp-config: line 2277: /boot: is a directory
/usr/sbin/webapp-config: line 2277: /dev: is a directory
/usr/sbin/webapp-config: line 2277: /etc: is a directory
/usr/sbin/webapp-config: line 2277: /home: is a directory
/usr/sbin/webapp-config: line 2277: /lib: is a directory
/usr/sbin/webapp-config: line 2277: /mnt: is a directory
/usr/sbin/webapp-config: line 2277: /news: is a directory
/usr/sbin/webapp-config: line 2277: /opt: is a directory
/usr/sbin/webapp-config: line 2277: /proc: is a directory
/usr/sbin/webapp-config: line 2277: /root: is a directory
/usr/sbin/webapp-config: line 2277: /sbin: is a directory
/usr/sbin/webapp-config: line 2277: /sys: is a directory
/usr/sbin/webapp-config: line 2277: /tmp: is a directory
/usr/sbin/webapp-config: line 2277: /usr: is a directory
/usr/sbin/webapp-config: line 2277: /var: is a directory

the code in /usr/sbin/webapp-config is the following:

        for x in `echo ${MY_HOOKSCRIPTDIRS}/*` ; do
                # only run the executable scripts, just in case someone
                # has somehow dropped a README-type file in there
                                                                                
                if [ -e "$x" ]; then
                        $x "$1"
                fi
        done

i haven't found a place where MY_HOOKSCRIPTDIRS is declared. that's leading
to this.

sven

Portage 2.0.50-r6 (default-x86-2004.0, gcc-3.3.2, glibc-2.3.2-r9, 2.6.3-G-R1)
=================================================================
System uname: 2.6.3-G-R1 i686 AMD Athlon(tm) XP 2200+
Gentoo Base System version 1.4.10
ccache version 2.3 [enabled]
Autoconf: sys-devel/autoconf-2.58-r1
Automake: sys-devel/automake-1.8.3
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CFLAGS="-O3 -pipe -fomit-frame-pointer -fprefetch-loop-arrays -funroll-loops -ff orce-addr -fmove-all-movables -march=athlon-xp -mmmx -msse -m3dnow"
CHOST="i686-pc-linux-gnu"
COMPILER="gcc3"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3/share/config /usr/share/ config /var/bind /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-O3 -pipe -fomit-frame-pointer -fprefetch-loop-arrays -funroll-loops - fforce-addr -fmove-all-movables -march=athlon-xp -mmmx -msse -m3dnow -Wno-deprec ated"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs ccache sandbox"
GENTOO_MIRRORS="http://ftp.uni-erlangen.de/pub/mirrors/gentoo ftp://trumpetti.at m.tut.fi/gentoo/ http://ftp.easynet.nl/mirror/gentoo/"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://gentoo.mirror.at.stealer.net/gentoo-portage"
USE="3dnow X509 acl apache2 berkdb crypt cscope curl evms2 exiscan exiscan-acl f lash gd gd-external gdbm gif gpm imagemagick imap imlib innodb java jpeg kerbero s lcms libg++ libwww lmtp maildir mbox mmx mysql ncurses nls nocd pam passfile p dflib perl pg-hier php png postgres python readline ruby sasl skey slang snmp ss e ssl tcpd tiff truetype wmf x86 xfs xml xml2 xv zlib"

Run etc-update, and merge in the changes to /etc/vhosts/webapp-config.  This
variable should be defined in there.

Best regards,
Stu

in /etc/vhosts/webapp-config:
MY_HOOKSCRIPTSDIR="${MY_APPDIR}/hooks"

in /usr/sbin/webapp-config:
for x in `echo ${MY_HOOKSCRIPTDIRS}/*` ; do

see the difference? :)

I do now ;-(  Look out for a -r1 appearing in Portage later this evening.

Best regards,
Stu

cheer up ;) i would replace it with

if [ -f "$x" -a -x "$x" ]; then

as -e also matches directories and files with aren't +x. i'll test -r1 later
and report back.

Fixes are in Portage, as -r1.  Should appear on your local rsync mirror in
about an hour.  Please give it a test.

Best regards,
Stu

Stu, you bumped the revision, but the ebuild uses the same tarball as 1.9.

Sven

Doh.  I didn't upload the tarball either ;-)  Give it another hour for the
rsync mirrors to pick it up, and we'll try again.

Best regards,
Stu

>>> Install webapp-config-1.9-r1 into /var/tmp/portage/webapp-config-1.9-r1/image/ category net-www
>>> dosbin: making sbin/webapp-config executable...
install: cannot stat `sbin/webapp-config': No such file or directory
cp: cannot stat `lib/*': No such file or directory
cp: cannot stat `config/webapp-config': No such file or directory
/usr/lib/portage/bin/dodoc: examples/phpmyadmin-2.5.4-r1.ebuild does not exist.
/usr/lib/portage/bin/dodoc: AUTHORS.txt does not exist.
/usr/lib/portage/bin/dodoc: README.txt does not exist.
/usr/lib/portage/bin/dodoc: TODO.txt does not exist.
/usr/lib/portage/bin/dodoc: CHANGES.txt does not exist.
/usr/lib/portage/bin/dodoc: examples/postinstall-en.txt does not exist.
doman: doc/webapp-config.5 does not exist.
doman: doc/webapp-config.8 does not exist.
doman: doc/webapp.eclass.5 does not exist.
man:
prepallstrip:
strip:
>>> Completed installing into /var/tmp/portage/webapp-config-1.9-r1/image/

>>> Merging net-www/webapp-config-1.9-r1 to /
--- /etc/
--- /etc/vhosts/
--- /usr/
--- /usr/lib/
--- /usr/lib/webapp-config/
--- /usr/sbin/
--- /usr/share/
--- /usr/share/webapps/
>>> Safely unmerging already-installed instance...


should be S=${WORKDIR}/${PF} for this one ;)

Created an attachment (id=31696) [edit]
webapp-config.patch

-f implies -e and as we're going to execute that file we should check
that is executeable.

so, bugs.g.o is back again. :)

-r2 works for me as expected, i'll close this one