Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 511748 - app-admin/rsyslog-7.6.3: bashism in init script
Summary: app-admin/rsyslog-7.6.3: bashism in init script
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Server (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Ultrabug
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2014-05-29 03:36 UTC by consus
Modified: 2014-06-02 11:55 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
This patch fixes the issue (rsyslog.patch,380 bytes, patch)
2014-05-29 03:38 UTC, consus
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description consus 2014-05-29 03:36:27 UTC
With POSIX shell implementation set to dash rsyslog'd init script will die with syntax errors.

Stderr:

  /lib64/rc/sh/gendepends.sh: 15: /etc/init.d/rsyslog: Syntax error: "(" unexpected
  /lib64/rc/sh/runscript.sh: 15: /etc/init.d/rsyslog: Syntax error: "(" unexpected

Reproducible: Always

Steps to Reproduce:
1. emerge app-admin/rsyslog-7.6.3
2. eselect sh set dash
3. rc-service rsyslog start
Actual Results:  
Rsyslog died with syntax errors.

Expected Results:  
Rsyslog should have started.

Portage 2.2.10 (default/linux/amd64/13.0/no-multilib, gcc-4.8.2, glibc-2.19, 3.14.2-gentoo x86_64)
=================================================================
System uname: Linux-3.14.2-gentoo-x86_64-Intel-R-_Core-TM-_i3-2310M_CPU_@_2.10GHz-with-gentoo-2.2
KiB Mem:    10128624 total,   5697504 free
KiB Swap:    2097148 total,   2097148 free
Timestamp of tree: Wed, 28 May 2014 12:30:01 +0000
ld GNU ld (GNU Binutils) 2.24
app-shells/bash:          4.2_p47
dev-java/java-config:     2.2.0
dev-lang/python:          2.7.6-r1, 3.3.5, 3.4.0
dev-util/cmake:           2.8.12.2-r1
dev-util/pkgconfig:       0.28-r1
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.12.4
sys-apps/sandbox:         2.6-r1
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.11.6, 1.14.1
sys-devel/binutils:       2.24-r2
sys-devel/gcc:            4.8.2
sys-devel/gcc-config:     1.8
sys-devel/libtool:        2.4.2-r1
sys-devel/make:           4.0-r1
sys-kernel/linux-headers: 3.14 (virtual/os-headers)
sys-libs/glibc:           2.19
Repositories: gentoo local-serenity lobotomy udev
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe"
DISTDIR="/var/tmp/portage/distfiles"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
INSTALL_MASK="     /etc/systemd     /lib/systemd     /lib32/systemd     /lib64/systemd     /usr/lib/systemd     /usr/lib32/systemd     /usr/lib64/systemd     /var/lib/transmission     /var/log/transmission "
LANG="en_GB.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j5 -l5"
PKGDIR="/var/tmp/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/overlays/local /usr/overlays/lobotomy /usr/overlays/udev"
USE="X aac acpi alsa amd64 berkdb bzip2 cleartype cli corefonts cpudetection cracklib crypt cue curl cxx device-mapper dri exif flac gdbm gif gpg gpm iconv idn imlib inotify ipv6 jpeg jpeg2k lame lzma mad mbox mmx modules mp3 mp4 mpg123 ncurses nptl ogg opengl openmp pam pcre png readline sasl session sse sse2 sse4_1 ssh ssl ssse3 taglib theora threads tiff truetype unicode vim-syntax vorbis wavpack wma x264 xz zip zlib zsh-completion" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" DRACUT_MODULES="crypt lvm" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="evdev synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="en ru" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_3" QEMU_SOFTMMU_TARGETS="x86_64 i386" RUBY_TARGETS="ruby19 ruby20" USERLAND="GNU" VIDEO_CARDS="intel i915 i965 vesa" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, SYNC, USE_PYTHON
Comment 1 consus 2014-05-29 03:38:21 UTC
Created attachment 377800 [details, diff]
This patch fixes the issue
Comment 2 Thomas Deutschmann (RETIRED) gentoo-dev 2014-05-29 06:06:33 UTC
Good catch, thanks.

@Ultrabug: I am fine with this patch.
Comment 3 Ultrabug gentoo-dev 2014-06-02 11:55:59 UTC
Indeed good catch, thx guys !

+*rsyslog-7.6.3-r1 (02 Jun 2014)
+
+  02 Jun 2014; Ultrabug <ultrabug@gentoo.org> -rsyslog-7.6.3.ebuild,
+  +rsyslog-7.6.3-r1.ebuild, files/7-stable/rsyslog.initd-r1:
+  fix #511748 thx to consus
+