Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 511410 - app-backup/snapper - pkg_postinst() contains confusing instructions
Summary: app-backup/snapper - pkg_postinst() contains confusing instructions
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Dainius Masiliūnas
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-24 23:15 UTC by Nils Freydank
Modified: 2014-05-30 10:00 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nils Freydank 2014-05-24 23:15:07 UTC
First of all: Thanks for the ebuilds!

Anyway, the pkg_postinst() is quite confusing. It says you should create a _directory_ for snapshots. Instead it seems essential that if you use BTRFS $SUBVOLUME/.snapshot is a BTRFS-snapshot itself.
I don't know the behaviour at ext4 but I suggest to use snapper for creating configs itself:

pkg_postinst() {
	elog "In order to use Snapper, you need to set up"
	elog "at least one config first. To do this, run:"
	elog "snapper create-config <subvolume>"
	elog "For more information, see man (8) snapper or"
	elog "http://snapper.io/documentation.html"
}

Reproducible: Always
Comment 1 Dainius Masiliūnas 2014-05-25 12:11:44 UTC
True, although .snaphots should be a subvolume, not a snapshot ;) 

But yes, I wasn't aware of create-config setting it all up automatically when I wrote the ebuild, so your suggestion makes sense.

Lan, can you update the ebuild with this? I'm not really sure what the ebuild update process is supposed to be, since I wasn't the one who submitted the file to the main repository...
Comment 2 Nils Freydank 2014-05-27 17:20:13 UTC
(In reply to Dainius Masiliūnas from comment #1)
> True, although .snaphots should be a subvolume, not a snapshot ;) 

Oops, my fault. Of course a subvolume, containing the snapshots ;D

> But yes, I wasn't aware of create-config setting it all up automatically
> when I wrote the ebuild, so your suggestion makes sense.
> 
> Lan, can you update the ebuild with this? I'm not really sure what the
> ebuild update process is supposed to be, since I wasn't the one who
> submitted the file to the main repository...

Thx.
Comment 3 Yixun Lan archtester gentoo-dev 2014-05-30 10:00:28 UTC
+  30 May 2014; Yixun Lan <dlan@gentoo.org> snapper-0.2.2-r1.ebuild,
+  snapper-9999.ebuild:
+  fix bug #511410, thanks Dainius Masiliūnas,holgersson; combine minor
+  improvement suggested by @jlec
+

fixed without revision bump, thanks all