Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 511040 - app-misc/livecd-tools-2.0.3 /etc/init.d/firmware has wrong absolute path to /sbin/udevadm which moved to /bin/udevadm in >=udev-212
Summary: app-misc/livecd-tools-2.0.3 /etc/init.d/firmware has wrong absolute path to /...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Release Media
Classification: Unclassified
Component: LiveCD/DVD/USB (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo LiveCD Package Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 505962
  Show dependency tree
 
Reported: 2014-05-22 15:47 UTC by Ben Kohler
Modified: 2014-05-31 20:20 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
screenshot of minimal iso boot errors (livecd-tools-errors.png,24.80 KB, image/png)
2014-05-22 15:47 UTC, Ben Kohler
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Kohler gentoo-dev 2014-05-22 15:47:49 UTC
Created attachment 377448 [details]
screenshot of minimal iso boot errors

Starting with udev-212, udevadm has moved to /bin.  livecd-tools' /etc/init.d/firmware has an absolute path to /sbin/udevadm so this service fails, which also prevents services hwsetup, gpm-pre, and autoconfig from starting on our livecds. 

This is affecting our minimal isos starting with install-amd64-minimal-20140515.iso.  I'm not sure of the extent of the "damage" but I believe hwsetup and autoconfig are fairly important.
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2014-05-22 16:16:29 UTC
udevadm moved to /bin many versions ago, but we had /sbin compability symlink in place for an year to give time for packages to migrate

current udev -> /bin
old udev -> /sbin
current eudev -> /sbin, with /bin compat symlink
old eudev -> /sbin
current systemd -> /usr/bin, no compat symlinks of anykind

so fix should be in form of using `type -p` or searching all of /bin /sbin /usr/bin /usr/sbin

so please, don't just change /sbin to /bin to get this bug done with, fix it all the way instead to cover future moves by not hardcoding path :)

thanks!
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2014-05-22 16:25:15 UTC
oh, like that?

diff --git a/init.d/firmware b/init.d/firmware
index c5534b9..a537099 100755
--- a/init.d/firmware
+++ b/init.d/firmware
@@ -20,6 +20,6 @@ start() {
                eend 0
                eoutdent
        fi
-       [ -x /sbin/udevadm ] && /sbin/udevadm trigger
+       [ type -P udevadm ] && udevadm trigger
        eend $?
 }
Comment 3 Rick Farina (Zero_Chaos) gentoo-dev 2014-05-22 16:41:51 UTC
We are dropping the firmware stuff from livecd-tools as it is no longer used:

http://git.overlays.gentoo.org/gitweb/?p=proj/livecd-tools.git;a=commitdiff;h=c692089f622e4f89d62987215e8a32cccf54aa8a

Thanks for the bug report, but the suggested fix is literally a fix to an unused code block.  Releng eliminated the firmware tarball a while ago and now livecd-tools is catching up.

I'll close this after a point release of livecd-tools is made to fix this.
Comment 4 Rick Farina (Zero_Chaos) gentoo-dev 2014-05-22 16:53:12 UTC
Releng is happy with the current state of git and would like a release.  I've never done a release for livecd-tools, but I can do it if no one else volunteers.
Comment 5 Rick Farina (Zero_Chaos) gentoo-dev 2014-05-31 20:18:24 UTC
Since no one else volunteered, I've cut a release of livecd-tools that fixes the issue.  Please let myself or releng in general know if there are any issues.