Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 510918 - =media-libs/opus-1.1: build fails on Gentoo/FreeBSD
Summary: =media-libs/opus-1.1: build fails on Gentoo/FreeBSD
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: FreeBSD (show other bugs)
Hardware: All FreeBSD
: Normal normal (vote)
Assignee: Gentoo/BSD Team
URL: http://git.xiph.org/?p=opus.git;a=pat...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: nonbash
  Show dependency tree
 
Reported: 2014-05-21 11:03 UTC by Yuta SATOH
Modified: 2015-05-28 10:07 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
opus-1.1.ebuild (opus-1.1.ebuild,1.23 KB, text/plain)
2014-10-08 00:39 UTC, unlord
Details
files/1.1-fix-configure.ac-shell-bug.patch (1.1-fix-configure.ac-shell-bug.patch,545 bytes, patch)
2014-10-08 00:40 UTC, unlord
Details | Diff
patch for opus-1.1.ebuild (510918.patch,367 bytes, patch)
2014-10-21 12:10 UTC, Yuta SATOH
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuta SATOH 2014-05-21 11:03:44 UTC
The following message is displayed and fails to compile.

<snip>
checking for C/C++ restrict keyword... __restrict
checking for C99 variable-size arrays... yes
checking for cos in -lm... yes
/var/tmp/portage/media-libs/opus-1.1/work/opus-1.1/configure: ${inline_optimization:0...}: Bad substitution

!!! Please attach the following file when seeking support:
!!! /var/tmp/portage/media-libs/opus-1.1/work/opus-1.1-amd64_fbsd/config.log



This issue has been fixed in the upstream. (please see URL)
Please add the patch.
Comment 1 unlord 2014-10-08 00:39:25 UTC
Created attachment 386206 [details]
opus-1.1.ebuild
Comment 2 unlord 2014-10-08 00:40:11 UTC
Created attachment 386208 [details, diff]
files/1.1-fix-configure.ac-shell-bug.patch
Comment 3 unlord 2014-10-08 00:41:46 UTC
Can you please test this ebuild on your amd64_fbsd system and confirm it fixes the problem.  You did not specify what non-bash shell you were using so I could not reproduce this bug and test on my system.
Comment 4 Yuta SATOH 2014-10-21 12:10:25 UTC
Created attachment 387130 [details, diff]
patch for opus-1.1.ebuild

(In reply to unlord from comment #3)
> Can you please test this ebuild on your amd64_fbsd system and confirm it
> fixes the problem.  You did not specify what non-bash shell you were using
> so I could not reproduce this bug and test on my system.

Thank you for your comment.
I tested your patch (Attachment 386208 [details, diff]). I've confirmed that it works correctly.

eautoreconf required in the ebuild. I will attach the patch.
Comment 5 Paweł Stankowski 2014-11-12 23:40:31 UTC
Bump.

Can someone take a look on that? Patches are supplied and were tested, so maybe that's time to stabilize opus-1.1?
Comment 6 Alexander Tsoy 2015-05-12 10:30:01 UTC
Same problem with other non-bash shells like dash. Please make this bug block the tracker bug 526268
Comment 7 Ben de Groot (RETIRED) gentoo-dev 2015-05-28 10:07:57 UTC
Patch applied in opus-1.1.ebuild. No revbump since this fixes a build time failure.