Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 51027 - mppe mppc patches for ppp not current
Summary: mppe mppc patches for ppp not current
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: Gentoo Dialup Developers
URL:
Whiteboard:
Keywords:
: 47991 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-05-14 04:28 UTC by Tomasz Orzechowski
Modified: 2004-09-27 06:55 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
enable mppe-mppc support to ppp with a USE option (ppp-2.4.2-r2-mppe-mppc.patch,1.54 KB, patch)
2004-09-16 07:25 UTC, José Mata Fernandes
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Orzechowski 2004-05-14 04:28:47 UTC
The ppp-2.4.2-r2 package contains an old version of mppe/mppc patches obtained from http://www.polbox.com/h/hs001/

The current version is 1.0 and the ebuild contains 0.82

The ebuild should be upgraded to the current patches before it leaves ~x86

Reproducible: Always
Steps to Reproduce:
Comment 1 Michal Suchanek 2004-08-02 03:39:53 UTC
btw mppc is patented
see ppp readme
Comment 2 Lars Geiger 2004-08-16 16:12:51 UTC
On 2004-08-15, this patch has reached version 1.1. It's located at http://www.polbox.com/h/hs001/ppp-2.4.2-stdopt-mppe-mppc-1.1.patch.gz

Although I'm not really sure if Gentoo should use this patch for ppp by default at all. Most people won't need it, so why risk any legal trouble if it's not used by the majority anyway? And those who actually need it can easily put an ebuild into the overlay and add that patch there.
Comment 3 José Mata Fernandes 2004-09-16 03:44:00 UTC
The patch in the ebuild is obsolete, so, i suspect no one will use that by default. Whoever wants to add mppe/mppc support in ppp, will download and patch the most recent patch found in the site.

What i think should be made:
1- Update the patch version on ppp (there is allready the legal essue, why have the an obsolete version?)

    OR

2- Add a USE flag for mppe. Since there is the module in kernel too, add the USE flag support in portage to: ppp, gentoo-sources and gentoo-dev-sources. I will try to make a ebuild patch for ppp (it will be my first one...).
Comment 4 José Mata Fernandes 2004-09-16 07:25:53 UTC
Created attachment 39699 [details, diff]
enable mppe-mppc support to ppp with a USE option

I think this should go into portage. About the patent issue present here, its a
user decision to USE="mppe-mppc", maybe someone can add a notice when the build
finish, just to make sure the user knows what he/she is doing.

patch instructions:

cp ppp-2.4.2-r2-mppe-mppc.patch /usr/portage/net-dialup/ppp
cd /usr/portage/net-dialup/ppp
patch -p1 < ppp-2.4.2-r2-mppe-mppc.patch

download ppp-2.4.2-mppe-mppc-1.1.patch.gz from http://www.polbox.com/h/hs001/
cp ppp-2.4.2-mppe-mppc-1.1.patch.gz /usr/portage/net-dialup/ppp/files/2.4.2

USE="mppe-mppc" emerge ppp

-------------

Offcorse, anytime one emerge sync, the process must be repeated. This can be
fixed making a custom ebuild for ppp and place it in /usr/local/portage.

Hope this helps (it is helping some gentoo friends here in Portugal)
Comment 5 Bjarke Istrup Pedersen (RETIRED) gentoo-dev 2004-09-26 11:48:14 UTC
I vote for this one too, it's very usefull, I like the idea of the use flag, since people worried about the patent can disable it.
Comment 6 Heinrich Wendel (RETIRED) gentoo-dev 2004-09-27 04:00:58 UTC
*** Bug 47991 has been marked as a duplicate of this bug. ***
Comment 7 Heinrich Wendel (RETIRED) gentoo-dev 2004-09-27 04:09:59 UTC
added.